Switch to bool inputs instead of getBool in material_datepicker.

zacharydenton · nshahan · commit 607ddd78ce69 · 2018-04-24T09:54:32.000-07:00
PiperOrigin-RevId: 193248965
diff --git a/lib/material_datepicker/date_input.dart b/lib/material_datepicker/date_input.dart
@@ -9,7 +9,6 @@ import 'package:intl/intl.dart';
 import 'package:quiver/time.dart';
 import 'package:angular_components/material_input/material_input.dart';
 import 'package:angular_components/model/date/date.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 import 'package:angular_components/utils/disposer/disposer.dart';
 
 import 'calendar.dart';
@@ -148,8 +147,8 @@ class DateInputDirective implements OnDestroy {
   ///
   /// Only used when [isMonthInput] is true.
   @Input()
-  set rangeEnd(isRangeEnd) {
-    _isRangeEnd = getBool(isRangeEnd);
+  set rangeEnd(bool isRangeEnd) {
+    _isRangeEnd = isRangeEnd;
   }
 
   bool _isRangeEnd = false;
diff --git a/lib/material_datepicker/date_range_editor.dart b/lib/material_datepicker/date_range_editor.dart
@@ -35,7 +35,6 @@ import 'package:angular_components/model/date/date.dart';
 import 'package:angular_components/model/date/date_formatter.dart';
 import 'package:angular_components/model/observable/observable.dart';
 import 'package:angular_components/utils/angular/managed_zone/interface.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 import 'package:angular_components/utils/browser/dom_service/dom_service.dart';
 import 'package:angular_components/utils/showhide/showhide.dart';
 
@@ -90,8 +89,8 @@ class DateRangeEditorComponent implements OnInit, AfterViewInit, Focusable {
   /// This is useful for reducing visual noise during popup open/close
   /// animations. Defaults to true.
   @Input()
-  set allowHighlightUpdates(value) {
-    _allowHighlightUpdates = getBool(value);
+  set allowHighlightUpdates(bool value) {
+    _allowHighlightUpdates = value;
   }
 
   bool get allowHighlightUpdates => _allowHighlightUpdates;
@@ -103,8 +102,8 @@ class DateRangeEditorComponent implements OnInit, AfterViewInit, Focusable {
   ///
   /// Defaults to `true`.
   @Input()
-  set supportsComparison(value) {
-    _supportsComparison = getBool(value);
+  set supportsComparison(bool value) {
+    _supportsComparison = value;
   }
 
   bool get supportsComparison => _supportsComparison;
@@ -117,8 +116,8 @@ class DateRangeEditorComponent implements OnInit, AfterViewInit, Focusable {
 
   /// Whether to enable compact calendar styles.
   @Input()
-  set compact(value) {
-    _compact = getBool(value);
+  set compact(bool value) {
+    _compact = value;
   }
 
   bool get compact => _compact;
@@ -130,8 +129,8 @@ class DateRangeEditorComponent implements OnInit, AfterViewInit, Focusable {
   ///
   /// Defaults to `true`.
   @Input()
-  set supportsDaysInputs(value) {
-    _supportsDaysInputs = getBool(value);
+  set supportsDaysInputs(bool value) {
+    _supportsDaysInputs = value;
   }
 
   bool get supportsDaysInputs => _supportsDaysInputs;
@@ -211,8 +210,8 @@ class DateRangeEditorComponent implements OnInit, AfterViewInit, Focusable {
   bool get isCalendarCreated => _isCalendarCreated ?? false;
 
   @Input('calendarCreated')
-  set isCalendarCreated(value) {
-    _isCalendarCreated = getBool(value);
+  set isCalendarCreated(bool value) {
+    _isCalendarCreated = value;
   }
 
   /// Whether or not this date range picker supports clearing date range.
diff --git a/lib/material_datepicker/material_calendar_picker.dart b/lib/material_datepicker/material_calendar_picker.dart
@@ -13,7 +13,6 @@ import 'package:angular_components/material_datepicker/calendar.dart';
 import 'package:angular_components/material_datepicker/module.dart';
 import 'package:angular_components/model/date/date.dart';
 import 'package:angular_components/model/observable/observable.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 import 'package:angular_components/utils/browser/feature_detector/feature_detector.dart'
     show isEdge, isFirefox;
 
@@ -187,8 +186,8 @@ class MaterialCalendarPickerComponent
   ///
   /// Defaults to true.
   @Input()
-  set allowHighlightUpdates(value) {
-    var nowAllowed = getBool(value);
+  set allowHighlightUpdates(bool value) {
+    var nowAllowed = value;
     if (_allowHighlightUpdates != nowAllowed) {
       _allowHighlightUpdates = nowAllowed;
       if (nowAllowed) _onCalendarChange(_model.value);
@@ -242,8 +241,8 @@ class MaterialCalendarPickerComponent
 
   /// Whether to enable compact calendar styles.
   @Input()
-  set compact(value) {
-    _compact = getBool(value);
+  set compact(bool value) {
+    _compact = value;
     _isResetNeeded = true;
   }
 
diff --git a/lib/material_datepicker/material_date_grid_base.dart b/lib/material_datepicker/material_date_grid_base.dart
@@ -14,7 +14,6 @@ import 'package:angular_components/src/material_datepicker/calendar_listener.dar
 import 'package:angular_components/src/material_datepicker/enum_parsing.dart';
 import 'package:angular_components/model/date/date.dart';
 import 'package:angular_components/model/observable/observable.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 import 'package:angular_components/utils/browser/dom_service/dom_service.dart';
 import 'package:angular_components/utils/disposer/disposer.dart';
 
@@ -78,8 +77,8 @@ abstract class MaterialDateGridBase
   /// Set this to false to temporarily suppress updates to the calendar's range
   /// highlights. Defaults to true.
   @Input()
-  set allowHighlightUpdates(value) {
-    var nowAllowed = getBool(value);
+  set allowHighlightUpdates(bool value) {
+    var nowAllowed = value;
     if (_allowHighlightUpdates != nowAllowed) {
       _allowHighlightUpdates = nowAllowed;
       if (nowAllowed) onCalendarChange(model.value);
@@ -183,8 +182,8 @@ abstract class MaterialDateGridBase
 
   /// Whether to enable compact calendar styles.
   @Input()
-  set compact(value) {
-    _compact = getBool(value);
+  set compact(bool value) {
+    _compact = value;
   }
 
   bool get compact => _compact;
diff --git a/lib/material_datepicker/material_date_range_picker.dart b/lib/material_datepicker/material_date_range_picker.dart
@@ -28,7 +28,6 @@ import 'package:angular_components/model/a11y/keyboard_handler_mixin.dart';
 import 'package:angular_components/model/date/date.dart';
 import 'package:angular_components/model/date/date_formatter.dart';
 import 'package:angular_components/model/observable/observable.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 import 'package:angular_components/utils/browser/dom_service/dom_service.dart';
 import 'package:angular_components/utils/disposer/disposer.dart';
 
@@ -169,8 +168,8 @@ class MaterialDateRangePickerComponent extends KeyboardHandlerMixin
   ///
   /// Defaults to true.
   @Input()
-  set supportsComparison(value) {
-    _supportsComparison = getBool(value);
+  set supportsComparison(bool value) {
+    _supportsComparison = value;
     if (!supportsComparison && selection.value?.comparison != null) {
       selection.value =
           new DatepickerComparison.noComparison(selection.value.range);
@@ -185,8 +184,8 @@ class MaterialDateRangePickerComponent extends KeyboardHandlerMixin
   ///
   /// Defaults to true.
   @Input()
-  set showNextPrevButtons(value) {
-    _showNextPrevButtons = getBool(value);
+  set showNextPrevButtons(bool value) {
+    _showNextPrevButtons = value;
   }
 
   bool get showNextPrevButtons => _showNextPrevButtons;
@@ -198,8 +197,8 @@ class MaterialDateRangePickerComponent extends KeyboardHandlerMixin
   ///
   /// Defaults to `true`.
   @Input()
-  set supportsDaysInputs(value) {
-    _supportsDaysInputs = getBool(value);
+  set supportsDaysInputs(bool value) {
+    _supportsDaysInputs = value;
   }
 
   bool get supportsDaysInputs => _supportsDaysInputs;
@@ -208,8 +207,8 @@ class MaterialDateRangePickerComponent extends KeyboardHandlerMixin
 
   /// Whether to enable compact calendar styles.
   @Input()
-  set compact(value) {
-    _compact = getBool(value);
+  set compact(bool value) {
+    _compact = value;
   }
 
   bool get compact => _compact;
@@ -224,8 +223,8 @@ class MaterialDateRangePickerComponent extends KeyboardHandlerMixin
 
   /// Whether changing the selected date range should be disabled.
   @Input()
-  set disabled(value) {
-    _disabled = getBool(value);
+  set disabled(bool value) {
+    _disabled = value;
     // Hide popup if visible.
     if (_popupVisible && disabled) close();
   }
diff --git a/lib/material_datepicker/material_date_time_picker.dart b/lib/material_datepicker/material_date_time_picker.dart
@@ -12,7 +12,6 @@ import 'package:angular_components/material_datepicker/material_time_picker.dart
 import 'package:angular_components/material_datepicker/module.dart';
 import 'package:angular_components/material_input/material_input.dart';
 import 'package:angular_components/model/date/date.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 
 /// A material-design-styled single date and time picker.
 ///
@@ -91,7 +90,7 @@ class MaterialDateTimePickerComponent {
 
   /// Whether changing the selected date and time should be disabled.
   @Input()
-  set disabled(dynamic value) => _disabled = getBool(value);
+  set disabled(bool value) => _disabled = value;
 
   bool _required = false;
   bool get required => _required;
@@ -101,7 +100,7 @@ class MaterialDateTimePickerComponent {
   /// If true, the embedded text fields will display an error to the user if
   /// blank. If false, clearing the text fields will set [dateTime] to `null`.
   @Input()
-  set required(dynamic value) => _required = getBool(value);
+  set required(bool value) => _required = value;
 
   bool get utc => _utc;
   bool _utc = false;
@@ -110,8 +109,8 @@ class MaterialDateTimePickerComponent {
   ///
   /// In default, the widget returns time in the local time zone.
   @Input()
-  set utc(dynamic value) {
-    _utc = getBool(value);
+  set utc(bool value) {
+    _utc = value;
     dateTime = _utc ? _dateTime?.toUtc() : _dateTime?.toLocal();
   }
 
diff --git a/lib/material_datepicker/material_datepicker.dart b/lib/material_datepicker/material_datepicker.dart
@@ -29,7 +29,6 @@ import 'package:angular_components/material_select/material_select_item.dart';
 import 'package:angular_components/mixins/focusable_mixin.dart';
 import 'package:angular_components/model/a11y/keyboard_handler_mixin.dart';
 import 'package:angular_components/model/date/date.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 
 /// A material-design-styled single date picker -- a date parsing input and
 /// calendar picker. Users can type in their own custom dates, or click on the
@@ -100,8 +99,8 @@ class MaterialDatepickerComponent extends KeyboardHandlerMixin
 
   /// Whether to enable compact calendar styles.
   @Input()
-  set compact(value) {
-    _compact = getBool(value);
+  set compact(bool value) {
+    _compact = value;
   }
 
   bool get compact => _compact;
diff --git a/lib/material_datepicker/material_time_picker.dart b/lib/material_datepicker/material_time_picker.dart
@@ -15,7 +15,6 @@ import 'package:angular_components/model/a11y/keyboard_handler_mixin.dart';
 import 'package:angular_components/model/selection/select.dart';
 import 'package:angular_components/model/selection/selection_model.dart';
 import 'package:angular_components/model/selection/string_selection_options.dart';
-import 'package:angular_components/utils/angular/properties/properties.dart';
 import 'package:angular_components/utils/disposer/disposer.dart';
 
 /// A material-design-styled time input component.
@@ -95,7 +94,7 @@ class MaterialTimePickerComponent extends KeyboardHandlerMixin
 
   /// Whether changing the selected time should be disabled.
   @Input()
-  set disabled(dynamic value) => _disabled = getBool(value);
+  set disabled(bool value) => _disabled = value;
 
   bool _required = false;
   bool get required => _required;
@@ -105,7 +104,7 @@ class MaterialTimePickerComponent extends KeyboardHandlerMixin
   /// If true, the embedded text field will display an error to the user if
   /// blank. If false, clearing the text field will set `time` to `null`.
   @Input()
-  set required(dynamic value) => _required = getBool(value);
+  set required(bool value) => _required = value;
 
   bool get utc => _utc;
   bool _utc = false;
@@ -114,8 +113,8 @@ class MaterialTimePickerComponent extends KeyboardHandlerMixin
   ///
   /// By default, the widget returns time in the local time zone.
   @Input()
-  set utc(dynamic value) {
-    _utc = getBool(value);
+  set utc(bool value) {
+    _utc = value;
 
     timeOptions = new TimeSelectionOptions(
         new List<DateTime>.generate(24, _utc ? _utcTime : _localTime));
