Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Commit 7a0ae37

Browse files
rkjnshahan
authored andcommitted
Remove visibility.all from @component annotations. This is potentially BREAKING
change. Please review carefully. Breakage will only be caught if the code is covered by tests. Reject this change if you believe it breaks you. If the component needs to be injected anywhere in the app, you can get a runtime exception after this change. This should be caught by tests using your components, and fixing the issue should be trivial, as the exceptions have good error messages, such as "No provider found for FooComponent". PiperOrigin-RevId: 190966716
1 parent 6942e9c commit 7a0ae37

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

lib/highlighted_text/highlighted_text.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ import 'package:angular_components/model/ui/highlighted_text_model.dart';
2424
styleUrls: const ['highlighted_text.scss.css'],
2525
directives: const [NgFor],
2626
changeDetection: ChangeDetectionStrategy.OnPush,
27-
// TODO(google): Change to `Visibility.local` to reduce code size.
28-
visibility: Visibility.all,
2927
)
3028
class HighlightedTextComponent {
3129
/// List of [HighlightedTextSegment]s to present.

0 commit comments

Comments
 (0)