Change the dropdown-icon-spacing mixin to accept any margin value, not just margin-left.

Googler · nshahan · commit 92513c20d3b7 · 2019-04-15T15:42:30.000-07:00
PiperOrigin-RevId: 243580588
diff --git a/angular_components/lib/material_datepicker/material_date_range_picker.scss b/angular_components/lib/material_datepicker/material_date_range_picker.scss
@@ -86,7 +86,7 @@ $main-font-size: 13px;
 }
 
 .menu-lookalike {
-  @include dropdown-icon-spacing($mat-grid * 2);
+  @include dropdown-icon-spacing(0 0 0 $mat-grid * 2);
 }
 
 .next-prev-buttons {
diff --git a/angular_components/lib/material_datepicker/material_datepicker.scss b/angular_components/lib/material_datepicker/material_datepicker.scss
@@ -49,7 +49,7 @@ $main-font-size: 13px;
 }
 
 .menu-lookalike {
-  @include dropdown-icon-spacing($mat-grid * 2);
+  @include dropdown-icon-spacing(0 0 0 $mat-grid * 2);
   width: $mat-grid * 22; // looks about right
 }
 
diff --git a/angular_components/lib/material_datepicker/material_time_picker.scss b/angular_components/lib/material_datepicker/material_time_picker.scss
@@ -11,7 +11,7 @@ $time-picker-width: $mat-grid * 18;
 
 :host {
   dropdown-button {
-    @include dropdown-icon-spacing($mat-grid * 2);
+    @include dropdown-icon-spacing(0 0 0 $mat-grid * 2);
     width: $time-picker-width;
 
     .button-text {
diff --git a/angular_components/lib/material_select/_mixins.scss b/angular_components/lib/material_select/_mixins.scss
@@ -51,10 +51,10 @@
   }
 }
 
-/// Adds spacing between text and icon in dropdown button.
-@mixin dropdown-icon-spacing($spacing) {
+/// Sets margin around the icon in dropdown button.
+@mixin dropdown-icon-spacing($margin) {
   ::ng-deep .icon {
-    margin-left: $spacing;
+    margin: $margin;
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ $main-font-size: 13px;`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`.menu-lookalike {`
`89`		`- @include dropdown-icon-spacing($mat-grid * 2);`
	`89`	`+ @include dropdown-icon-spacing(0 0 0 $mat-grid * 2);`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`.next-prev-buttons {`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ $main-font-size: 13px;`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`.menu-lookalike {`
`52`		`- @include dropdown-icon-spacing($mat-grid * 2);`
	`52`	`+ @include dropdown-icon-spacing(0 0 0 $mat-grid * 2);`
`53`	`53`	`width: $mat-grid * 22; // looks about right`
`54`	`54`	`}`
`55`	`55`
Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,10 @@`
`51`	`51`	`}`
`52`	`52`	`}`
`53`	`53`
`54`		`-/// Adds spacing between text and icon in dropdown button.`
`55`		`-@mixin dropdown-icon-spacing($spacing) {`
	`54`	`+/// Sets margin around the icon in dropdown button.`
	`55`	`+@mixin dropdown-icon-spacing($margin) {`
`56`	`56`	`::ng-deep .icon {`
`57`		`- margin-left: $spacing;`
	`57`	`+ margin: $margin;`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`