Skip to content
This repository was archived by the owner on May 20, 2023. It is now read-only.

Commit eed1659

Browse files
rkjnshahan
authored andcommitted
Make the EntityFormatters implement the regular Formatters, this is true in all
cases, didn't do before because of conflicting generics, code is fixed since. #acx #formatter PiperOrigin-RevId: 207027252
1 parent 99905b2 commit eed1659

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lib/model/formatters/formatter.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,16 +29,14 @@ abstract class StyleFormatter<T> implements Formatter<T> {
2929
/// String formatEntityField(Map entity, value, [String args]) => ...
3030
/// }
3131
/// ```
32-
// TODO(google): add implements Formatter<T>
33-
abstract class EntityFormatter<T> {
32+
abstract class EntityFormatter<T> implements Formatter<T> {
3433
String formatEntityField(Map entity, T value, [String parameters]);
3534
}
3635

3736
/// Generates list of css classes based on entity value.
3837
///
3938
/// This list will be merged with one returned by [StyleFormatter.computeStyle].
40-
// TODO(google): add implements StyleFormatter<T>
41-
abstract class EntityStyleFormatter<T> {
39+
abstract class EntityStyleFormatter<T> implements StyleFormatter<T> {
4240
/// Returns list of classes to style the value.
4341
List<String> computeEntityStyle(Map entity, T value, [String parameters]);
4442
}

0 commit comments

Comments
 (0)