moved stream functions for consistency

Author: benholloway

lib/test/karma.js

@@ -70,10 +70,8 @@ function getKarmaReporterPluginPath(reporterName) {
 /**
  * Determine the registered reporter name.
  *
- * @param {string} reporterName Either the registered reporter name,
- *   *OR* an absolute path, for a karma reporter.
- * @return {string} The registered reporter name for use in
- *   the `reporters` section of the karma config file.
+ * @param {string} reporterName Either the registered reporter name, or an absolute path for a karma reporter.
+ * @return {string} The registered reporter name for use in the `reporters` section of the karma config file.
  */
 function getKarmaReporterName(reporterName) {
   if (typeof reporterName !== 'string') {
@@ -159,44 +157,39 @@ function karmaCreateConfig(reporters, configFileName) {
  * No output. Ends when the Karma process ends.
  * Runs karma in a child process, to avoid `process.exit()` called by karma.
  *
- * @param {Array.<string>} [reporters] The name of the karma reporter to use
  * @returns {stream.Through} A through stream intended to have a gulp stream piped through it
  */
-function karmaRun(reporters) {
+function karmaRun() {
   var options = {
-    configFile: undefined
+    configFile: undefined // populated from the input stream
   };
-  if (reporters.constructor !== Array || reporters.length === 0) {
-    throw new Error('No reporters specified');
-  }
-
-  return through.obj(function transformFn(file, encoding, done) {
+  function transformFn(file, encoding, done) {
     options.configFile = file.path;
     done();
-  },
-  function streamFn(done) {
+  }
+  function flushFn(done) {
     var appPath = path.join(__dirname, 'karma-background.js');
     var data    = querystring.escape(JSON.stringify(options));
 
-    var karmaBackground = childProcess.spawn('node', [appPath, data], {
-      cwd: process.cwd(),
-      stdio: [process.stdin, process.stdout, process.stderr],
-      env: lodashMerge(process.env, {
+    childProcess.spawn('node', [appPath, data], {
+      cwd  : process.cwd(),
+      stdio: 'inherit',
+      env  : lodashMerge(process.env, {
         //NOTE this workaround is necessary, see issue:
         //https://github.com/sindresorhus/supports-color/issues/13
         //TODO @bguiz remove workaround when issue has been resolved
         SUPPORTS_COLOR: true
       })
-    });
-    karmaBackground.on('close', function() {
-      done();
-      return;
-    });
-  });
+    })
+      .on('close', function() {
+        done();
+      });
+  }
+  return through.obj(transformFn, flushFn);
 }
 
 var yargsOptionDefinition = {
-  key: 'karma-reporter',
+  key  : 'karma-reporter',
   value: {
     describe: 'Specify a custom Karma reporter to use. Either a locally npm installed module, or an asolute path to ' +
     'one.',