Skip to content

Commit 30d7fe1

Browse files
author
benholloway
committed
use todo only in specific places and helloworld otherwise
1 parent 33bf9f2 commit 30d7fe1

File tree

8 files changed

+92
-47
lines changed

8 files changed

+92
-47
lines changed

‎package.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@
112112
"jshint-stylish": "^1.0.1",
113113
"ncp": "~2.0.0",
114114
"ps-tree": "~0.0.3",
115+
"angularity-helloworld-es5": "angularity/angularity-helloworld-es5#ci-build",
115116
"angularity-todo-es5": "angularity/angularity-todo-es5#ci-build"
116117
}
117118
}

‎test/specs/tasks/build.spec.js‎

Lines changed: 41 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -43,26 +43,48 @@ describe('The Angularity build task', function () {
4343
}
4444
});
4545

46-
describe('should operate minified (by default)', function(done) {
47-
helper.runner.create()
48-
.addSource('angularity-todo-es5')
49-
.addParameters({ subdir: 'app-minified' })
50-
.addInvocation('build')
51-
.addInvocation('build --unminified false')
52-
.addInvocation('build -u false')
53-
.forEach(slowIt(buildTask.expectations))
54-
.finally(done);
46+
describe('full test with small application', function() {
47+
describe('should operate minified (by default)', function(done) {
48+
helper.runner.create()
49+
.addSource('angularity-helloworld-es5')
50+
.addParameters({ subdir: 'app-minified' })
51+
.addInvocation('build')
52+
.addInvocation('build --unminified false')
53+
.addInvocation('build -u false')
54+
.forEach(slowIt(buildTask.expectations))
55+
.finally(done);
56+
});
57+
58+
describe('should operate unminified', function(done) {
59+
helper.runner.create()
60+
.addSource('angularity-helloworld-es5')
61+
.addParameters({ subdir: 'app-unminified' })
62+
.addInvocation('build --unminified')
63+
.addInvocation('build -u')
64+
.addInvocation('build --unminified true')
65+
.addInvocation('build -u true')
66+
.forEach(slowIt(buildTask.expectations))
67+
.finally(done);
68+
});
5569
});
5670

57-
describe('should operate unminified', function(done) {
58-
helper.runner.create()
59-
.addSource('angularity-todo-es5')
60-
.addParameters({ subdir: 'app-unminified' })
61-
.addInvocation('build --unminified')
62-
.addInvocation('build -u')
63-
.addInvocation('build --unminified true')
64-
.addInvocation('build -u true')
65-
.forEach(slowIt(buildTask.expectations))
66-
.finally(done);
71+
describe('smoke test with larger application', function() {
72+
describe('should operate minified (by default)', function (done) {
73+
helper.runner.create()
74+
.addSource('angularity-todo-es5')
75+
.addParameters({subdir: 'app-minified'})
76+
.addInvocation('build')
77+
.forEach(slowIt(buildTask.expectations))
78+
.finally(done);
79+
});
80+
81+
describe('should operate unminified', function (done) {
82+
helper.runner.create()
83+
.addSource('angularity-todo-es5')
84+
.addParameters({subdir: 'app-unminified'})
85+
.addInvocation('build -u')
86+
.forEach(slowIt(buildTask.expectations))
87+
.finally(done);
88+
});
6789
});
6890
});

‎test/specs/tasks/css.spec.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('The Angularity css task', function () {
4343

4444
describe('should compile css correctly', function(done) {
4545
helper.runner.create()
46-
.addSource('angularity-todo-es5')
46+
.addSource('angularity-helloworld-es5')
4747
.addParameters({ subdir: 'app-minified' })
4848
.addInvocation('css')
4949
.forEach(slowIt(cssTask.expectations))

‎test/specs/tasks/javascript.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ describe('The Angularity javascript task', function () {
4545

4646
describe('should operate minified (by default)', function(done) {
4747
helper.runner.create()
48-
.addSource('angularity-todo-es5')
48+
.addSource('angularity-helloworld-es5')
4949
.addParameters({ subdir: 'app-minified' })
5050
.addInvocation('javascript')
5151
.addInvocation('javascript --unminified false')
@@ -56,7 +56,7 @@ describe('The Angularity javascript task', function () {
5656

5757
describe('should operate unminified', function(done) {
5858
helper.runner.create()
59-
.addSource('angularity-todo-es5')
59+
.addSource('angularity-helloworld-es5')
6060
.addParameters({ subdir: 'app-unminified' })
6161
.addInvocation('javascript --unminified')
6262
.addInvocation('javascript -u')

‎test/specs/tasks/release.spec.js‎

Lines changed: 41 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -43,27 +43,49 @@ describe('The Angularity release task', function () {
4343
}
4444
});
4545

46-
describe('should operate minified (by default)', function(done) {
47-
helper.runner.create()
48-
.addSource('angularity-todo-es5')
49-
.addParameters({ subdir: 'app-minified' })
50-
.addInvocation('release')
51-
.addInvocation('release --unminified false')
52-
.addInvocation('release -u false')
53-
.forEach(slowIt(expectations))
54-
.finally(done);
46+
describe('full test with small application', function() {
47+
describe('should operate minified (by default)', function (done) {
48+
helper.runner.create()
49+
.addSource('angularity-helloworld-es5')
50+
.addParameters({subdir: 'app-minified'})
51+
.addInvocation('release')
52+
.addInvocation('release --unminified false')
53+
.addInvocation('release -u false')
54+
.forEach(slowIt(expectations))
55+
.finally(done);
56+
});
57+
58+
describe('should operate unminified', function (done) {
59+
helper.runner.create()
60+
.addSource('angularity-helloworld-es5')
61+
.addParameters({subdir: 'app-unminified'})
62+
.addInvocation('release --unminified')
63+
.addInvocation('release -u')
64+
.addInvocation('release --unminified true')
65+
.addInvocation('release -u true')
66+
.forEach(slowIt(expectations))
67+
.finally(done);
68+
});
5569
});
5670

57-
describe('should operate unminified', function(done) {
58-
helper.runner.create()
59-
.addSource('angularity-todo-es5')
60-
.addParameters({ subdir: 'app-unminified' })
61-
.addInvocation('release --unminified')
62-
.addInvocation('release -u')
63-
.addInvocation('release --unminified true')
64-
.addInvocation('release -u true')
65-
.forEach(slowIt(expectations))
66-
.finally(done);
71+
describe('smoke test with larger application', function() {
72+
describe('should operate minified (by default)', function (done) {
73+
helper.runner.create()
74+
.addSource('angularity-todo-es5')
75+
.addParameters({subdir: 'app-minified'})
76+
.addInvocation('release')
77+
.forEach(slowIt(expectations))
78+
.finally(done);
79+
});
80+
81+
describe('should operate unminified', function (done) {
82+
helper.runner.create()
83+
.addSource('angularity-todo-es5')
84+
.addParameters({subdir: 'app-unminified'})
85+
.addInvocation('release -u')
86+
.forEach(slowIt(expectations))
87+
.finally(done);
88+
});
6789
});
6890
});
6991

‎test/specs/tasks/test.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ describe('The Angularity test task', function () {
4747

4848
describe('should build unminified javascript and run tests', function(done) {
4949
helper.runner.create()
50-
.addSource('angularity-todo-es5')
50+
.addSource('angularity-helloworld-es5')
5151
.addParameters({ subdir: 'app-minified' })
5252
.addInvocation('test')
5353
.forEach(slowIt(expectations))
@@ -56,7 +56,7 @@ describe('The Angularity test task', function () {
5656

5757
describe('should support unminified option, but not minify test output', function(done) {
5858
helper.runner.create()
59-
.addSource('angularity-todo-es5')
59+
.addSource('angularity-helloworld-es5')
6060
.addParameters({ subdir: 'app-unminified' })
6161
.addInvocation('test --unminified')
6262
.addInvocation('test -u')

‎test/specs/tasks/watch.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ describe('The Angularity watch task', function () {
4747

4848
describe('should operate minified (by default)', function(done) {
4949
helper.runner.create()
50-
.addSource('angularity-todo-es5')
50+
.addSource('angularity-helloworld-es5')
5151
.addParameters({ subdir: 'app-minified' })
5252
.addInvocation('watch')
5353
.addInvocation('watch --unminified false')
@@ -58,7 +58,7 @@ describe('The Angularity watch task', function () {
5858

5959
describe('should operate unminified', function(done) {
6060
helper.runner.create()
61-
.addSource('angularity-todo-es5')
61+
.addSource('angularity-helloworld-es5')
6262
.addParameters({ subdir: 'app-unminified' })
6363
.addInvocation('watch --unminified')
6464
.addInvocation('watch -u')

‎test/specs/tasks/webstorm.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ if (!platform.isAppveyor()) {
4545

4646
describe('should fail where angularity.json is not present', function (done) {
4747
helper.runner.create()
48-
.addSource('angularity-todo-es5')
48+
.addSource('angularity-helloworld-es5')
4949
.withSourceFilter(function removeBuildFiles(value) {
5050
return !(/angularity.json$/.test(value));
5151
})
@@ -60,7 +60,7 @@ if (!platform.isAppveyor()) {
6060

6161
describe('should operate with all flags false', function (done) {
6262
helper.runner.create()
63-
.addSource('angularity-todo-es5')
63+
.addSource('angularity-helloworld-es5')
6464
.addInvocation('webstorm', FLAGS.map(composeOption(false)))
6565
.forEach(slowIt(expectations))
6666
.finally(done);

0 commit comments

Comments
 (0)