Skip to content

Commit 3773df4

Browse files
committed
=BG= make reporter CLI flags more conventional (rename)
- `--karma-reporter`, `-k` (was: `--karmareporter`, `-k`) - `--jshint-reporter`, `-j` (was: `--reporter`, `-r`)
1 parent 7fccac4 commit 3773df4

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

lib/test/karma.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ function karmaRun(reporters, bannerWidth) {
230230
};
231231

232232
var yargsOptionDefiniton = {
233-
key: 'karmareporter',
233+
key: 'karma-reporter',
234234
value: {
235235
describe: 'Specify a custom Karma reporter to use. ' +
236236
'Either a locally npm installed module, or an asolute path to one.',

lib/util/jshint-reporter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,11 @@ function getJsHintReporter(reporterName) {
7878
}
7979

8080
var yargsOptionDefiniton = {
81-
key: 'reporter',
81+
key: 'jshint-reporter',
8282
value: {
8383
describe: 'Specify a custom JsHint reporter to use. Either a locally npm installed module, or the absolute path ' +
8484
'to one.',
85-
alias: ['r'],
85+
alias: ['j'],
8686
default: defaultReporterName,
8787
string: true
8888
}

tasks/javascript.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,12 @@ gulp.task('javascript:lint', function () {
107107
.append(streams.jsLib())
108108
.append(streams.jsSpec())
109109
.pipe(jshint())
110-
.pipe(jshintReporter.get(cliArgs.reporter));
110+
.pipe(jshintReporter.get(cliArgs[jshintReporter.yargsOption.key]));
111111
});
112112

113113
// karma unit tests in local library only
114114
gulp.task('javascript:unit', function () {
115-
var reporters = [].concat(cliArgs.karmareporter)
115+
var reporters = [].concat(cliArgs[karma.yargsOption.key])
116116
.filter(function isString(value) {
117117
return (typeof value === 'string');
118118
});

0 commit comments

Comments
 (0)