Skip to content

Commit 77ddfa4

Browse files
author
benholloway
committed
need to be more defensive with webstorm launch parameter
1 parent 9aaceb2 commit 77ddfa4

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

tasks/webstorm.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,9 @@ function setUpWebStormTask(context) {
195195
.wrap(80);
196196
cliArgs = yargsInstance.argv;
197197

198+
// launch parameter should be boolean for consistency with defaults
199+
cliArgs.launch = (cliArgs.launch === 'true') ? true : (cliArgs.launch === 'false') ? false : cliArgs.launch;
200+
198201
gulp.task('webstorm', function (done) {
199202
console.log(hr('-', 80, 'webstorm'));
200203

@@ -209,14 +212,13 @@ function setUpWebStormTask(context) {
209212
}
210213
// else run the selected items
211214
else {
212-
var launch = (String(cliArgs.launch) !== 'false');
213215
var taskList = [
214216
cliArgs.subdir && 'webstorm:subdir',
215217
cliArgs.project && 'webstorm:project',
216218
cliArgs.external && 'webstorm:externaltools',
217219
cliArgs.codestyle && 'webstorm:codestyle',
218220
cliArgs.templates && 'webstorm:templates',
219-
launch && 'webstorm:launch'
221+
cliArgs.launch && 'webstorm:launch'
220222
].filter(Boolean);
221223
if (taskList.length > 0) {
222224
runSequence.apply(runSequence, taskList.concat(done));

0 commit comments

Comments
 (0)