Skip to content

Commit 0b57d17

Browse files
angularsenangularsen
authored
Add Claude Code GitHub Workflow (#1622)
## 🤖 Installing Claude Code GitHub App This PR adds a GitHub Actions workflow that enables Claude Code integration in our repository. ### What is Claude Code? [Claude Code](https://claude.ai/code) is an AI coding agent that can help with: - Bug fixes and improvements - Documentation updates - Implementing new features - Code reviews and suggestions - Writing tests - And more! ### How it works Once this PR is merged, we'll be able to interact with Claude by mentioning @claude in a pull request or issue comment. Once the workflow is triggered, Claude will analyze the comment and surrounding context, and execute on the request in a GitHub action. ### Important Notes - **This workflow won't take effect until this PR is merged** - **@claude mentions won't work until after the merge is complete** - The workflow runs automatically whenever Claude is mentioned in PR or issue comments - Claude gets access to the entire PR or issue context including files, diffs, and previous comments ### Security - Our Anthropic API key is securely stored as a GitHub Actions secret - Only users with write access to the repository can trigger the workflow - All Claude runs are stored in the GitHub Actions run history - Claude's default tools are limited to reading/writing files and interacting with our repo by creating comments, branches, and commits. - We can add more allowed tools by adding them to the workflow file like: ``` allowed_tools: Bash(npm install),Bash(npm run build),Bash(npm run lint),Bash(npm run test) ``` There's more information in the [Claude Code action repo](https://github.com/anthropics/claude-code-action). After merging this PR, let's try mentioning @claude in a comment on any PR to get started!
1 parent e04e7b8 commit 0b57d17

File tree

4 files changed

+147
-1
lines changed

4 files changed

+147
-1
lines changed

‎.claude/criteria-for-adding-quantities-and-units.md‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Criteria for adding quantities and units
2+
3+
Related wiki page: https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#a-quantity-is-a-good-fit-to-add-if-it
4+
5+
To avoid bloating the library, we want to ensure quantities and units are widely used and well defined.
6+
Avoid little used units that are obscure or too domain specific.
7+
Ask for justification and use cases if this is not clear.
8+
9+
### A quantity is a good fit to add, if it
10+
11+
- [x] Is well documented and unambiguous, e.g. has a wiki page and generally easy to find on Google
12+
- [x] Is widely used, preferably across domains
13+
- [x] Has multiple units to convert between (e.g. `Length` has kilometer, feet, nanometer etc.)
14+
- [x] Can convert to other quantities (e.g. `Length x Length = Area`)
15+
- [x] Can be represented by a `double` numeric value, integer values are not well supported and may suffer from precision errors
16+
- [x] Is not [dimensionless/unitless](https://en.wikipedia.org/wiki/Dimensionless_quantity) (consider using `Ratio`)
17+
18+
### A unit is a good fit to add to a quantity, if it
19+
20+
- [x] Is well documented and unambiguous, e.g. has a wiki page or found in online unit converters
21+
- [x] Is widely used
22+
- [x] Can be converted to other units of the same quantity
23+
- [x] The conversion function is well established without ambiguous competing standards
24+
25+
### Avoid X-per-Y units
26+
27+
There are many variations of unit A over unit B, such as `LengthPerAngle` and we want to avoid adding these unless they are very common.

‎.github/workflows/claude-code-review.yml‎

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
name: Claude Code Review
2+
3+
on:
4+
pull_request:
5+
types: [opened, synchronize]
6+
# Optional: Only run on specific file changes
7+
# paths:
8+
# - "src/**/*.ts"
9+
# - "src/**/*.tsx"
10+
# - "src/**/*.js"
11+
# - "src/**/*.jsx"
12+
13+
jobs:
14+
claude-review:
15+
# Optional: Filter by PR author
16+
# if: |
17+
# github.event.pull_request.user.login == 'external-contributor' ||
18+
# github.event.pull_request.user.login == 'new-developer' ||
19+
# github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
20+
21+
runs-on: ubuntu-latest
22+
permissions:
23+
contents: read
24+
pull-requests: read
25+
issues: read
26+
id-token: write
27+
28+
steps:
29+
- name: Checkout repository
30+
uses: actions/checkout@v4
31+
with:
32+
fetch-depth: 1
33+
34+
- name: Run Claude Code Review
35+
id: claude-review
36+
uses: anthropics/claude-code-action@v1
37+
with:
38+
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
39+
prompt: |
40+
Please review this pull request and provide feedback on:
41+
- Breaking changes, if any
42+
- Style and conventions
43+
- New quantities or units
44+
- See `.claude/pr-review-instructions.md` for guidance and criteria, they should be widely used and well defined
45+
- If it seems domain specific or obscure we ask for justification and use cases
46+
- Changes to generated code
47+
- Focus feedback on changes to code generators
48+
- Tie feedback to specific examples from generated code to explain, try to pick 1-3 quantities of different types, e.g. `Length` (`ILinearQuantity`), `Temperature` (`IAffineQuantity`) and `Level` (`ILogarithmicQuantity`)
49+
- Code quality and best practices
50+
- Potential bugs or issues
51+
- Performance considerations
52+
- Test coverage
53+
- Security concerns, but only if medium or higher severity
54+
55+
Use the repository's CLAUDE.md for guidance on style and conventions.
56+
Be constructive and helpful in your feedback, keep it concise.
57+
58+
Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR.
59+
60+
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
61+
# or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
62+
claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'
63+

‎.github/workflows/claude.yml‎

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
name: Claude Code
2+
3+
on:
4+
issue_comment:
5+
types: [created]
6+
pull_request_review_comment:
7+
types: [created]
8+
issues:
9+
types: [opened, assigned]
10+
pull_request_review:
11+
types: [submitted]
12+
13+
jobs:
14+
claude:
15+
if: |
16+
(github.event_name == 'issue_comment' && contains(github.event.comment.body, '@claude')) ||
17+
(github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) ||
18+
(github.event_name == 'pull_request_review' && contains(github.event.review.body, '@claude')) ||
19+
(github.event_name == 'issues' && (contains(github.event.issue.body, '@claude') || contains(github.event.issue.title, '@claude')))
20+
runs-on: ubuntu-latest
21+
permissions:
22+
contents: read
23+
pull-requests: read
24+
issues: read
25+
id-token: write
26+
actions: read # Required for Claude to read CI results on PRs
27+
steps:
28+
- name: Checkout repository
29+
uses: actions/checkout@v4
30+
with:
31+
fetch-depth: 1
32+
33+
- name: Run Claude Code
34+
id: claude
35+
uses: anthropics/claude-code-action@v1
36+
with:
37+
claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
38+
39+
# This is an optional setting that allows Claude to read CI results on PRs
40+
additional_permissions: |
41+
actions: read
42+
43+
# Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it.
44+
# prompt: 'Update the pull request description to include a summary of changes.'
45+
46+
# Optional: Add claude_args to customize behavior and configuration
47+
# See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
48+
# or https://docs.claude.com/en/docs/claude-code/sdk#command-line for available options
49+
# claude_args: '--model claude-opus-4-1-20250805 --allowed-tools Bash(gh pr:*)'
50+

‎CLAUDE.md‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,4 +116,10 @@ The project uses a sophisticated code generation system:
116116

117117
### Run performance benchmarks
118118
- Execute: `dotnet run -c Release --project UnitsNet.Benchmark`
119-
- Results saved to `Artifacts/` folder
119+
- Results saved to `Artifacts/` folder
120+
121+
## Pull request reviews
122+
123+
### Adding new quantities or units
124+
125+
See `.claude/criteria-for-adding-quantities-and-units.md` for instructions on adding new quantities or units to ensure they are widely used and well defined.

0 commit comments

Comments
 (0)