angularsen
diff --git a/‎.github/workflows/continious-benchmarking.yml‎
Lines changed: 1 addition & 1 deletion b/‎.github/workflows/continious-benchmarking.yml‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎.github/workflows/run-benchmarks.yml‎
Lines changed: 1 addition & 1 deletion b/‎.github/workflows/run-benchmarks.yml‎
Lines changed: 1 addition & 1 deletion
diff --git a/‎CodeGen/Generators/UnitsNetGen/NumberExtensionsGenerator.cs‎
Lines changed: 13 additions & 14 deletions b/‎CodeGen/Generators/UnitsNetGen/NumberExtensionsGenerator.cs‎
Lines changed: 13 additions & 14 deletions
diff --git a/‎Common/UnitDefinitions/ApparentEnergy.json‎
Lines changed: 2 additions & 0 deletions b/‎Common/UnitDefinitions/ApparentEnergy.json‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎Common/UnitDefinitions/ApparentPower.json‎
Lines changed: 2 additions & 0 deletions b/‎Common/UnitDefinitions/ApparentPower.json‎
Lines changed: 2 additions & 0 deletions
diff --git a/‎Common/UnitDefinitions/Capacitance.json‎
Lines changed: 2 additions & 1 deletion b/‎Common/UnitDefinitions/Capacitance.json‎
Lines changed: 2 additions & 1 deletion
diff --git a/‎Common/UnitDefinitions/DoseAreaProduct.json‎
Lines changed: 120 additions & 0 deletions b/‎Common/UnitDefinitions/DoseAreaProduct.json‎
Lines changed: 120 additions & 0 deletions
diff --git a/‎Common/UnitDefinitions/ElectricAdmittance.json‎
Lines changed: 17 additions & 2 deletions b/‎Common/UnitDefinitions/ElectricAdmittance.json‎
Lines changed: 17 additions & 2 deletions
diff --git a/‎Common/UnitDefinitions/ElectricApparentEnergy.json‎
Lines changed: 25 additions & 0 deletions b/‎Common/UnitDefinitions/ElectricApparentEnergy.json‎
Lines changed: 25 additions & 0 deletions
diff --git a/‎Common/UnitDefinitions/ElectricApparentPower.json‎
Lines changed: 26 additions & 0 deletions b/‎Common/UnitDefinitions/ElectricApparentPower.json‎
Lines changed: 26 additions & 0 deletions
@@ -68,7 +68,7 @@ jobs:
         uses: actions/[email protected]
 
       - name: Download Artifacts # The benchmark results are downloaded into a 'runtime' folder.
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v4.1.7
         with:
           name: UnitsNet Benchmarks (${{ matrix.runtime }})
           path: ${{ matrix.runtime }}
 
@@ -98,7 +98,7 @@ jobs:
 
       # The benchmark results are downloaded into a 'runtime' folder.
       - name: Download Artifacts
-        uses: actions/download-artifact@v1
+        uses: actions/download-artifact@v4.1.7
         with:
           name: ${{ github.event.inputs.benchmark-name }} (${{ github.event.inputs.runtimes }})
           path: results
 
@@ -3,19 +3,11 @@
 
 namespace CodeGen.Generators.UnitsNetGen
 {
-    internal class NumberExtensionsGenerator : GeneratorBase
+    internal class NumberExtensionsGenerator(Quantity quantity) : GeneratorBase
     {
-        private readonly Unit[] _units;
-        private readonly string _quantityName;
-
-        public NumberExtensionsGenerator(Quantity quantity)
-        {
-            if (quantity is null)
-                throw new ArgumentNullException(nameof(quantity));
-
-            _units = quantity.Units;
-            _quantityName = quantity.Name;
-        }
+        private readonly Quantity _quantity = quantity ?? throw new ArgumentNullException(nameof(quantity));
+        private readonly Unit[] _units = quantity.Units;
+        private readonly string _quantityName = quantity.Name;
 
         public string Generate()
         {
@@ -35,7 +27,10 @@ namespace UnitsNet.NumberExtensions.NumberTo{_quantityName}
 {{
     /// <summary>
     /// A number to {_quantityName} Extensions
-    /// </summary>
+    /// </summary>");
+
+                              Writer.WLIfText(1, GetObsoleteAttributeOrNull(_quantity));
+                              Writer.WL(@$"
     public static class NumberTo{_quantityName}Extensions
     {{");
 
@@ -47,7 +42,8 @@ public static class NumberTo{_quantityName}Extensions
                 Writer.WL(2, $@"
 /// <inheritdoc cref=""{_quantityName}.From{unit.PluralName}(double)"" />");
 
-                Writer.WLIfText(2, GetObsoleteAttributeOrNull(unit.ObsoleteText));
+                // Include obsolete text from the quantity per extension method, to make it visible when the class is not explicitly referenced in code.
+                Writer.WLIfText(2, GetObsoleteAttributeOrNull(unit.ObsoleteText ?? _quantity.ObsoleteText));
 
                 Writer.WL(2, $@"public static {_quantityName} {unit.PluralName}<T>(this T value)
             where T : notnull
@@ -63,6 +59,9 @@ public static class NumberTo{_quantityName}Extensions
             return Writer.ToString();
         }
 
+        /// <inheritdoc cref="GetObsoleteAttributeOrNull(string)"/>
+        private static string? GetObsoleteAttributeOrNull(Quantity quantity) => GetObsoleteAttributeOrNull(quantity.ObsoleteText);
+
         private static string? GetObsoleteAttributeOrNull(string? obsoleteText) =>
             string.IsNullOrWhiteSpace(obsoleteText) ?
             null :
 
@@ -2,6 +2,8 @@
   "Name": "ApparentEnergy",
   "BaseUnit": "VoltampereHour",
   "XmlDocSummary": "A unit for expressing the integral of apparent power over time, equal to the product of 1 volt-ampere and 1 hour, or to 3600 joules.",
+  "XmlDocRemarks": "<c>ApparentEnergy</c> has been renamed to <c>ElectricApparentEnergy</c>, and will be removed in a later major version.",
+  "ObsoleteText": "ApparentEnergy has been renamed to ElectricApparentEnergy, and will be removed in a later major version.",
   "BaseDimensions": {
     "L": 2,
     "M": 1,
 
@@ -2,6 +2,8 @@
   "Name": "ApparentPower",
   "BaseUnit": "Voltampere",
   "XmlDocSummary": "Power engineers measure apparent power as the magnitude of the vector sum of active and reactive power. Apparent power is the product of the root-mean-square of voltage and current.",
+  "XmlDocRemarks": "<c>ApparentPower</c> has been renamed to <c>ElectricApparentPower</c>, and will be removed in a later major version.",
+  "ObsoleteText": "ApparentPower has been renamed to ElectricApparentPower, and will be removed in a later major version.",
   "BaseDimensions": {
     "L": 2,
     "M": 1,
 
@@ -2,7 +2,8 @@
   "Name": "Capacitance",
   "BaseUnit": "Farad",
   "XmlDocSummary": "Capacitance is the ability of a body to store an electric charge.",
-  "XmlDocRemarks": "https://en.wikipedia.org/wiki/Capacitance",
+  "XmlDocRemarks": "<c>Capacitance</c> has been renamed to <c>ElectricCapacitance</c>, and will be removed in a later major version.",
+  "ObsoleteText": "Capacitance has been renamed to ElectricCapacitance, and will be removed in a later major version.",
   "BaseDimensions": {
     "L": -2,
     "M": -1,
 
@@ -0,0 +1,120 @@
+{
+  "Name": "DoseAreaProduct",
+  "BaseUnit": "GraySquareMeter",
+  "XmlDocSummary": "It is defined as the absorbed dose multiplied by the area irradiated.",
+  "XmlDocRemarks": "https://en.wikipedia.org/wiki/Dose_area_product",
+  "BaseDimensions": {
+    "L": 4,
+    "T": -2
+  },
+  "Units": [
+    {
+      "SingularName": "GraySquareMeter",
+      "PluralName": "GraySquareMeters",
+      "BaseUnits": {
+        "L": "Meter",
+        "T": "Second"
+      },
+      "FromUnitToBaseFunc": "{x}",
+      "FromBaseToUnitFunc": "{x}",
+      "Prefixes": [
+        "Micro",
+        "Milli",
+        "Centi",
+        "Deci"
+      ],
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [
+            "Gy·m²"
+          ]
+        },
+        {
+          "Culture": "ru-RU",
+          "Abbreviations": [
+            "Гр·м²"
+          ]
+        }
+      ]
+    },
+    {
+      "SingularName": "GraySquareDecimeter",
+      "PluralName": "GraySquareDecimeters",
+      "FromUnitToBaseFunc": "{x} / 100",
+      "FromBaseToUnitFunc": "{x} * 100",
+      "Prefixes": [
+        "Micro",
+        "Milli",
+        "Centi",
+        "Deci"
+      ],
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [
+            "Gy·dm²"
+          ]
+        },
+        {
+          "Culture": "ru-RU",
+          "Abbreviations": [
+            "Гр·дм²"
+          ]
+        }
+      ]
+    },
+    {
+      "SingularName": "GraySquareCentimeter",
+      "PluralName": "GraySquareCentimeters",
+      "FromUnitToBaseFunc": "{x} / 10000",
+      "FromBaseToUnitFunc": "{x} * 10000",
+      "Prefixes": [
+        "Micro",
+        "Milli",
+        "Centi",
+        "Deci"
+      ],
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [
+            "Gy·cm²"
+          ]
+        },
+        {
+          "Culture": "ru-RU",
+          "Abbreviations": [
+            "Гр·см²"
+          ]
+        }
+      ]
+    },
+    {
+      "SingularName": "GraySquareMillimeter",
+      "PluralName": "GraySquareMillimeters",
+      "FromUnitToBaseFunc": "{x} / 1000000",
+      "FromBaseToUnitFunc": "{x} * 1000000",
+      "Prefixes": [
+        "Micro",
+        "Milli",
+        "Centi",
+        "Deci"
+      ],
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [
+            "Gy·mm²"
+          ]
+        },
+        {
+          "Culture": "ru-RU",
+          "Abbreviations": [
+            "Гр·мм²"
+          ]
+        }
+      ]
+    }
+  ]
+}
@@ -1,7 +1,9 @@
 {
   "Name": "ElectricAdmittance",
   "BaseUnit": "Siemens",
-  "XmlDocSummary": "Electric admittance is a measure of how easily a circuit or device will allow a current to flow. It is defined as the inverse of impedance. The SI unit of admittance is the siemens (symbol S).",
+  "XmlDocSummary": "Electric admittance is a measure of how easily a circuit or device will allow a current to flow by the combined effect of conductance and susceptance in a circuit. It is defined as the inverse of impedance. The SI unit of admittance is the siemens (symbol S).",
+  "XmlDocRemarks": "https://en.wikipedia.org/wiki/Electrical_admittance",
+  "ObsoleteText": "Admittance is a complex number, which is not currently supported by UnitsNet. Please use either ElectricConductance or ElectricSusceptance instead.",
   "BaseDimensions": {
     "L": -2,
     "M": -1,
@@ -14,13 +16,26 @@
       "PluralName": "Siemens",
       "FromUnitToBaseFunc": "{x}",
       "FromBaseToUnitFunc": "{x}",
-      "Prefixes": [ "Nano", "Micro", "Milli" ],
+      "Prefixes": [ "Nano", "Micro", "Milli", "Kilo", "Mega", "Giga", "Tera" ],
       "Localization": [
         {
           "Culture": "en-US",
           "Abbreviations": [ "S" ]
         }
       ]
+    },
+    {
+      "SingularName": "Mho",
+      "PluralName": "Mhos",
+      "FromUnitToBaseFunc": "{x}",
+      "FromBaseToUnitFunc": "{x}",
+      "Prefixes": [ "Nano", "Micro", "Milli", "Kilo", "Mega", "Giga", "Tera" ],
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [ "℧" ]
+        }
+      ]
     }
   ]
 }
@@ -0,0 +1,25 @@
+{
+  "Name": "ElectricApparentEnergy",
+  "BaseUnit": "VoltampereHour",
+  "XmlDocSummary": "A unit for expressing the integral of apparent power over time, equal to the product of 1 volt-ampere and 1 hour, or to 3600 joules.",
+  "BaseDimensions": {
+    "L": 2,
+    "M": 1,
+    "T": -2
+  },
+  "Units": [
+    {
+      "SingularName": "VoltampereHour",
+      "PluralName": "VoltampereHours",
+      "FromUnitToBaseFunc": "{x}",
+      "FromBaseToUnitFunc": "{x}",
+      "Prefixes": [ "Kilo", "Mega" ],
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [ "VAh" ]
+        }
+      ]
+    }
+  ]
+}
@@ -0,0 +1,26 @@
+{
+  "Name": "ElectricApparentPower",
+  "BaseUnit": "Voltampere",
+  "XmlDocSummary": "Power engineers measure apparent power as the magnitude of the vector sum of active and reactive power. It is the product of the root mean square voltage (in volts) and the root mean square current (in amperes).",
+  "XmlDocRemarks": "https://en.wikipedia.org/wiki/AC_power#Active,_reactive,_apparent,_and_complex_power_in_sinusoidal_steady-state",
+  "BaseDimensions": {
+    "L": 2,
+    "M": 1,
+    "T": -3
+  },
+  "Units": [
+    {
+      "SingularName": "Voltampere",
+      "PluralName": "Voltamperes",
+      "FromUnitToBaseFunc": "{x}",
+      "FromBaseToUnitFunc": "{x}",
+      "Prefixes": [ "Micro", "Milli", "Kilo", "Mega", "Giga" ],
+      "Localization": [
+        {
+          "Culture": "en-US",
+          "Abbreviations": [ "VA" ]
+        }
+      ]
+    }
+  ]
+}
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,9 @@`
`1`	`1`	`{`
`2`	`2`	`"Name": "ElectricAdmittance",`
`3`	`3`	`"BaseUnit": "Siemens",`
`4`		`- "XmlDocSummary": "Electric admittance is a measure of how easily a circuit or device will allow a current to flow. It is defined as the inverse of impedance. The SI unit of admittance is the siemens (symbol S).",`
	`4`	`+ "XmlDocSummary": "Electric admittance is a measure of how easily a circuit or device will allow a current to flow by the combined effect of conductance and susceptance in a circuit. It is defined as the inverse of impedance. The SI unit of admittance is the siemens (symbol S).",`
	`5`	`+ "XmlDocRemarks": "https://en.wikipedia.org/wiki/Electrical_admittance",`
	`6`	`+ "ObsoleteText": "Admittance is a complex number, which is not currently supported by UnitsNet. Please use either ElectricConductance or ElectricSusceptance instead.",`
`5`	`7`	`"BaseDimensions": {`
`6`	`8`	`"L": -2,`
`7`	`9`	`"M": -1,`
`@@ -14,13 +16,26 @@`
`14`	`16`	`"PluralName": "Siemens",`
`15`	`17`	`"FromUnitToBaseFunc": "{x}",`
`16`	`18`	`"FromBaseToUnitFunc": "{x}",`
`17`		`- "Prefixes": [ "Nano", "Micro", "Milli" ],`
	`19`	`+ "Prefixes": [ "Nano", "Micro", "Milli", "Kilo", "Mega", "Giga", "Tera" ],`
`18`	`20`	`"Localization": [`
`19`	`21`	`{`
`20`	`22`	`"Culture": "en-US",`
`21`	`23`	`"Abbreviations": [ "S" ]`
`22`	`24`	`}`
`23`	`25`	`]`
	`26`	`+ },`
	`27`	`+ {`
	`28`	`+ "SingularName": "Mho",`
	`29`	`+ "PluralName": "Mhos",`
	`30`	`+ "FromUnitToBaseFunc": "{x}",`
	`31`	`+ "FromBaseToUnitFunc": "{x}",`
	`32`	`+ "Prefixes": [ "Nano", "Micro", "Milli", "Kilo", "Mega", "Giga", "Tera" ],`
	`33`	`+ "Localization": [`
	`34`	`+ {`
	`35`	`+ "Culture": "en-US",`
	`36`	`+ "Abbreviations": [ "℧" ]`
	`37`	`+ }`
	`38`	`+ ]`
`24`	`39`	`}`
`25`	`40`	`]`
`26`	`41`	`}`