Skip to content

Commit 13b3e64

Browse files
bplubellangularsen
authored andcommitted
No Undefined enum value for Units property (#480)
* Check that unit enum array does not contain undefined Update only the script for generating the tests for all quantities. * Generate tests with test for undefined value in Units property Result of running generate-code.bat. All new tests currently fail. * Exclude the Undefined enum value from Units property for all quanities Update only the script for generating the quantity classes for all quantities. * Generate quantity classes that exclude Undefined in the Units property Result of running generate-code.bat. All new tests pass.
1 parent 7725be0 commit 13b3e64

File tree

182 files changed

+912
-184
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

182 files changed

+912
-184
lines changed

Common/GeneratedCode/Quantities/Acceleration.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public Acceleration(double meterspersecondsquared)
101101
#if WINDOWS_UWP
102102
private
103103
#else
104-
public
104+
public
105105
#endif
106106
Acceleration(double numericValue, AccelerationUnit unit)
107107
{
@@ -159,7 +159,7 @@ public static BaseDimensions BaseDimensions
159159
/// <summary>
160160
/// All units of measurement for the Acceleration quantity.
161161
/// </summary>
162-
public static AccelerationUnit[] Units { get; } = Enum.GetValues(typeof(AccelerationUnit)).Cast<AccelerationUnit>().ToArray();
162+
public static AccelerationUnit[] Units { get; } = Enum.GetValues(typeof(AccelerationUnit)).Cast<AccelerationUnit>().Except(new AccelerationUnit[]{ AccelerationUnit.Undefined }).ToArray();
163163

164164
/// <summary>
165165
/// Get Acceleration in CentimetersPerSecondSquared.

Common/GeneratedCode/Quantities/AmountOfSubstance.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public AmountOfSubstance(double moles)
101101
#if WINDOWS_UWP
102102
private
103103
#else
104-
public
104+
public
105105
#endif
106106
AmountOfSubstance(double numericValue, AmountOfSubstanceUnit unit)
107107
{
@@ -159,7 +159,7 @@ public static BaseDimensions BaseDimensions
159159
/// <summary>
160160
/// All units of measurement for the AmountOfSubstance quantity.
161161
/// </summary>
162-
public static AmountOfSubstanceUnit[] Units { get; } = Enum.GetValues(typeof(AmountOfSubstanceUnit)).Cast<AmountOfSubstanceUnit>().ToArray();
162+
public static AmountOfSubstanceUnit[] Units { get; } = Enum.GetValues(typeof(AmountOfSubstanceUnit)).Cast<AmountOfSubstanceUnit>().Except(new AmountOfSubstanceUnit[]{ AmountOfSubstanceUnit.Undefined }).ToArray();
163163

164164
/// <summary>
165165
/// Get AmountOfSubstance in Centimoles.

Common/GeneratedCode/Quantities/AmplitudeRatio.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public AmplitudeRatio(double decibelvolts)
100100
#if WINDOWS_UWP
101101
private
102102
#else
103-
public
103+
public
104104
#endif
105105
AmplitudeRatio(double numericValue, AmplitudeRatioUnit unit)
106106
{
@@ -158,7 +158,7 @@ public static BaseDimensions BaseDimensions
158158
/// <summary>
159159
/// All units of measurement for the AmplitudeRatio quantity.
160160
/// </summary>
161-
public static AmplitudeRatioUnit[] Units { get; } = Enum.GetValues(typeof(AmplitudeRatioUnit)).Cast<AmplitudeRatioUnit>().ToArray();
161+
public static AmplitudeRatioUnit[] Units { get; } = Enum.GetValues(typeof(AmplitudeRatioUnit)).Cast<AmplitudeRatioUnit>().Except(new AmplitudeRatioUnit[]{ AmplitudeRatioUnit.Undefined }).ToArray();
162162

163163
/// <summary>
164164
/// Get AmplitudeRatio in DecibelMicrovolts.

Common/GeneratedCode/Quantities/Angle.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public Angle(double degrees)
100100
#if WINDOWS_UWP
101101
private
102102
#else
103-
public
103+
public
104104
#endif
105105
Angle(double numericValue, AngleUnit unit)
106106
{
@@ -158,7 +158,7 @@ public static BaseDimensions BaseDimensions
158158
/// <summary>
159159
/// All units of measurement for the Angle quantity.
160160
/// </summary>
161-
public static AngleUnit[] Units { get; } = Enum.GetValues(typeof(AngleUnit)).Cast<AngleUnit>().ToArray();
161+
public static AngleUnit[] Units { get; } = Enum.GetValues(typeof(AngleUnit)).Cast<AngleUnit>().Except(new AngleUnit[]{ AngleUnit.Undefined }).ToArray();
162162

163163
/// <summary>
164164
/// Get Angle in Arcminutes.

Common/GeneratedCode/Quantities/ApparentEnergy.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public ApparentEnergy(double voltamperehours)
101101
#if WINDOWS_UWP
102102
private
103103
#else
104-
public
104+
public
105105
#endif
106106
ApparentEnergy(double numericValue, ApparentEnergyUnit unit)
107107
{
@@ -159,7 +159,7 @@ public static BaseDimensions BaseDimensions
159159
/// <summary>
160160
/// All units of measurement for the ApparentEnergy quantity.
161161
/// </summary>
162-
public static ApparentEnergyUnit[] Units { get; } = Enum.GetValues(typeof(ApparentEnergyUnit)).Cast<ApparentEnergyUnit>().ToArray();
162+
public static ApparentEnergyUnit[] Units { get; } = Enum.GetValues(typeof(ApparentEnergyUnit)).Cast<ApparentEnergyUnit>().Except(new ApparentEnergyUnit[]{ ApparentEnergyUnit.Undefined }).ToArray();
163163

164164
/// <summary>
165165
/// Get ApparentEnergy in KilovoltampereHours.

Common/GeneratedCode/Quantities/ApparentPower.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public ApparentPower(double voltamperes)
101101
#if WINDOWS_UWP
102102
private
103103
#else
104-
public
104+
public
105105
#endif
106106
ApparentPower(double numericValue, ApparentPowerUnit unit)
107107
{
@@ -159,7 +159,7 @@ public static BaseDimensions BaseDimensions
159159
/// <summary>
160160
/// All units of measurement for the ApparentPower quantity.
161161
/// </summary>
162-
public static ApparentPowerUnit[] Units { get; } = Enum.GetValues(typeof(ApparentPowerUnit)).Cast<ApparentPowerUnit>().ToArray();
162+
public static ApparentPowerUnit[] Units { get; } = Enum.GetValues(typeof(ApparentPowerUnit)).Cast<ApparentPowerUnit>().Except(new ApparentPowerUnit[]{ ApparentPowerUnit.Undefined }).ToArray();
163163

164164
/// <summary>
165165
/// Get ApparentPower in Gigavoltamperes.

Common/GeneratedCode/Quantities/Area.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public Area(double squaremeters)
101101
#if WINDOWS_UWP
102102
private
103103
#else
104-
public
104+
public
105105
#endif
106106
Area(double numericValue, AreaUnit unit)
107107
{
@@ -159,7 +159,7 @@ public static BaseDimensions BaseDimensions
159159
/// <summary>
160160
/// All units of measurement for the Area quantity.
161161
/// </summary>
162-
public static AreaUnit[] Units { get; } = Enum.GetValues(typeof(AreaUnit)).Cast<AreaUnit>().ToArray();
162+
public static AreaUnit[] Units { get; } = Enum.GetValues(typeof(AreaUnit)).Cast<AreaUnit>().Except(new AreaUnit[]{ AreaUnit.Undefined }).ToArray();
163163

164164
/// <summary>
165165
/// Get Area in Acres.

Common/GeneratedCode/Quantities/AreaDensity.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public AreaDensity(double kilogramspersquaremeter)
101101
#if WINDOWS_UWP
102102
private
103103
#else
104-
public
104+
public
105105
#endif
106106
AreaDensity(double numericValue, AreaDensityUnit unit)
107107
{
@@ -159,7 +159,7 @@ public static BaseDimensions BaseDimensions
159159
/// <summary>
160160
/// All units of measurement for the AreaDensity quantity.
161161
/// </summary>
162-
public static AreaDensityUnit[] Units { get; } = Enum.GetValues(typeof(AreaDensityUnit)).Cast<AreaDensityUnit>().ToArray();
162+
public static AreaDensityUnit[] Units { get; } = Enum.GetValues(typeof(AreaDensityUnit)).Cast<AreaDensityUnit>().Except(new AreaDensityUnit[]{ AreaDensityUnit.Undefined }).ToArray();
163163

164164
/// <summary>
165165
/// Get AreaDensity in KilogramsPerSquareMeter.

Common/GeneratedCode/Quantities/AreaMomentOfInertia.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public AreaMomentOfInertia(double meterstothefourth)
101101
#if WINDOWS_UWP
102102
private
103103
#else
104-
public
104+
public
105105
#endif
106106
AreaMomentOfInertia(double numericValue, AreaMomentOfInertiaUnit unit)
107107
{
@@ -159,7 +159,7 @@ public static BaseDimensions BaseDimensions
159159
/// <summary>
160160
/// All units of measurement for the AreaMomentOfInertia quantity.
161161
/// </summary>
162-
public static AreaMomentOfInertiaUnit[] Units { get; } = Enum.GetValues(typeof(AreaMomentOfInertiaUnit)).Cast<AreaMomentOfInertiaUnit>().ToArray();
162+
public static AreaMomentOfInertiaUnit[] Units { get; } = Enum.GetValues(typeof(AreaMomentOfInertiaUnit)).Cast<AreaMomentOfInertiaUnit>().Except(new AreaMomentOfInertiaUnit[]{ AreaMomentOfInertiaUnit.Undefined }).ToArray();
163163

164164
/// <summary>
165165
/// Get AreaMomentOfInertia in CentimetersToTheFourth.

Common/GeneratedCode/Quantities/BitRate.Common.g.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public BitRate(double bitspersecond)
100100
#if WINDOWS_UWP
101101
private
102102
#else
103-
public
103+
public
104104
#endif
105105
BitRate(decimal numericValue, BitRateUnit unit)
106106
{
@@ -158,7 +158,7 @@ public static BaseDimensions BaseDimensions
158158
/// <summary>
159159
/// All units of measurement for the BitRate quantity.
160160
/// </summary>
161-
public static BitRateUnit[] Units { get; } = Enum.GetValues(typeof(BitRateUnit)).Cast<BitRateUnit>().ToArray();
161+
public static BitRateUnit[] Units { get; } = Enum.GetValues(typeof(BitRateUnit)).Cast<BitRateUnit>().Except(new BitRateUnit[]{ BitRateUnit.Undefined }).ToArray();
162162

163163
/// <summary>
164164
/// Get BitRate in BitsPerSecond.

0 commit comments

Comments
 (0)