Code review response v3

Author: TrevorVonSeggern

UnitsNet.Tests/UnitConverterTest.cs

@@ -37,13 +37,13 @@ public void ConvertByName_ConvertsTheValueToGivenUnit(double expectedValue, doub
         }
 
         [Fact]
-        public void ConvertByName__QuantityCaseInsensitive()
+        public void ConvertByName_QuantityCaseInsensitive()
         {
             Assert.Equal(0, UnitConverter.ConvertByName(0, "length", "Meter", "Centimeter"));
         }
 
         [Fact]
-        public void ConvertByName__UnitTypeCaseInsensitive()
+        public void ConvertByName_UnitTypeCaseInsensitive()
         {
             Assert.Equal(0, UnitConverter.ConvertByName(0, "Length", "meter", "Centimeter"));
         }

UnitsNet/CustomCode/UnitValueAbbreviationLookup.cs

@@ -63,22 +63,21 @@ internal List<string> GetAbbreviationsForUnit(int unit)
 
         internal List<int> GetUnitsForAbbreviation(string abbreviation)
         {
-            abbreviation = abbreviation.ToLower();
-            if(!abbreviationToUnitMap.TryGetValue(abbreviation, out var units))
-                abbreviationToUnitMap[abbreviation] = units = new List<int>();
+            var lowerCaseAbbreviation = abbreviation.ToLower();
+            if(!abbreviationToUnitMap.TryGetValue(lowerCaseAbbreviation, out var units))
+                abbreviationToUnitMap[lowerCaseAbbreviation] = units = new List<int>();
 
             return units.Distinct().ToList();
         }
 
         internal void Add(int unit, string abbreviation, bool setAsDefault = false)
         {
-            // abbreviation = abbreviation.ToLower();
-            var lower = abbreviation.ToLower();
+            var lowerCaseAbbreviation = abbreviation.ToLower();
             if(!unitToAbbreviationMap.TryGetValue(unit, out var abbreviationsForUnit))
                 abbreviationsForUnit = unitToAbbreviationMap[unit] = new List<string>();
 
-            if(!abbreviationToUnitMap.TryGetValue(lower, out var unitsForAbbreviation))
-                abbreviationToUnitMap[lower] = unitsForAbbreviation = new List<int>();
+            if(!abbreviationToUnitMap.TryGetValue(lowerCaseAbbreviation, out var unitsForAbbreviation))
+                abbreviationToUnitMap[lowerCaseAbbreviation] = unitsForAbbreviation = new List<int>();
 
             abbreviationsForUnit.Remove(abbreviation);
             unitsForAbbreviation.Remove(unit);

UnitsNet/UnitConverter.cs

@@ -407,9 +407,9 @@ private static bool TryParseUnit(Type unitType, string unitName, out object unit
 
         private static bool TryGetUnitType(string quantityName, out Type unitType)
         {
-            quantityName += "Unit";
+            var quantityTypeName = quantityName += "Unit"; // ex. LengthUnit
             unitType = UnitTypes.FirstOrDefault(x => 
-                x.Name.Equals(quantityName, StringComparison.OrdinalIgnoreCase));
+                x.Name.Equals(quantityTypeName, StringComparison.OrdinalIgnoreCase));
 
             if(unitType == null)
                 return false;