Added some nullability annotations to v4 (#1323)

In my project I treat warnings as errors, and when using the source
generator from `System.Text.Json` for a type that has `UnitsNet`
properties, it was generating code that had nullability warnings on
`BaseDimensions` and `BaseUnits` for `operator ==`.

Since there's no good way to suppress this warning only for source
generated code, the only way to fix this, short of disabling the
warnings-as-errors across my whole project, is to add these annotations.

Co-authored-by: Andreas Gullberg Larsen <[email protected]>

Author: ptasev

CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs

@@ -799,7 +799,7 @@ private void GenerateEqualityAndComparison()
         }}
 
         /// <inheritdoc />
-        public int CompareTo(object obj)
+        public int CompareTo(object? obj)
         {{
             if (obj is null) throw new ArgumentNullException(nameof(obj));
             if (!(obj is {_quantity.Name} obj{_quantity.Name})) throw new ArgumentException(""Expected type {_quantity.Name}."", nameof(obj));
@@ -815,7 +815,7 @@ public int CompareTo({_quantity.Name} other)
 
         /// <inheritdoc />
         /// <remarks>Consider using <see cref=""Equals({_quantity.Name}, double, ComparisonType)""/> for safely comparing floating point values.</remarks>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {{
             if (obj is null || !(obj is {_quantity.Name} obj{_quantity.Name}))
                 return false;
@@ -1128,7 +1128,7 @@ public string ToString(IFormatProvider? provider, [NotNull] string format, [NotN
         /// </summary>
         /// <param name=""format"">The format string.</param>
         /// <returns>The string representation.</returns>
-        public string ToString(string format)
+        public string ToString(string? format)
         {{
             return ToString(format, CultureInfo.CurrentUICulture);
         }}
@@ -1140,7 +1140,7 @@ public string ToString(string format)
         /// <param name=""format"">The format string.</param>
         /// <param name=""provider"">Format to use for localization and number formatting. Defaults to <see cref=""CultureInfo.CurrentUICulture"" /> if null.</param>
         /// <returns>The string representation.</returns>
-        public string ToString(string format, IFormatProvider? provider)
+        public string ToString(string? format, IFormatProvider? provider)
         {{
             return QuantityFormatter.Format<{_unitEnumName}>(this, format, provider);
         }}
@@ -1159,67 +1159,67 @@ TypeCode IConvertible.GetTypeCode()
             return TypeCode.Object;
         }}
 
-        bool IConvertible.ToBoolean(IFormatProvider provider)
+        bool IConvertible.ToBoolean(IFormatProvider? provider)
         {{
             throw new InvalidCastException($""Converting {{typeof({_quantity.Name})}} to bool is not supported."");
         }}
 
-        byte IConvertible.ToByte(IFormatProvider provider)
+        byte IConvertible.ToByte(IFormatProvider? provider)
         {{
             return Convert.ToByte(_value);
         }}
 
-        char IConvertible.ToChar(IFormatProvider provider)
+        char IConvertible.ToChar(IFormatProvider? provider)
         {{
             throw new InvalidCastException($""Converting {{typeof({_quantity.Name})}} to char is not supported."");
         }}
 
-        DateTime IConvertible.ToDateTime(IFormatProvider provider)
+        DateTime IConvertible.ToDateTime(IFormatProvider? provider)
         {{
             throw new InvalidCastException($""Converting {{typeof({_quantity.Name})}} to DateTime is not supported."");
         }}
 
-        decimal IConvertible.ToDecimal(IFormatProvider provider)
+        decimal IConvertible.ToDecimal(IFormatProvider? provider)
         {{
             return Convert.ToDecimal(_value);
         }}
 
-        double IConvertible.ToDouble(IFormatProvider provider)
+        double IConvertible.ToDouble(IFormatProvider? provider)
         {{
             return Convert.ToDouble(_value);
         }}
 
-        short IConvertible.ToInt16(IFormatProvider provider)
+        short IConvertible.ToInt16(IFormatProvider? provider)
         {{
             return Convert.ToInt16(_value);
         }}
 
-        int IConvertible.ToInt32(IFormatProvider provider)
+        int IConvertible.ToInt32(IFormatProvider? provider)
         {{
             return Convert.ToInt32(_value);
         }}
 
-        long IConvertible.ToInt64(IFormatProvider provider)
+        long IConvertible.ToInt64(IFormatProvider? provider)
         {{
             return Convert.ToInt64(_value);
         }}
 
-        sbyte IConvertible.ToSByte(IFormatProvider provider)
+        sbyte IConvertible.ToSByte(IFormatProvider? provider)
         {{
             return Convert.ToSByte(_value);
         }}
 
-        float IConvertible.ToSingle(IFormatProvider provider)
+        float IConvertible.ToSingle(IFormatProvider? provider)
         {{
             return Convert.ToSingle(_value);
         }}
 
-        string IConvertible.ToString(IFormatProvider provider)
+        string IConvertible.ToString(IFormatProvider? provider)
         {{
             return ToString(""g"", provider);
         }}
 
-        object IConvertible.ToType(Type conversionType, IFormatProvider provider)
+        object IConvertible.ToType(Type conversionType, IFormatProvider? provider)
         {{
             if (conversionType == typeof({_quantity.Name}))
                 return this;
@@ -1235,17 +1235,17 @@ object IConvertible.ToType(Type conversionType, IFormatProvider provider)
                 throw new InvalidCastException($""Converting {{typeof({_quantity.Name})}} to {{conversionType}} is not supported."");
         }}
 
-        ushort IConvertible.ToUInt16(IFormatProvider provider)
+        ushort IConvertible.ToUInt16(IFormatProvider? provider)
         {{
             return Convert.ToUInt16(_value);
         }}
 
-        uint IConvertible.ToUInt32(IFormatProvider provider)
+        uint IConvertible.ToUInt32(IFormatProvider? provider)
         {{
             return Convert.ToUInt32(_value);
         }}
 
-        ulong IConvertible.ToUInt64(IFormatProvider provider)
+        ulong IConvertible.ToUInt64(IFormatProvider? provider)
         {{
             return Convert.ToUInt64(_value);
         }}

CodeGen/Generators/UnitsNetWrcGen/QuantityGenerator.cs

@@ -531,7 +531,7 @@ private void GenerateEqualityAndComparison()
             Writer.WL($@"
         #region Equality / IComparable
 
-        public int CompareTo(object obj)
+        public int CompareTo(object? obj)
         {{
             if (obj is null) throw new ArgumentNullException(nameof(obj));
             if (!(obj is {_quantity.Name} obj{_quantity.Name})) throw new ArgumentException(""Expected type {_quantity.Name}."", nameof(obj));
@@ -546,7 +546,7 @@ internal int CompareTo({_quantity.Name} other)
         }}
 
         [Windows.Foundation.Metadata.DefaultOverload]
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {{
             if (obj is null || !(obj is {_quantity.Name} obj{_quantity.Name}))
                 return false;