Code reviewed, added copyright headers and some more * overloading

Author: Erik Ovegard

UnitsNet.Serialization.JsonNet.Tests/UnitsNet.Serialization.JsonNet.Tests.csproj

@@ -67,9 +67,6 @@
       <Name>UnitsNet.Net35</Name>
     </ProjectReference>
   </ItemGroup>
-  <ItemGroup>
-    <Service Include="{82A7F48D-3B50-4B1E-B82E-3ADA8210C358}" />
-  </ItemGroup>
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it. 
        Other similar extension points exist, see Microsoft.Common.targets.

UnitsNet.Tests/CustomCode/LengthTests.cs

@@ -34,13 +34,13 @@ public void LengthTimesLengthEqualsArea()
         }
 
         [Test]
-        public void AreaTimesLengthEqualsArea()
+        public void AreaTimesLengthEqualsVolume()
         {
             var volume = Area.FromSquareMeters(10) * Length.FromMeters(3);
             Assert.AreEqual(volume, Volume.FromCubicMeters(30));
         }
         [Test]
-        public void LengthTimesAreaEqualsArea()
+        public void LengthTimesAreaEqualsVolume()
         {
             var volume = Length.FromMeters(3) * Area.FromSquareMeters(9);
             Assert.AreEqual(volume, Volume.FromCubicMeters(27));
@@ -49,8 +49,15 @@ public void LengthTimesAreaEqualsArea()
         [Test]
         public void ForceTimesLengthEqualsTorque()
         {
-            var volume = Length.FromMeters(3) * Area.FromSquareMeters(9);
-            Assert.AreEqual(volume, Volume.FromCubicMeters(27));
+            var torque = Force.FromNewtons(1) * Length.FromMeters(3);
+            Assert.AreEqual(torque, Torque.FromNewtonMeters(3));
+        }
+
+        [Test]
+        public void LengthTimesForceEqualsTorque()
+        {
+            var torque = Length.FromMeters(3) * Force.FromNewtons(1);
+            Assert.AreEqual(torque, Torque.FromNewtonMeters(3));
         }
 
         protected override double CentimetersInOneMeter

UnitsNet.Tests/CustomCode/MassTests.cs

@@ -38,12 +38,21 @@ public void MassDividedByVolumeEqualsDensity()
             var density = Mass.FromKilograms(18) / Volume.FromCubicMeters(3);
             Assert.AreEqual(density, Density.FromKilogramsPerCubicMeter(6));
         }
+
         [Test]
         public void MassTimesAccelerationEqualsForce()
         {
             var force = Mass.FromKilograms(18) * Acceleration.FromMeterPerSecondSquared(3);
             Assert.AreEqual(force, Force.FromNewtons(54));
         }
+
+        [Test]
+        public void AccelerationTimesMassEqualsForce()
+        {
+            var force = Acceleration.FromMeterPerSecondSquared(3) * Mass.FromKilograms(18);
+            Assert.AreEqual(force, Force.FromNewtons(54));
+        }
+
         protected override double CentigramsInOneKilogram
         {
             get { return 1E5; }

UnitsNet.Tests/CustomCode/PressureTests.cs

@@ -24,15 +24,19 @@ namespace UnitsNet.Tests.CustomCode
 {
     public class PressureTests : PressureTestsBase
     {
-
-
         [Test]
         public void PressureTimesAreaEqualsForce()
         {
             var force = Pressure.FromPascals(20) * Area.FromSquareMeters(3);
             Assert.AreEqual(force, Force.FromNewtons(60));
         }
 
+        [Test]
+        public void AreaTimePressureEqualsForce()
+        {
+            var force = Area.FromSquareMeters(3) * Pressure.FromPascals(20);
+            Assert.AreEqual(force, Force.FromNewtons(60));
+        }
 
         protected override double AtmospheresInOnePascal
         {

UnitsNet.Tests/CustomCode/RotationalSpeedTests.cs

@@ -30,10 +30,31 @@ public class RotationalSpeedTests : RotationalSpeedTestsBase
         [Test]
         public void RotationalSpeedTimesTimeSpanEqualsAngle()
         {
-            var angle = RotationalSpeed.FromRadiansPerSecond(10.0)*TimeSpan.FromSeconds(9.0);
+            var angle = RotationalSpeed.FromRadiansPerSecond(10.0) * TimeSpan.FromSeconds(9.0);
             Assert.AreEqual(angle, Angle.FromRadians(90.0));
         }
 
+        [Test]
+        public void TimeSpanTimesRotationalSpeedEqualsAngle()
+        {
+            var angle = TimeSpan.FromSeconds(9.0) * RotationalSpeed.FromRadiansPerSecond(10.0) ;
+            Assert.AreEqual(angle, Angle.FromRadians(90.0));
+        }
+
+        [Test]
+        public void RotationalSpeedTimesForceEqualsPower()
+        {
+            var power = RotationalSpeed.FromRadiansPerSecond(10.0) * Force.FromNewtons(2.0);
+            Assert.AreEqual(power, Power.FromWatts(20.0));
+        }
+
+        [Test]
+        public void ForceTimesRotationalSpeedEqualsPower()
+        {
+            var power = Force.FromNewtons(2.0) * RotationalSpeed.FromRadiansPerSecond(10.0) ;
+            Assert.AreEqual(power, Power.FromWatts(20.0));
+        }
+
         protected override double RadiansPerSecondInOneRevolutionPerSecond
         {
             get

UnitsNet.Tests/CustomCode/SpeedTests.cs

@@ -20,28 +20,39 @@
 // THE SOFTWARE.
 
 using System;
-
 using NUnit.Framework;
-using System;
 
 namespace UnitsNet.Tests.CustomCode
 {
     public class SpeedTests : SpeedTestsBase
     {
-
         [Test]
         public void SpeedDevidedByTimespanEqualsAcceleration()
         {
             var acceleration = Speed.FromMetersPerSecond(20) / TimeSpan.FromSeconds(2);
             Assert.AreEqual(acceleration, Acceleration.FromMeterPerSecondSquared(10));
         }
+
         [Test]
-        public void SpeedTimesTimespanEqualsLength()
+        public void SpeedTimesTimeSpanEqualsLength()
         {
             var length= Speed.FromMetersPerSecond(20) * TimeSpan.FromSeconds(2);
             Assert.AreEqual(length, Length.FromMeters(40));
         }
 
+        [Test]
+        public void TimeSpanSpeedTimesEqualsLength()
+        {
+            var length = TimeSpan.FromSeconds(2) * Speed.FromMetersPerSecond(20);
+            Assert.AreEqual(length, Length.FromMeters(40));
+        }
+
+        [Test]
+        public void LengthDividedByTimeSpanEqualsSpeed()
+        {
+            var speed = Length.FromMeters(20) / TimeSpan.FromSeconds(2);
+            Assert.AreEqual(speed, Speed.FromMetersPerSecond(10));
+        }
 
         protected override double FeetPerSecondInOneMeterPerSecond
         {

UnitsNet.Tests/CustomCode/VolumeTests.cs

@@ -31,12 +31,14 @@ public void VolumeDividedByLengthEqualsArea()
             var area = Volume.FromCubicMeters(15) / Length.FromMeters(5);
             Assert.AreEqual(area, Area.FromSquareMeters(3));
         }
+
         [Test]
         public void VolumeDividedByAreaEqualsLength()
         {
             var length= Volume.FromCubicMeters(15) / Area.FromSquareMeters(5);
             Assert.AreEqual(length, Length.FromMeters(3));
         }
+
         [Test]
         public void VolumeTimesDensityEqualsMass()
         {

UnitsNet/CustomCode/UnitClasses/Angle.extra.cs

@@ -1,4 +1,25 @@
-using System;
+// Copyright © 2007 by Initial Force AS.  All rights reserved.
+// https://github.com/InitialForce/UnitsNet
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+
+using System;
 
 namespace UnitsNet
 {

UnitsNet/CustomCode/UnitClasses/Area.extra.cs

@@ -1,10 +1,23 @@
-using System;
-using System.Collections.Generic;
-using System.Globalization;
-using System.Linq;
-using System.Text;
-using UnitsNet.Units;
-
+// Copyright © 2007 by Initial Force AS.  All rights reserved.
+// https://github.com/InitialForce/UnitsNet
+//
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
 
 namespace UnitsNet
 {

UnitsNet/CustomCode/UnitClasses/Force.extra.cs

@@ -18,7 +18,6 @@
 // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 // THE SOFTWARE.
-using UnitsNet.Units;
 
 namespace UnitsNet
 {
@@ -40,8 +39,7 @@ public partial struct Force
         {
             return Pressure.FromPascals(force.Newtons / area.SquareMeters);
         }
-
-
+        
         public static Force FromPressureByArea(Pressure p, Length2d area)
         {
             double metersSquared = area.Meters.X*area.Meters.Y;