✨Set IsAotCompatible for net7.0 or later (#1543)

Fixes IL warnings when building with AOT.

- Add `EnumHelper.GetValues<>` to simplify enumerating enum values for
netstandard and net7+, AOT compatible
- Replace reflection in `UnitConverter.RegisterDefaultConversions()`
with generated code in
`Quantity.DefaultProvider.RegisterUnitConversions()`
- Add attributes to warn about incompatibilities to Native AOT
compilation for `UnitsNet.Serialization.JsonNet`, requires more changes

I tried to make minimal changes only, but possibly breaking changes are
- the addition of a `struct` constraint to generic enum-constrained
methods

---------

Co-authored-by: Andreas Gullberg Larsen <[email protected]>

Author: OleRoss

CodeGen/Generators/UnitsNetGen/StaticQuantityGenerator.cs

@@ -40,6 +40,17 @@ internal static class DefaultProvider
             {quantity.Name}.Info,");
             Writer.WL(@"
         ];
+
+        internal static void RegisterUnitConversions(UnitConverter unitConverter)
+        {");
+            foreach (Quantity quantity in _quantities)
+            {
+                Writer.WL($@"
+            {quantity.Name}.RegisterDefaultConversions(unitConverter);");
+            }
+
+            Writer.WL(@"
+        }
     }
 }");
             return Writer.ToString();

PerfTests/PerfTest_Startup_Aot/PerfTest_Startup_Aot.csproj

@@ -0,0 +1,17 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+    <PropertyGroup>
+        <OutputType>Exe</OutputType>
+        <TargetFramework>net9.0</TargetFramework>
+        <ImplicitUsings>enable</ImplicitUsings>
+        <Nullable>enable</Nullable>
+        <RootNamespace>perftest</RootNamespace>
+
+        <PublishAot>true</PublishAot>
+    </PropertyGroup>
+
+    <ItemGroup>
+      <ProjectReference Include="..\..\UnitsNet\UnitsNet.csproj" />
+    </ItemGroup>
+
+</Project>

PerfTests/PerfTest_Startup_Aot/Program.cs

@@ -0,0 +1,4 @@
+using UnitsNet;
+using UnitsNet.Units;
+
+Console.WriteLine(Power.From(5, PowerUnit.Watt));

PerfTests/PerfTest_Startup_Aot/profile.sh

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+# shellcheck disable=SC2155
+declare -r dirname=$(dirname -- "$0")
+
+pushd "$dirname" || exit
+dotnet publish
+dotnet timeit "$dirname/timeit.json"
+popd || exit

PerfTests/PerfTest_Startup_Aot/timeit.json

@@ -0,0 +1,8 @@
+{
+  "warmUpCount": 10,
+  "count": 20,
+  "scenarios": [{ "name": "Default" }],
+  "processName": "../../Artifacts/PerfTest_Startup_Aot/net9.0/win-x64/publish/PerfTest_Startup_Aot.exe",
+  "workingDirectory": "$(CWD)/",
+  "processTimeout": 15
+}

UnitsNet.NumberExtensions/UnitsNet.NumberExtensions.csproj

@@ -27,6 +27,7 @@
     <Nullable>enable</Nullable>
     <RootNamespace>UnitsNet</RootNamespace>
     <TargetFrameworks>netstandard2.0;net8.0;net9.0</TargetFrameworks>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
   </PropertyGroup>
 
   <ItemGroup>

UnitsNet.Serialization.JsonNet/UnitsNet.Serialization.JsonNet.csproj

@@ -28,6 +28,7 @@
     <Nullable>enable</Nullable>
     <RootNamespace>UnitsNet.Serialization.JsonNet</RootNamespace>
     <TargetFrameworks>netstandard2.0;net8.0;net9.0</TargetFrameworks>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
   </PropertyGroup>
 
   <!-- Strong name signing -->

UnitsNet.Serialization.JsonNet/UnitsNetBaseJsonConverter.cs

@@ -3,7 +3,7 @@
 
 using System;
 using System.Collections.Concurrent;
-using System.Globalization;
+using System.Diagnostics.CodeAnalysis;
 using System.Linq;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
@@ -15,6 +15,10 @@ namespace UnitsNet.Serialization.JsonNet
     /// Contains shared functionality used by <see cref="UnitsNetIQuantityJsonConverter"/> and <see cref="UnitsNetIComparableJsonConverter"/>
     /// </summary>
     /// <typeparam name="T">The type being converted. Should either be <see cref="IQuantity"/> or <see cref="IComparable"/></typeparam>
+#if NET
+    [RequiresDynamicCode("The native code for this instantiation might not be available at runtime.")]
+    [RequiresUnreferencedCode("If some of the generic arguments are annotated (either with DynamicallyAccessedMembersAttribute, or generic constraints), trimming can't validate that the requirements of those annotations are met.")]
+#endif
     public abstract class UnitsNetBaseJsonConverter<T> : NullableQuantityConverter<T>
     {
         private readonly ConcurrentDictionary<string, (Type Quantity, Type Unit)> _registeredTypes = new();

UnitsNet.Serialization.JsonNet/UnitsNetIComparableJsonConverter.cs

@@ -2,6 +2,7 @@
 // Copyright 2013 Andreas Gullberg Larsen ([email protected]). Maintained at https://github.com/angularsen/UnitsNet.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
@@ -15,6 +16,10 @@ namespace UnitsNet.Serialization.JsonNet
     /// Should only be used when UnitsNet types are assigned to properties of type IComparable.
     /// Requires TypeNameHandling on <see cref="JsonSerializerSettings"/> to be set to something other than <see cref="TypeNameHandling.None"/> so that it outputs $type when serializing.
     /// </summary>
+#if NET
+    [RequiresDynamicCode("The native code for this instantiation might not be available at runtime.")]
+    [RequiresUnreferencedCode("If some of the generic arguments are annotated (either with DynamicallyAccessedMembersAttribute, or generic constraints), trimming can't validate that the requirements of those annotations are met.")]
+#endif
     public sealed class UnitsNetIComparableJsonConverter : UnitsNetBaseJsonConverter<IComparable?>
     {
         /// <summary>

UnitsNet.Serialization.JsonNet/UnitsNetIQuantityJsonConverter.cs

@@ -2,6 +2,7 @@
 // Copyright 2013 Andreas Gullberg Larsen ([email protected]). Maintained at https://github.com/angularsen/UnitsNet.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 
@@ -12,6 +13,10 @@ namespace UnitsNet.Serialization.JsonNet
     /// JSON.net converter for IQuantity types (e.g. all units in UnitsNet)
     /// Use this converter to serialize and deserialize UnitsNet types to and from JSON
     /// </summary>
+#if NET
+    [RequiresDynamicCode("The native code for this instantiation might not be available at runtime.")]
+    [RequiresUnreferencedCode("If some of the generic arguments are annotated (either with DynamicallyAccessedMembersAttribute, or generic constraints), trimming can't validate that the requirements of those annotations are met.")]
+#endif
     public sealed class UnitsNetIQuantityJsonConverter : UnitsNetBaseJsonConverter<IQuantity?>
     {
         /// <summary>