Remove TryConvert(), rename Convert() to As()

These were originally copied from UnitConverter class. Does not make sense to TryConvert now that the big unit enum was divided into a separate enum for each unit class. Convert() also did not make much sense, as you don't really convert Length to meters, but rather get that length in a meter representation.

* Update tests

Author: angularsen

Src/UnitsNet/GeneratedCode/Angle.g.cs

@@ -234,48 +234,29 @@ public override int GetHashCode()
         #endregion
 
         #region Conversion
- 
+
         /// <summary>
-        /// Try to dynamically convert from Angle to <paramref name="toUnit"/>.
+        /// Convert to the unit representation in <paramref name="asUnit"/>.
         /// </summary>
         /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <param name="newValue">Value in new unit if successful, zero otherwise.</param>
-        /// <returns>True if the two units were compatible and the conversion was successful.</returns> 
-        public bool TryConvert(AngleUnit toUnit, out double newValue)
+        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
+        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
+        public double As(AngleUnit unit)
         {
-            switch (toUnit)
+            switch (unit)
             {
                 case AngleUnit.Degree:
-                    newValue = Degrees;
-                    return true;
+                    return Degrees;
                 case AngleUnit.Gradian:
-                    newValue = Gradians;
-                    return true;
+                    return Gradians;
                 case AngleUnit.Radian:
-                    newValue = Radians;
-                    return true;
+                    return Radians;
 
                 default:
-                    newValue = 0;
-                    return false;
+                    throw new NotImplementedException("unit: " + unit);
             }
         }
 
-        /// <summary>
-        /// Dynamically convert from Angle to <paramref name="toUnit"/>.
-        /// </summary>
-        /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
-        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
-        public double Convert(AngleUnit toUnit)
-        {
-            double newValue;
-            if (!TryConvert(toUnit, out newValue))
-                throw new NotImplementedException("toUnit: " + toUnit);
-
-            return newValue;
-        }
-
         #endregion
 
         /// <summary>
@@ -300,7 +281,7 @@ public string ToString(AngleUnit unit, CultureInfo culture = null)
         public string ToString(AngleUnit unit, CultureInfo culture, string format, params object[] args)
         {
             string abbreviation = UnitSystem.GetCached(culture).GetDefaultAbbreviation(unit);
-            var finalArgs = new object[] {Convert(unit), abbreviation}
+            var finalArgs = new object[] {As(unit), abbreviation}
                 .Concat(args)
                 .ToArray();
 

Src/UnitsNet/GeneratedCode/Area.g.cs

@@ -354,66 +354,41 @@ public override int GetHashCode()
         #endregion
 
         #region Conversion
- 
+
         /// <summary>
-        /// Try to dynamically convert from Area to <paramref name="toUnit"/>.
+        /// Convert to the unit representation in <paramref name="asUnit"/>.
         /// </summary>
         /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <param name="newValue">Value in new unit if successful, zero otherwise.</param>
-        /// <returns>True if the two units were compatible and the conversion was successful.</returns> 
-        public bool TryConvert(AreaUnit toUnit, out double newValue)
+        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
+        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
+        public double As(AreaUnit unit)
         {
-            switch (toUnit)
+            switch (unit)
             {
                 case AreaUnit.SquareCentimeter:
-                    newValue = SquareCentimeters;
-                    return true;
+                    return SquareCentimeters;
                 case AreaUnit.SquareDecimeter:
-                    newValue = SquareDecimeters;
-                    return true;
+                    return SquareDecimeters;
                 case AreaUnit.SquareFoot:
-                    newValue = SquareFeet;
-                    return true;
+                    return SquareFeet;
                 case AreaUnit.SquareInch:
-                    newValue = SquareInches;
-                    return true;
+                    return SquareInches;
                 case AreaUnit.SquareKilometer:
-                    newValue = SquareKilometers;
-                    return true;
+                    return SquareKilometers;
                 case AreaUnit.SquareMeter:
-                    newValue = SquareMeters;
-                    return true;
+                    return SquareMeters;
                 case AreaUnit.SquareMile:
-                    newValue = SquareMiles;
-                    return true;
+                    return SquareMiles;
                 case AreaUnit.SquareMillimeter:
-                    newValue = SquareMillimeters;
-                    return true;
+                    return SquareMillimeters;
                 case AreaUnit.SquareYard:
-                    newValue = SquareYards;
-                    return true;
+                    return SquareYards;
 
                 default:
-                    newValue = 0;
-                    return false;
+                    throw new NotImplementedException("unit: " + unit);
             }
         }
 
-        /// <summary>
-        /// Dynamically convert from Area to <paramref name="toUnit"/>.
-        /// </summary>
-        /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
-        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
-        public double Convert(AreaUnit toUnit)
-        {
-            double newValue;
-            if (!TryConvert(toUnit, out newValue))
-                throw new NotImplementedException("toUnit: " + toUnit);
-
-            return newValue;
-        }
-
         #endregion
 
         /// <summary>
@@ -438,7 +413,7 @@ public string ToString(AreaUnit unit, CultureInfo culture = null)
         public string ToString(AreaUnit unit, CultureInfo culture, string format, params object[] args)
         {
             string abbreviation = UnitSystem.GetCached(culture).GetDefaultAbbreviation(unit);
-            var finalArgs = new object[] {Convert(unit), abbreviation}
+            var finalArgs = new object[] {As(unit), abbreviation}
                 .Concat(args)
                 .ToArray();
 

Src/UnitsNet/GeneratedCode/Duration.g.cs

@@ -374,69 +374,43 @@ public override int GetHashCode()
         #endregion
 
         #region Conversion
- 
+
         /// <summary>
-        /// Try to dynamically convert from Duration to <paramref name="toUnit"/>.
+        /// Convert to the unit representation in <paramref name="asUnit"/>.
         /// </summary>
         /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <param name="newValue">Value in new unit if successful, zero otherwise.</param>
-        /// <returns>True if the two units were compatible and the conversion was successful.</returns> 
-        public bool TryConvert(DurationUnit toUnit, out double newValue)
+        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
+        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
+        public double As(DurationUnit unit)
         {
-            switch (toUnit)
+            switch (unit)
             {
                 case DurationUnit.Day:
-                    newValue = Days;
-                    return true;
+                    return Days;
                 case DurationUnit.Hour:
-                    newValue = Hours;
-                    return true;
+                    return Hours;
                 case DurationUnit.Microsecond:
-                    newValue = Microseconds;
-                    return true;
+                    return Microseconds;
                 case DurationUnit.Millisecond:
-                    newValue = Milliseconds;
-                    return true;
+                    return Milliseconds;
                 case DurationUnit.Minute:
-                    newValue = Minutes;
-                    return true;
+                    return Minutes;
                 case DurationUnit.Month30Days:
-                    newValue = Month30Dayss;
-                    return true;
+                    return Month30Dayss;
                 case DurationUnit.Nanosecond:
-                    newValue = Nanoseconds;
-                    return true;
+                    return Nanoseconds;
                 case DurationUnit.Second:
-                    newValue = Seconds;
-                    return true;
+                    return Seconds;
                 case DurationUnit.Week:
-                    newValue = Weeks;
-                    return true;
+                    return Weeks;
                 case DurationUnit.Year365Days:
-                    newValue = Year365Dayss;
-                    return true;
+                    return Year365Dayss;
 
                 default:
-                    newValue = 0;
-                    return false;
+                    throw new NotImplementedException("unit: " + unit);
             }
         }
 
-        /// <summary>
-        /// Dynamically convert from Duration to <paramref name="toUnit"/>.
-        /// </summary>
-        /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
-        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
-        public double Convert(DurationUnit toUnit)
-        {
-            double newValue;
-            if (!TryConvert(toUnit, out newValue))
-                throw new NotImplementedException("toUnit: " + toUnit);
-
-            return newValue;
-        }
-
         #endregion
 
         /// <summary>
@@ -461,7 +435,7 @@ public string ToString(DurationUnit unit, CultureInfo culture = null)
         public string ToString(DurationUnit unit, CultureInfo culture, string format, params object[] args)
         {
             string abbreviation = UnitSystem.GetCached(culture).GetDefaultAbbreviation(unit);
-            var finalArgs = new object[] {Convert(unit), abbreviation}
+            var finalArgs = new object[] {As(unit), abbreviation}
                 .Concat(args)
                 .ToArray();
 

Src/UnitsNet/GeneratedCode/ElectricPotential.g.cs

@@ -194,42 +194,25 @@ public override int GetHashCode()
         #endregion
 
         #region Conversion
- 
+
         /// <summary>
-        /// Try to dynamically convert from ElectricPotential to <paramref name="toUnit"/>.
+        /// Convert to the unit representation in <paramref name="asUnit"/>.
         /// </summary>
         /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <param name="newValue">Value in new unit if successful, zero otherwise.</param>
-        /// <returns>True if the two units were compatible and the conversion was successful.</returns> 
-        public bool TryConvert(ElectricPotentialUnit toUnit, out double newValue)
+        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
+        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
+        public double As(ElectricPotentialUnit unit)
         {
-            switch (toUnit)
+            switch (unit)
             {
                 case ElectricPotentialUnit.Volt:
-                    newValue = Volts;
-                    return true;
+                    return Volts;
 
                 default:
-                    newValue = 0;
-                    return false;
+                    throw new NotImplementedException("unit: " + unit);
             }
         }
 
-        /// <summary>
-        /// Dynamically convert from ElectricPotential to <paramref name="toUnit"/>.
-        /// </summary>
-        /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
-        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
-        public double Convert(ElectricPotentialUnit toUnit)
-        {
-            double newValue;
-            if (!TryConvert(toUnit, out newValue))
-                throw new NotImplementedException("toUnit: " + toUnit);
-
-            return newValue;
-        }
-
         #endregion
 
         /// <summary>
@@ -254,7 +237,7 @@ public string ToString(ElectricPotentialUnit unit, CultureInfo culture = null)
         public string ToString(ElectricPotentialUnit unit, CultureInfo culture, string format, params object[] args)
         {
             string abbreviation = UnitSystem.GetCached(culture).GetDefaultAbbreviation(unit);
-            var finalArgs = new object[] {Convert(unit), abbreviation}
+            var finalArgs = new object[] {As(unit), abbreviation}
                 .Concat(args)
                 .ToArray();
 

Src/UnitsNet/GeneratedCode/Flow.g.cs

@@ -214,45 +214,27 @@ public override int GetHashCode()
         #endregion
 
         #region Conversion
- 
+
         /// <summary>
-        /// Try to dynamically convert from Flow to <paramref name="toUnit"/>.
+        /// Convert to the unit representation in <paramref name="asUnit"/>.
         /// </summary>
         /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <param name="newValue">Value in new unit if successful, zero otherwise.</param>
-        /// <returns>True if the two units were compatible and the conversion was successful.</returns> 
-        public bool TryConvert(FlowUnit toUnit, out double newValue)
+        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
+        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
+        public double As(FlowUnit unit)
         {
-            switch (toUnit)
+            switch (unit)
             {
                 case FlowUnit.CubicMeterPerHour:
-                    newValue = CubicMetersPerHour;
-                    return true;
+                    return CubicMetersPerHour;
                 case FlowUnit.CubicMeterPerSecond:
-                    newValue = CubicMetersPerSecond;
-                    return true;
+                    return CubicMetersPerSecond;
 
                 default:
-                    newValue = 0;
-                    return false;
+                    throw new NotImplementedException("unit: " + unit);
             }
         }
 
-        /// <summary>
-        /// Dynamically convert from Flow to <paramref name="toUnit"/>.
-        /// </summary>
-        /// <param name="toUnit">Compatible unit to convert to.</param>
-        /// <returns>Value in new unit if successful, exception otherwise.</returns> 
-        /// <exception cref="NotImplementedException">If conversion was not successful.</exception>
-        public double Convert(FlowUnit toUnit)
-        {
-            double newValue;
-            if (!TryConvert(toUnit, out newValue))
-                throw new NotImplementedException("toUnit: " + toUnit);
-
-            return newValue;
-        }
-
         #endregion
 
         /// <summary>
@@ -277,7 +259,7 @@ public string ToString(FlowUnit unit, CultureInfo culture = null)
         public string ToString(FlowUnit unit, CultureInfo culture, string format, params object[] args)
         {
             string abbreviation = UnitSystem.GetCached(culture).GetDefaultAbbreviation(unit);
-            var finalArgs = new object[] {Convert(unit), abbreviation}
+            var finalArgs = new object[] {As(unit), abbreviation}
                 .Concat(args)
                 .ToArray();