Case comparison - code review response

Author: TrevorVonSeggern

UnitsNet.Tests/UnitParserTests.cs

@@ -42,19 +42,32 @@ public void Parse_ReturnsUnitMappedByCustomAbbreviation(string customAbbreviatio
         }
 
         [Fact]
-        public void Parse_AbbreviationCaseInsensitive()
+        public void Parse_AbbreviationCaseInsensitive_Lowercase_years()
         {
+            // Arrange
             var abbreviation = "years";
             var expected = DurationUnit.Year365;
             var parser = UnitParser.Default;
 
+            // Act
             var actual = parser.Parse<DurationUnit>(abbreviation);
 
+            // Assert
             Assert.Equal(expected, actual);
+        }
 
-            abbreviation = "Years";
-            actual = parser.Parse<DurationUnit>(abbreviation);
+        [Fact]
+        public void Parse_AbbreviationCaseInsensitive_Uppercase_Years()
+        {
+            // Arrange
+            var abbreviation = "Years";
+            var expected = DurationUnit.Year365;
+            var parser = UnitParser.Default;
+
+            // Act
+            var actual = parser.Parse<DurationUnit>(abbreviation);
 
+            // Assert
             Assert.Equal(expected, actual);
         }
 

UnitsNet/CustomCode/UnitValueAbbreviationLookup.cs

@@ -1,4 +1,4 @@
-// Copyright (c) 2013 Andreas Gullberg Larsen ([email protected]).
+// Copyright (c) 2013 Andreas Gullberg Larsen ([email protected]).
 // https://github.com/angularsen/UnitsNet
 //
 // Permission is hereby granted, free of charge, to any person obtaining a copy
@@ -65,7 +65,9 @@ internal List<int> GetUnitsForAbbreviation(string abbreviation)
         {
             return abbreviationToUnitMap
                 .Where(x => x.Key.Equals(abbreviation, StringComparison.OrdinalIgnoreCase))
-                .SelectMany(x => x.Value).Distinct().ToList();
+                .SelectMany(x => x.Value)
+                .Distinct()
+                .ToList();
         }
 
         internal void Add(int unit, string abbreviation, bool setAsDefault = false)

UnitsNet/UnitConverter.cs

@@ -45,6 +45,14 @@ public static class UnitConverter
         private static readonly string UnitTypeNamespace = typeof(LengthUnit).Namespace;
         private static readonly Assembly UnitsNetAssembly = typeof(Length).GetAssembly();
 
+        private static readonly List<Type> QuantityTypes = UnitsNetAssembly.GetTypes()
+            .Where(x => x.FullName.StartsWith(QuantityNamespace))
+            .ToList();
+
+        private static readonly List<Type> UnitTypes = UnitsNetAssembly.GetTypes()
+            .Where(x => x.FullName.StartsWith(UnitTypeNamespace))
+            .ToList();
+
         /// <summary>
         ///     Convert between any two quantity units by their names, such as converting a "Length" of N "Meter" to "Centimeter".
         ///     This is particularly useful for creating things like a generated unit conversion UI,
@@ -387,7 +395,7 @@ private static bool TryParseUnit(Type unitType, string unitName, out object unit
             unitValue = null;
             var eNames = Enum.GetNames(unitType);
             unitName = eNames.FirstOrDefault(x => x.Equals(unitName, StringComparison.OrdinalIgnoreCase));
-            if(unitName is null)
+            if(unitName == null)
                 return false;
 
             unitValue = Enum.Parse(unitType, unitName);
@@ -397,14 +405,10 @@ private static bool TryParseUnit(Type unitType, string unitName, out object unit
             return true;
         }
 
-        private static List<Type> UnitTypes = UnitsNetAssembly.GetTypes()
-            .Where(x => x.FullName.StartsWith(UnitTypeNamespace))
-            .ToList();
-
         private static bool TryGetUnitType(string quantityName, out Type unitType)
         {
             quantityName += "Unit";
-            unitType = QuantityTypes.FirstOrDefault(x => 
+            unitType = UnitTypes.FirstOrDefault(x => 
                 x.Name.Equals(quantityName, StringComparison.OrdinalIgnoreCase));
 
             if(unitType == null)
@@ -413,10 +417,6 @@ private static bool TryGetUnitType(string quantityName, out Type unitType)
             return true;
         }
 
-        private static List<Type> QuantityTypes = UnitsNetAssembly.GetTypes()
-            .Where(x => x.FullName.StartsWith(QuantityNamespace))
-            .ToList();
-
         private static bool TryGetQuantityType(string quantityName, out Type quantityType)
         {
             quantityType = QuantityTypes.FirstOrDefault(x => x.Name.Equals(quantityName, StringComparison.OrdinalIgnoreCase));