Skip to content

Commit 7ff8c81

Browse files
authored
💚⬆️ Fix build hang by upgrading dotcover (#1146)
Hoping to fix hang issue and very slow builds on CI and locally, only seen when running build.bat, which runs tests with JetBrains dotcover. Local testing of upgrade seems to indicate this helps a lot. - Upgrade from 2019.1.3 to 2022.2.3. - Replace nuget refs with tool manifest.
1 parent 6363448 commit 7ff8c81

File tree

5 files changed

+12
-4
lines changed

5 files changed

+12
-4
lines changed

.config/dotnet-tools.json

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"version": 1,
3+
"isRoot": true,
4+
"tools": {
5+
"jetbrains.dotcover.globaltool": {
6+
"version": "2022.2.3",
7+
"commands": [
8+
"dotnet-dotcover"
9+
]
10+
}
11+
}
12+
}

UnitsNet.NumberExtensions.Tests/UnitsNet.NumberExtensions.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3232
</PackageReference>
3333
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
34-
<DotNetCliToolReference Include="JetBrains.dotCover.CommandLineTools" Version="2019.1.3" />
3534
</ItemGroup>
3635

3736
<ItemGroup>

UnitsNet.Serialization.JsonNet.CompatibilityTests/UnitsNet.Serialization.JsonNet.CompatibilityTests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2424
</PackageReference>
2525
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
26-
<DotNetCliToolReference Include="JetBrains.dotCover.CommandLineTools" Version="2019.1.3" />
2726
</ItemGroup>
2827

2928
<ItemGroup>

UnitsNet.Serialization.JsonNet.Tests/UnitsNet.Serialization.JsonNet.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
2222
</PackageReference>
2323
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
24-
<DotNetCliToolReference Include="JetBrains.dotCover.CommandLineTools" Version="2019.1.3" />
2524
</ItemGroup>
2625

2726
<ItemGroup>

UnitsNet.Tests/UnitsNet.Tests.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
3232
</PackageReference>
3333
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
34-
<DotNetCliToolReference Include="JetBrains.dotCover.CommandLineTools" Version="2019.1.3" />
3534
</ItemGroup>
3635

3736
<ItemGroup>

0 commit comments

Comments
 (0)