Changed from PoundPerHorsepowerHour to PoundPerMechanicalHorsepowerHour

Author: Erik Ovegard

UnitsNet.Tests/CustomCode/BrakeSpecificFuelConsumptionTests.cs

@@ -31,7 +31,7 @@ public class BrakeSpecificFuelConsumptionTests : BrakeSpecificFuelConsumptionTes
 
         protected override double KilogramsPerJouleInOneKilogramPerJoule => 1.0;
 
-        protected override double PoundsPerHorsepowerHourInOneKilogramPerJoule => 5918352.5016;
+        protected override double PoundsPerMechanicalHorsepowerHourInOneKilogramPerJoule => 5918352.5016;
 
         [Test]
         public void PowerTimesBrakeSpecificFuelConsumptionEqualsMassFlow()

UnitsNet.Tests/GeneratedCode/BrakeSpecificFuelConsumptionTestsBase.g.cs

@@ -38,12 +38,12 @@ public abstract partial class BrakeSpecificFuelConsumptionTestsBase
     {
         protected abstract double GramsPerKiloWattHourInOneKilogramPerJoule { get; }
         protected abstract double KilogramsPerJouleInOneKilogramPerJoule { get; }
-        protected abstract double PoundsPerHorsepowerHourInOneKilogramPerJoule { get; }
+        protected abstract double PoundsPerMechanicalHorsepowerHourInOneKilogramPerJoule { get; }
 
 // ReSharper disable VirtualMemberNeverOverriden.Global
         protected virtual double GramsPerKiloWattHourTolerance { get { return 1e-5; } }
         protected virtual double KilogramsPerJouleTolerance { get { return 1e-5; } }
-        protected virtual double PoundsPerHorsepowerHourTolerance { get { return 1e-5; } }
+        protected virtual double PoundsPerMechanicalHorsepowerHourTolerance { get { return 1e-5; } }
 // ReSharper restore VirtualMemberNeverOverriden.Global
 
         [Test]
@@ -52,15 +52,15 @@ public void KilogramPerJouleToBrakeSpecificFuelConsumptionUnits()
             BrakeSpecificFuelConsumption kilogramperjoule = BrakeSpecificFuelConsumption.FromKilogramsPerJoule(1);
             Assert.AreEqual(GramsPerKiloWattHourInOneKilogramPerJoule, kilogramperjoule.GramsPerKiloWattHour, GramsPerKiloWattHourTolerance);
             Assert.AreEqual(KilogramsPerJouleInOneKilogramPerJoule, kilogramperjoule.KilogramsPerJoule, KilogramsPerJouleTolerance);
-            Assert.AreEqual(PoundsPerHorsepowerHourInOneKilogramPerJoule, kilogramperjoule.PoundsPerHorsepowerHour, PoundsPerHorsepowerHourTolerance);
+            Assert.AreEqual(PoundsPerMechanicalHorsepowerHourInOneKilogramPerJoule, kilogramperjoule.PoundsPerMechanicalHorsepowerHour, PoundsPerMechanicalHorsepowerHourTolerance);
         }
 
         [Test]
         public void FromValueAndUnit()
         {
             Assert.AreEqual(1, BrakeSpecificFuelConsumption.From(1, BrakeSpecificFuelConsumptionUnit.GramPerKiloWattHour).GramsPerKiloWattHour, GramsPerKiloWattHourTolerance);
             Assert.AreEqual(1, BrakeSpecificFuelConsumption.From(1, BrakeSpecificFuelConsumptionUnit.KilogramPerJoule).KilogramsPerJoule, KilogramsPerJouleTolerance);
-            Assert.AreEqual(1, BrakeSpecificFuelConsumption.From(1, BrakeSpecificFuelConsumptionUnit.PoundPerHorsepowerHour).PoundsPerHorsepowerHour, PoundsPerHorsepowerHourTolerance);
+            Assert.AreEqual(1, BrakeSpecificFuelConsumption.From(1, BrakeSpecificFuelConsumptionUnit.PoundPerMechanicalHorsepowerHour).PoundsPerMechanicalHorsepowerHour, PoundsPerMechanicalHorsepowerHourTolerance);
         }
 
         [Test]
@@ -69,7 +69,7 @@ public void As()
             var kilogramperjoule = BrakeSpecificFuelConsumption.FromKilogramsPerJoule(1);
             Assert.AreEqual(GramsPerKiloWattHourInOneKilogramPerJoule, kilogramperjoule.As(BrakeSpecificFuelConsumptionUnit.GramPerKiloWattHour), GramsPerKiloWattHourTolerance);
             Assert.AreEqual(KilogramsPerJouleInOneKilogramPerJoule, kilogramperjoule.As(BrakeSpecificFuelConsumptionUnit.KilogramPerJoule), KilogramsPerJouleTolerance);
-            Assert.AreEqual(PoundsPerHorsepowerHourInOneKilogramPerJoule, kilogramperjoule.As(BrakeSpecificFuelConsumptionUnit.PoundPerHorsepowerHour), PoundsPerHorsepowerHourTolerance);
+            Assert.AreEqual(PoundsPerMechanicalHorsepowerHourInOneKilogramPerJoule, kilogramperjoule.As(BrakeSpecificFuelConsumptionUnit.PoundPerMechanicalHorsepowerHour), PoundsPerMechanicalHorsepowerHourTolerance);
         }
 
         [Test]
@@ -78,7 +78,7 @@ public void ConversionRoundTrip()
             BrakeSpecificFuelConsumption kilogramperjoule = BrakeSpecificFuelConsumption.FromKilogramsPerJoule(1);
             Assert.AreEqual(1, BrakeSpecificFuelConsumption.FromGramsPerKiloWattHour(kilogramperjoule.GramsPerKiloWattHour).KilogramsPerJoule, GramsPerKiloWattHourTolerance);
             Assert.AreEqual(1, BrakeSpecificFuelConsumption.FromKilogramsPerJoule(kilogramperjoule.KilogramsPerJoule).KilogramsPerJoule, KilogramsPerJouleTolerance);
-            Assert.AreEqual(1, BrakeSpecificFuelConsumption.FromPoundsPerHorsepowerHour(kilogramperjoule.PoundsPerHorsepowerHour).KilogramsPerJoule, PoundsPerHorsepowerHourTolerance);
+            Assert.AreEqual(1, BrakeSpecificFuelConsumption.FromPoundsPerMechanicalHorsepowerHour(kilogramperjoule.PoundsPerMechanicalHorsepowerHour).KilogramsPerJoule, PoundsPerMechanicalHorsepowerHourTolerance);
         }
 
         [Test]

UnitsNet/GeneratedCode/Enums/BrakeSpecificFuelConsumptionUnit.g.cs

@@ -27,6 +27,10 @@ public enum BrakeSpecificFuelConsumptionUnit
         Undefined = 0,
         GramPerKiloWattHour,
         KilogramPerJoule,
-        PoundPerHorsepowerHour,
+
+        /// <summary>
+        ///     The pound per horse power hour uses mechanical horse power and the imperial pound
+        /// </summary>
+        PoundPerMechanicalHorsepowerHour,
     }
 }

UnitsNet/GeneratedCode/UnitClasses/BrakeSpecificFuelConsumption.g.cs

@@ -71,9 +71,9 @@ public double KilogramsPerJoule
         }
 
         /// <summary>
-        ///     Get BrakeSpecificFuelConsumption in PoundsPerHorsepowerHour.
+        ///     Get BrakeSpecificFuelConsumption in PoundsPerMechanicalHorsepowerHour.
         /// </summary>
-        public double PoundsPerHorsepowerHour
+        public double PoundsPerMechanicalHorsepowerHour
         {
             get { return _kilogramsPerJoule/1.689659410672e-7; }
         }
@@ -104,11 +104,11 @@ public static BrakeSpecificFuelConsumption FromKilogramsPerJoule(double kilogram
         }
 
         /// <summary>
-        ///     Get BrakeSpecificFuelConsumption from PoundsPerHorsepowerHour.
+        ///     Get BrakeSpecificFuelConsumption from PoundsPerMechanicalHorsepowerHour.
         /// </summary>
-        public static BrakeSpecificFuelConsumption FromPoundsPerHorsepowerHour(double poundsperhorsepowerhour)
+        public static BrakeSpecificFuelConsumption FromPoundsPerMechanicalHorsepowerHour(double poundspermechanicalhorsepowerhour)
         {
-            return new BrakeSpecificFuelConsumption(poundsperhorsepowerhour*1.689659410672e-7);
+            return new BrakeSpecificFuelConsumption(poundspermechanicalhorsepowerhour*1.689659410672e-7);
         }
 
 
@@ -143,13 +143,13 @@ public static BrakeSpecificFuelConsumption FromPoundsPerHorsepowerHour(double po
         }
 
         /// <summary>
-        ///     Get nullable BrakeSpecificFuelConsumption from nullable PoundsPerHorsepowerHour.
+        ///     Get nullable BrakeSpecificFuelConsumption from nullable PoundsPerMechanicalHorsepowerHour.
         /// </summary>
-        public static BrakeSpecificFuelConsumption? FromPoundsPerHorsepowerHour(double? poundsperhorsepowerhour)
+        public static BrakeSpecificFuelConsumption? FromPoundsPerMechanicalHorsepowerHour(double? poundspermechanicalhorsepowerhour)
         {
-            if (poundsperhorsepowerhour.HasValue)
+            if (poundspermechanicalhorsepowerhour.HasValue)
             {
-                return FromPoundsPerHorsepowerHour(poundsperhorsepowerhour.Value);
+                return FromPoundsPerMechanicalHorsepowerHour(poundspermechanicalhorsepowerhour.Value);
             }
             else
             {
@@ -172,8 +172,8 @@ public static BrakeSpecificFuelConsumption From(double value, BrakeSpecificFuelC
                     return FromGramsPerKiloWattHour(value);
                 case BrakeSpecificFuelConsumptionUnit.KilogramPerJoule:
                     return FromKilogramsPerJoule(value);
-                case BrakeSpecificFuelConsumptionUnit.PoundPerHorsepowerHour:
-                    return FromPoundsPerHorsepowerHour(value);
+                case BrakeSpecificFuelConsumptionUnit.PoundPerMechanicalHorsepowerHour:
+                    return FromPoundsPerMechanicalHorsepowerHour(value);
 
                 default:
                     throw new NotImplementedException("fromUnit: " + fromUnit);
@@ -198,8 +198,8 @@ public static BrakeSpecificFuelConsumption From(double value, BrakeSpecificFuelC
                     return FromGramsPerKiloWattHour(value.Value);
                 case BrakeSpecificFuelConsumptionUnit.KilogramPerJoule:
                     return FromKilogramsPerJoule(value.Value);
-                case BrakeSpecificFuelConsumptionUnit.PoundPerHorsepowerHour:
-                    return FromPoundsPerHorsepowerHour(value.Value);
+                case BrakeSpecificFuelConsumptionUnit.PoundPerMechanicalHorsepowerHour:
+                    return FromPoundsPerMechanicalHorsepowerHour(value.Value);
 
                 default:
                     throw new NotImplementedException("fromUnit: " + fromUnit);
@@ -337,8 +337,8 @@ public double As(BrakeSpecificFuelConsumptionUnit unit)
                     return GramsPerKiloWattHour;
                 case BrakeSpecificFuelConsumptionUnit.KilogramPerJoule:
                     return KilogramsPerJoule;
-                case BrakeSpecificFuelConsumptionUnit.PoundPerHorsepowerHour:
-                    return PoundsPerHorsepowerHour;
+                case BrakeSpecificFuelConsumptionUnit.PoundPerMechanicalHorsepowerHour:
+                    return PoundsPerMechanicalHorsepowerHour;
 
                 default:
                     throw new NotImplementedException("unit: " + unit);

UnitsNet/GeneratedCode/UnitSystem.Default.g.cs

@@ -249,7 +249,7 @@ private static readonly ReadOnlyCollection<UnitLocalization> DefaultLocalization
                             {
                                 new AbbreviationsForCulture("en-US", "kg/J"),
                             }),
-                        new CulturesForEnumValue((int) BrakeSpecificFuelConsumptionUnit.PoundPerHorsepowerHour,
+                        new CulturesForEnumValue((int) BrakeSpecificFuelConsumptionUnit.PoundPerMechanicalHorsepowerHour,
                             new[]
                             {
                                 new AbbreviationsForCulture("en-US", "lb/hph"),

UnitsNet/Scripts/UnitDefinitions/BrakeSpecificFuelConsumption.json

@@ -28,10 +28,11 @@
       ]
     },
     {
-      "SingularName": "PoundPerHorsepowerHour",
-      "PluralName": "PoundsPerHorsepowerHour",
+      "SingularName": "PoundPerMechanicalHorsepowerHour",
+      "PluralName": "PoundsPerMechanicalHorsepowerHour",
       "FromUnitToBaseFunc": "x*1.689659410672e-7",
       "FromBaseToUnitFunc": "x/1.689659410672e-7",
+      "XmlDocSummary": "The pound per horse power hour uses mechanical horse power and the imperial pound",
       "Localization": [
         {
           "Culture": "en-US",