⚰️🧪Remove DisableParallelizationCollectionFixture for some tests

angularsen · angularsen · commit b232de4273b8 · 2024-12-27T20:41:51.000+01:00
Only tests that manipulate the global, static `UnitsNetSetup.Default.UnitAbbreviations` need to disable parallelization, changes to CurrentCulture is thread-static and is not flaky as long as each test reverts their changes with `CultureScope` or try-finally.

# Conflicts:
#	UnitsNet.Tests/UnitAbbreviationsCacheTests.cs
diff --git a/UnitsNet.Tests/CustomCode/LengthTests.cs b/UnitsNet.Tests/CustomCode/LengthTests.cs
@@ -8,10 +8,6 @@
 
 namespace UnitsNet.Tests
 {
-    // Avoid accessing static prop DefaultToString in parallel from multiple tests:
-    // UnitSystemTests.DefaultToStringFormatting()
-    // LengthTests.ToStringReturnsCorrectNumberAndUnitWithCentimeterAsDefualtUnit()
-    [Collection(nameof(DisableParallelizationCollectionFixture))]
     public class LengthTests : LengthTestsBase
     {
         protected override bool SupportsSIUnitSystem => true;
diff --git a/UnitsNet.Tests/CustomCode/ParseTests.cs b/UnitsNet.Tests/CustomCode/ParseTests.cs
@@ -15,7 +15,6 @@ namespace UnitsNet.Tests
     ///     reasonable to assume that testing one unit class would cover
     ///     all of them. Obviously, that can change in the future.
     /// </remarks>
-    [Collection(nameof(DisableParallelizationCollectionFixture))]
     public class ParseTests
     {
         [Theory]
diff --git a/UnitsNet.Tests/QuantityTests.ToString.cs b/UnitsNet.Tests/QuantityTests.ToString.cs
@@ -9,7 +9,6 @@
 
 namespace UnitsNet.Tests
 {
-    [Collection(nameof(DisableParallelizationCollectionFixture))]
     public partial class QuantityTests
     {
         public class ToStringTests
diff --git a/UnitsNet.Tests/UnitAbbreviationsCacheTests.cs b/UnitsNet.Tests/UnitAbbreviationsCacheTests.cs
@@ -9,6 +9,7 @@
 
 namespace UnitsNet.Tests
 {
+    // Disable parallelization due to manipulating global state, like UnitAbbreviationsCache.Default.MapUnitToDefaultAbbreviation().
     [Collection(nameof(DisableParallelizationCollectionFixture))]
     public class UnitAbbreviationsCacheTests
     {
diff --git a/UnitsNet.Tests/UnitParserTests.cs b/UnitsNet.Tests/UnitParserTests.cs
@@ -9,7 +9,6 @@
 
 namespace UnitsNet.Tests
 {
-    [Collection(nameof(DisableParallelizationCollectionFixture))]
     public class UnitParserTests
     {
         [Theory]

Original file line number	Diff line number	Diff line change
`@@ -8,10 +8,6 @@`
`8`	`8`
`9`	`9`	`namespace UnitsNet.Tests`
`10`	`10`	`{`
`11`		`- // Avoid accessing static prop DefaultToString in parallel from multiple tests:`
`12`		`- // UnitSystemTests.DefaultToStringFormatting()`
`13`		`- // LengthTests.ToStringReturnsCorrectNumberAndUnitWithCentimeterAsDefualtUnit()`
`14`		`- [Collection(nameof(DisableParallelizationCollectionFixture))]`
`15`	`11`	`public class LengthTests : LengthTestsBase`
`16`	`12`	`{`
`17`	`13`	`protected override bool SupportsSIUnitSystem => true;`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ namespace UnitsNet.Tests`
`15`	`15`	`/// reasonable to assume that testing one unit class would cover`
`16`	`16`	`/// all of them. Obviously, that can change in the future.`
`17`	`17`	`/// </remarks>`
`18`		`- [Collection(nameof(DisableParallelizationCollectionFixture))]`
`19`	`18`	`public class ParseTests`
`20`	`19`	`{`
`21`	`20`	`[Theory]`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`
`10`	`10`	`namespace UnitsNet.Tests`
`11`	`11`	`{`
`12`		`- [Collection(nameof(DisableParallelizationCollectionFixture))]`
`13`	`12`	`public partial class QuantityTests`
`14`	`13`	`{`
`15`	`14`	`public class ToStringTests`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`
`10`	`10`	`namespace UnitsNet.Tests`
`11`	`11`	`{`
	`12`	`+ // Disable parallelization due to manipulating global state, like UnitAbbreviationsCache.Default.MapUnitToDefaultAbbreviation().`
`12`	`13`	`[Collection(nameof(DisableParallelizationCollectionFixture))]`
`13`	`14`	`public class UnitAbbreviationsCacheTests`
`14`	`15`	`{`