Skip to content

Commit cc6f439

Browse files
committed
Add '.Signed' suffix to assembly name of signed projects
When upgrading to .NET Core SDK 2.x it consistently errored on "missing project info" when trying to build UnitsNet.Serialization.JsonNet.Signed project. This may have been a hidden error all along, but it semes it incorrectly tried to reference the unsigned UnitsNet.dll because UnitsNet dlls shared assembly name (and file name). This was previously ok because they used different "obj" folders, but the new .NET Core SDK version gave warning on the use of BaseIntermediateOutputPath and probably looked up the wrong folder.
1 parent e214ae9 commit cc6f439

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

UnitsNet.Serialization.JsonNet/UnitsNet.Serialization.JsonNet.Signed.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<DefineConstants>SIGNED</DefineConstants>
1313
<SignAssembly>true</SignAssembly>
1414
<AssemblyOriginatorKeyFile>$(MSBuildProjectDirectory)\..\UnitsNet.snk</AssemblyOriginatorKeyFile>
15+
<AssemblyName>UnitsNet.Serialization.JsonNet.Signed</AssemblyName>
1516
</PropertyGroup>
1617

1718
<!-- Signed project references, will also generate the corresponding nuget dependencies -->

UnitsNet/UnitsNet.NetStandard10.Signed.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<DefineConstants>SIGNED</DefineConstants>
1313
<SignAssembly>true</SignAssembly>
1414
<AssemblyOriginatorKeyFile>$(MSBuildProjectDirectory)\..\UnitsNet.snk</AssemblyOriginatorKeyFile>
15+
<AssemblyName>UnitsNet.Signed</AssemblyName>
1516
</PropertyGroup>
1617

1718
</Project>

0 commit comments

Comments
 (0)