codegen: Output UTF-8 without BOM

angularsen · angularsen · commit eecb3e406110 · 2021-06-26T00:03:45.000+02:00
To be consistent with powershell output when both work on the same files.
diff --git a/CodeGen/Generators/NanoFrameworkGenerator.cs b/CodeGen/Generators/NanoFrameworkGenerator.cs
@@ -202,7 +202,7 @@ private static void GeneratePackageConfig(string projectPath, string quantityNam
             string filePath = Path.Combine(projectPath, "packages.config");
 
             var content = GeneratePackageConfigFile(quantityName);
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
         }
         private static void GenerateNuspec(
             string projectPath,
@@ -217,19 +217,19 @@ private static void GenerateNuspec(
                 mscorlibNuGetVersion,
                 mathNuGetVersion).Generate();
 
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
         }
 
         private static void GenerateProperties(string filePath)
         {
             var content = new PropertyGenerator().Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
         }
 
         private static void GenerateUnitType(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new UnitTypeGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("unit(OK) ");
         }
 
@@ -242,14 +242,14 @@ private static void GenerateQuantity(StringBuilder sb, Quantity quantity, string
             content = content.Replace("Math.Pow(0.3048, 4)", "0.0086309748412416");
             // Replace Math.Pow(2.54e-2, 4) by 0.0000004162314256
             content = content.Replace("Math.Pow(2.54e-2, 4)", "0.0000004162314256");
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("quantity(OK) ");
         }
 
         private static void GenerateProject(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new ProjectGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("project(OK) ");
         }
 
@@ -259,7 +259,7 @@ private static void GenerateSolution(Quantity[] quantities, string outputDir)
 
             var filePath = Path.Combine(outputDir, "UnitsNet.nanoFramework.sln");
 
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
         }
 
         private static string GeneratePackageConfigFile(string quantityName)
diff --git a/CodeGen/Generators/QuantityJsonFilesParser.cs b/CodeGen/Generators/QuantityJsonFilesParser.cs
@@ -42,7 +42,7 @@ private static Quantity ParseQuantityFile(string jsonFile)
         {
             try
             {
-                var quantity = JsonConvert.DeserializeObject<Quantity>(File.ReadAllText(jsonFile, Encoding.UTF8), JsonSerializerSettings)
+                var quantity = JsonConvert.DeserializeObject<Quantity>(File.ReadAllText(jsonFile), JsonSerializerSettings)
                                ?? throw new UnitsNetCodeGenException($"Unable to parse quantity from JSON file: {jsonFile}");
 
                 AddPrefixUnits(quantity);
diff --git a/CodeGen/Generators/UnitsNetGenerator.cs b/CodeGen/Generators/UnitsNetGenerator.cs
@@ -91,77 +91,77 @@ private static void GenerateQuantityTestClassIfNotExists(StringBuilder sb, Quant
             }
 
             var content = new UnitTestStubGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("test stub(OK) ");
         }
 
         private static void GenerateQuantity(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new QuantityGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("quantity(OK) ");
         }
 
         private static void GenerateNumberToExtensions(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new NumberExtensionsGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("number extensions(OK) ");
         }
 
         private static void GenerateNumberToExtensionsTestClass(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new NumberExtensionsTestClassGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("number extensions tests(OK) ");
         }
 
         private static void GenerateUnitType(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new UnitTypeGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("unit(OK) ");
         }
 
         private static void GenerateQuantityTestBaseClass(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new UnitTestBaseClassGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("test base(OK) ");
         }
 
         private static void GenerateIQuantityTests(Quantity[] quantities, string filePath)
         {
             var content = new IQuantityTestClassGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("IQuantityTests.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
 
         private static void GenerateUnitAbbreviationsCache(Quantity[] quantities, string filePath)
         {
             var content = new UnitAbbreviationsCacheGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("UnitAbbreviationsCache.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
 
         private static void GenerateQuantityType(Quantity[] quantities, string filePath)
         {
             var content = new QuantityTypeGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("QuantityType.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
 
         private static void GenerateStaticQuantity(Quantity[] quantities, string filePath)
         {
             var content = new StaticQuantityGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("Quantity.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
 
         private static void GenerateUnitConverter(Quantity[] quantities, string filePath)
         {
             var content = new UnitConverterGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("UnitConverter.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
     }
diff --git a/CodeGen/Generators/UnitsNetWrcGenerator.cs b/CodeGen/Generators/UnitsNetWrcGenerator.cs
@@ -66,35 +66,35 @@ public static void Generate(string rootDir, Quantity[] quantities)
         private static void GenerateQuantity(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new QuantityGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("quantity(OK) ");
         }
 
         private static void GenerateUnitType(StringBuilder sb, Quantity quantity, string filePath)
         {
             var content = new UnitTypeGenerator(quantity).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             sb.Append("unit(OK) ");
         }
 
         private static void GenerateUnitAbbreviationsCache(Quantity[] quantities, string filePath)
         {
             var content = new UnitAbbreviationsCacheGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("UnitAbbreviationsCache.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
 
         private static void GenerateQuantityType(Quantity[] quantities, string filePath)
         {
             var content = new QuantityTypeGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("QuantityType.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
 
         private static void GenerateStaticQuantity(Quantity[] quantities, string filePath)
         {
             var content = new StaticQuantityGenerator(quantities).Generate();
-            File.WriteAllText(filePath, content, Encoding.UTF8);
+            File.WriteAllText(filePath, content);
             Log.Information("Quantity.g.cs: ".PadRight(AlignPad) + "(OK)");
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ private static void GeneratePackageConfig(string projectPath, string quantityNam`
`202`	`202`	`string filePath = Path.Combine(projectPath, "packages.config");`
`203`	`203`
`204`	`204`	`var content = GeneratePackageConfigFile(quantityName);`
`205`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`205`	`+ File.WriteAllText(filePath, content);`
`206`	`206`	`}`
`207`	`207`	`private static void GenerateNuspec(`
`208`	`208`	`string projectPath,`
`@@ -217,19 +217,19 @@ private static void GenerateNuspec(`
`217`	`217`	`mscorlibNuGetVersion,`
`218`	`218`	`mathNuGetVersion).Generate();`
`219`	`219`
`220`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`220`	`+ File.WriteAllText(filePath, content);`
`221`	`221`	`}`
`222`	`222`
`223`	`223`	`private static void GenerateProperties(string filePath)`
`224`	`224`	`{`
`225`	`225`	`var content = new PropertyGenerator().Generate();`
`226`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`226`	`+ File.WriteAllText(filePath, content);`
`227`	`227`	`}`
`228`	`228`
`229`	`229`	`private static void GenerateUnitType(StringBuilder sb, Quantity quantity, string filePath)`
`230`	`230`	`{`
`231`	`231`	`var content = new UnitTypeGenerator(quantity).Generate();`
`232`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`232`	`+ File.WriteAllText(filePath, content);`
`233`	`233`	`sb.Append("unit(OK) ");`
`234`	`234`	`}`
`235`	`235`
`@@ -242,14 +242,14 @@ private static void GenerateQuantity(StringBuilder sb, Quantity quantity, string`
`242`	`242`	`content = content.Replace("Math.Pow(0.3048, 4)", "0.0086309748412416");`
`243`	`243`	`// Replace Math.Pow(2.54e-2, 4) by 0.0000004162314256`
`244`	`244`	`content = content.Replace("Math.Pow(2.54e-2, 4)", "0.0000004162314256");`
`245`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`245`	`+ File.WriteAllText(filePath, content);`
`246`	`246`	`sb.Append("quantity(OK) ");`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`private static void GenerateProject(StringBuilder sb, Quantity quantity, string filePath)`
`250`	`250`	`{`
`251`	`251`	`var content = new ProjectGenerator(quantity).Generate();`
`252`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`252`	`+ File.WriteAllText(filePath, content);`
`253`	`253`	`sb.Append("project(OK) ");`
`254`	`254`	`}`
`255`	`255`
`@@ -259,7 +259,7 @@ private static void GenerateSolution(Quantity[] quantities, string outputDir)`
`259`	`259`
`260`	`260`	`var filePath = Path.Combine(outputDir, "UnitsNet.nanoFramework.sln");`
`261`	`261`
`262`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`262`	`+ File.WriteAllText(filePath, content);`
`263`	`263`	`}`
`264`	`264`
`265`	`265`	`private static string GeneratePackageConfigFile(string quantityName)`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ private static Quantity ParseQuantityFile(string jsonFile)`
`42`	`42`	`{`
`43`	`43`	`try`
`44`	`44`	`{`
`45`		`- var quantity = JsonConvert.DeserializeObject<Quantity>(File.ReadAllText(jsonFile, Encoding.UTF8), JsonSerializerSettings)`
	`45`	`+ var quantity = JsonConvert.DeserializeObject<Quantity>(File.ReadAllText(jsonFile), JsonSerializerSettings)`
`46`	`46`	`?? throw new UnitsNetCodeGenException($"Unable to parse quantity from JSON file: {jsonFile}");`
`47`	`47`
`48`	`48`	`AddPrefixUnits(quantity);`
Original file line number	Diff line number	Diff line change
`@@ -91,77 +91,77 @@ private static void GenerateQuantityTestClassIfNotExists(StringBuilder sb, Quant`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`var content = new UnitTestStubGenerator(quantity).Generate();`
`94`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`94`	`+ File.WriteAllText(filePath, content);`
`95`	`95`	`sb.Append("test stub(OK) ");`
`96`	`96`	`}`
`97`	`97`
`98`	`98`	`private static void GenerateQuantity(StringBuilder sb, Quantity quantity, string filePath)`
`99`	`99`	`{`
`100`	`100`	`var content = new QuantityGenerator(quantity).Generate();`
`101`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`101`	`+ File.WriteAllText(filePath, content);`
`102`	`102`	`sb.Append("quantity(OK) ");`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`private static void GenerateNumberToExtensions(StringBuilder sb, Quantity quantity, string filePath)`
`106`	`106`	`{`
`107`	`107`	`var content = new NumberExtensionsGenerator(quantity).Generate();`
`108`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`108`	`+ File.WriteAllText(filePath, content);`
`109`	`109`	`sb.Append("number extensions(OK) ");`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`private static void GenerateNumberToExtensionsTestClass(StringBuilder sb, Quantity quantity, string filePath)`
`113`	`113`	`{`
`114`	`114`	`var content = new NumberExtensionsTestClassGenerator(quantity).Generate();`
`115`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`115`	`+ File.WriteAllText(filePath, content);`
`116`	`116`	`sb.Append("number extensions tests(OK) ");`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`private static void GenerateUnitType(StringBuilder sb, Quantity quantity, string filePath)`
`120`	`120`	`{`
`121`	`121`	`var content = new UnitTypeGenerator(quantity).Generate();`
`122`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`122`	`+ File.WriteAllText(filePath, content);`
`123`	`123`	`sb.Append("unit(OK) ");`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`private static void GenerateQuantityTestBaseClass(StringBuilder sb, Quantity quantity, string filePath)`
`127`	`127`	`{`
`128`	`128`	`var content = new UnitTestBaseClassGenerator(quantity).Generate();`
`129`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`129`	`+ File.WriteAllText(filePath, content);`
`130`	`130`	`sb.Append("test base(OK) ");`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`private static void GenerateIQuantityTests(Quantity[] quantities, string filePath)`
`134`	`134`	`{`
`135`	`135`	`var content = new IQuantityTestClassGenerator(quantities).Generate();`
`136`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`136`	`+ File.WriteAllText(filePath, content);`
`137`	`137`	`Log.Information("IQuantityTests.g.cs: ".PadRight(AlignPad) + "(OK)");`
`138`	`138`	`}`
`139`	`139`
`140`	`140`	`private static void GenerateUnitAbbreviationsCache(Quantity[] quantities, string filePath)`
`141`	`141`	`{`
`142`	`142`	`var content = new UnitAbbreviationsCacheGenerator(quantities).Generate();`
`143`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`143`	`+ File.WriteAllText(filePath, content);`
`144`	`144`	`Log.Information("UnitAbbreviationsCache.g.cs: ".PadRight(AlignPad) + "(OK)");`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`private static void GenerateQuantityType(Quantity[] quantities, string filePath)`
`148`	`148`	`{`
`149`	`149`	`var content = new QuantityTypeGenerator(quantities).Generate();`
`150`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`150`	`+ File.WriteAllText(filePath, content);`
`151`	`151`	`Log.Information("QuantityType.g.cs: ".PadRight(AlignPad) + "(OK)");`
`152`	`152`	`}`
`153`	`153`
`154`	`154`	`private static void GenerateStaticQuantity(Quantity[] quantities, string filePath)`
`155`	`155`	`{`
`156`	`156`	`var content = new StaticQuantityGenerator(quantities).Generate();`
`157`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`157`	`+ File.WriteAllText(filePath, content);`
`158`	`158`	`Log.Information("Quantity.g.cs: ".PadRight(AlignPad) + "(OK)");`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`private static void GenerateUnitConverter(Quantity[] quantities, string filePath)`
`162`	`162`	`{`
`163`	`163`	`var content = new UnitConverterGenerator(quantities).Generate();`
`164`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`164`	`+ File.WriteAllText(filePath, content);`
`165`	`165`	`Log.Information("UnitConverter.g.cs: ".PadRight(AlignPad) + "(OK)");`
`166`	`166`	`}`
`167`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -66,35 +66,35 @@ public static void Generate(string rootDir, Quantity[] quantities)`
`66`	`66`	`private static void GenerateQuantity(StringBuilder sb, Quantity quantity, string filePath)`
`67`	`67`	`{`
`68`	`68`	`var content = new QuantityGenerator(quantity).Generate();`
`69`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`69`	`+ File.WriteAllText(filePath, content);`
`70`	`70`	`sb.Append("quantity(OK) ");`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`private static void GenerateUnitType(StringBuilder sb, Quantity quantity, string filePath)`
`74`	`74`	`{`
`75`	`75`	`var content = new UnitTypeGenerator(quantity).Generate();`
`76`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`76`	`+ File.WriteAllText(filePath, content);`
`77`	`77`	`sb.Append("unit(OK) ");`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`private static void GenerateUnitAbbreviationsCache(Quantity[] quantities, string filePath)`
`81`	`81`	`{`
`82`	`82`	`var content = new UnitAbbreviationsCacheGenerator(quantities).Generate();`
`83`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`83`	`+ File.WriteAllText(filePath, content);`
`84`	`84`	`Log.Information("UnitAbbreviationsCache.g.cs: ".PadRight(AlignPad) + "(OK)");`
`85`	`85`	`}`
`86`	`86`
`87`	`87`	`private static void GenerateQuantityType(Quantity[] quantities, string filePath)`
`88`	`88`	`{`
`89`	`89`	`var content = new QuantityTypeGenerator(quantities).Generate();`
`90`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`90`	`+ File.WriteAllText(filePath, content);`
`91`	`91`	`Log.Information("QuantityType.g.cs: ".PadRight(AlignPad) + "(OK)");`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`private static void GenerateStaticQuantity(Quantity[] quantities, string filePath)`
`95`	`95`	`{`
`96`	`96`	`var content = new StaticQuantityGenerator(quantities).Generate();`
`97`		`- File.WriteAllText(filePath, content, Encoding.UTF8);`
	`97`	`+ File.WriteAllText(filePath, content);`
`98`	`98`	`Log.Information("Quantity.g.cs: ".PadRight(AlignPad) + "(OK)");`
`99`	`99`	`}`
`100`	`100`	`}`