Skip to content

Commit f63463d

Browse files
committed
Added missing tests for Convert() and TryConvert() for area, volume and force units in UnitConverterTests.cs.
1 parent a192225 commit f63463d

File tree

1 file changed

+15
-5
lines changed

1 file changed

+15
-5
lines changed

Tests/UnitConverterTests.cs

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,11 @@ public void SquareMeterToAreaUnits()
7272
public void ThrowsOnIncompatibleUnits()
7373
{
7474
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.Meter, Unit.Second));
75+
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.SquareMeter, Unit.Second));
76+
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.CubicMeter, Unit.Second));
77+
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.Newton, Unit.Second));
7578
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.Pascal, Unit.Second));
7679
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.Kilogram, Unit.Second));
77-
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.CubicMeter, Unit.Second));
7880
Assert.Throws<Exception>(() => UnitConverter.Convert(1, Unit.Degree, Unit.Second));
7981
}
8082

@@ -85,16 +87,20 @@ public void TryConvertReturnsFalseOnIncompatibleUnits()
8587

8688
// Assert from-unit cases. One for each class of unit.
8789
Assert.False(UnitConverter.TryConvert(1, Unit.Meter, Unit.Second, out newValue));
90+
Assert.False(UnitConverter.TryConvert(1, Unit.SquareMeter, Unit.Second, out newValue));
91+
Assert.False(UnitConverter.TryConvert(1, Unit.CubicMeter, Unit.Second, out newValue));
92+
Assert.False(UnitConverter.TryConvert(1, Unit.Newton, Unit.Second, out newValue));
8893
Assert.False(UnitConverter.TryConvert(1, Unit.Pascal, Unit.Second, out newValue));
8994
Assert.False(UnitConverter.TryConvert(1, Unit.Kilogram, Unit.Second, out newValue));
90-
Assert.False(UnitConverter.TryConvert(1, Unit.CubicMeter, Unit.Second, out newValue));
9195
Assert.False(UnitConverter.TryConvert(1, Unit.Degree, Unit.Second, out newValue));
9296

9397
// Assert to-unit cases. One for each class of unit.
9498
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.Meter, out newValue));
99+
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.SquareMeter, out newValue));
100+
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.CubicMeter, out newValue));
101+
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.Newton, out newValue));
95102
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.Pascal, out newValue));
96103
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.Kilogram, out newValue));
97-
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.CubicMeter, out newValue));
98104
Assert.False(UnitConverter.TryConvert(1, Unit.Second, Unit.Degree, out newValue));
99105
}
100106

@@ -105,16 +111,20 @@ public void TryConvertReturnsTrueOnCompatibleUnits()
105111

106112
// Assert from-unit cases. One for each class of unit.
107113
Assert.True(UnitConverter.TryConvert(1, Unit.Meter, Unit.Centimeter, out newValue));
114+
Assert.True(UnitConverter.TryConvert(1, Unit.SquareMeter, Unit.SquareCentimeter, out newValue));
115+
Assert.True(UnitConverter.TryConvert(1, Unit.CubicMeter, Unit.Liter, out newValue));
116+
Assert.True(UnitConverter.TryConvert(1, Unit.Newton, Unit.KilogramForce, out newValue));
108117
Assert.True(UnitConverter.TryConvert(1, Unit.Pascal, Unit.KiloPascal, out newValue));
109118
Assert.True(UnitConverter.TryConvert(1, Unit.Kilogram, Unit.Gram, out newValue));
110-
Assert.True(UnitConverter.TryConvert(1, Unit.CubicMeter, Unit.Liter, out newValue));
111119
Assert.True(UnitConverter.TryConvert(1, Unit.Degree, Unit.Radian, out newValue));
112120

113121
// Assert to-unit cases. One for each class of unit.
114122
Assert.True(UnitConverter.TryConvert(1, Unit.Centimeter, Unit.Meter, out newValue));
123+
Assert.True(UnitConverter.TryConvert(1, Unit.SquareCentimeter, Unit.SquareMeter, out newValue));
124+
Assert.True(UnitConverter.TryConvert(1, Unit.Liter, Unit.CubicMeter, out newValue));
125+
Assert.True(UnitConverter.TryConvert(1, Unit.KilogramForce, Unit.Newton, out newValue));
115126
Assert.True(UnitConverter.TryConvert(1, Unit.KiloPascal, Unit.Pascal, out newValue));
116127
Assert.True(UnitConverter.TryConvert(1, Unit.Gram, Unit.Kilogram, out newValue));
117-
Assert.True(UnitConverter.TryConvert(1, Unit.Liter, Unit.CubicMeter, out newValue));
118128
Assert.True(UnitConverter.TryConvert(1, Unit.Radian, Unit.Degree, out newValue));
119129
}
120130
}

0 commit comments

Comments
 (0)