Skip to content

Making TabViewer::id mandatory? #284

@dolezvo1

Description

@dolezvo1

Hi, I've been curious if there is a good reason for not making TabViewer::id mandatory, instead of using the Id of the title by default as it works right now. I mean, yes, I suppose the current default implementation is good enough for very simple apps, but it's likely to be much more expensive than Id::new(tab), as well as being incorrect when two tabs have the same title. That means that you have to be aware of the default implementation being less-than-ideal in two subtle ways to use the library correctly. For this reason, I'm not sure it suffices as a good default implementation, but it's just an opinion, of course.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions