refactor(lint): more strict types (where i could...)

#163

Author: azinit

src/features/repo-list/items/index.tsx

@@ -1,6 +1,7 @@
 import React from "react";
 import { Empty } from "antd";
 import { Repo, Card } from "shared/components";
+import { VeryMaybe, Repository } from "models";
 import { RepositoriesDetailsFragment } from "../queries.gen";
 import { useStarring } from "../hooks";
 
@@ -31,7 +32,7 @@ const RepoListItems = (props: Props) => {
                     <Repo
                         onStarring={() => starring.handle(node?.id, node?.viewerHasStarred)}
                         key={node?.id}
-                        data={node}
+                        data={node as VeryMaybe<Repository>}
                         loading={starring.debouncedLoadingId === node?.id}
                     />
                 ))

src/features/search/results/list/index.tsx

@@ -2,6 +2,7 @@ import React from "react";
 import cn from "classnames";
 import { Empty } from "antd";
 import { Repo, User, Org, Card } from "shared/components";
+import { VeryMaybe, Repository } from "models";
 import { SearchQuery } from "../queries.gen";
 import "./index.scss";
 
@@ -35,7 +36,9 @@ const ResultsList = (props: Props) => {
                     className={cn("search-results__item", "mb-6", (node as any).__typename)}
                 >
                     {/* !!! FIXME: simplify */}
-                    {isRepoSearch && <Repo data={node} format="owner-repo" />}
+                    {isRepoSearch && (
+                        <Repo data={node as VeryMaybe<Repository>} format="owner-repo" />
+                    )}
                     {isUserSearch &&
                         ((node as any)?.__typename === "Organization" ? (
                             <Org data={node} />

src/models.ts

@@ -51,3 +51,9 @@ export type GitCommit = {
     name?: string | null;
     date: string;
 };
+
+/**
+ * Вынужденная обертка для некоторых компонентов по данным с API
+ * !!! FIXME: more strict types (TotallyNullable not help...) or fix on codegen level
+ */
+export type VeryMaybe<T> = import("models.gen").Maybe<Partial<T>>;

src/shared/components/org/index.tsx

@@ -1,22 +1,21 @@
 import React from "react";
 import { Button } from "antd";
 import { BankOutlined } from "@ant-design/icons";
+import { VeryMaybe, Organization } from "models";
 import Card from "../card";
 import "./index.scss";
 
-// !!! FIXME: specify types
 type Props = {
     /** Данные по организции */
-    data: any;
+    data: VeryMaybe<Organization>;
 };
 
 /**
  * @ItemEntity Карточка организации
  */
 const Org = (props: Props) => {
-    const { avatarUrl, login, description, url } = props.data as Partial<
-        import("models").Organization
-    >;
+    const { avatarUrl, login, description, url } = props.data || {};
+
     return (
         <Card
             className="org"

src/shared/components/repo/index.tsx

@@ -2,15 +2,14 @@ import React from "react";
 import cn from "classnames";
 import { HeartFilled, HeartOutlined } from "@ant-design/icons";
 import dayjs from "dayjs";
-import { Repository } from "models";
+import { VeryMaybe, Repository } from "models";
 import Card from "../card";
 import Lang from "./lang";
 import "./index.scss";
 
-// !!! FIXME: specify types
 type Props = {
     /** Данные по репозиторию */
-    data: any;
+    data: VeryMaybe<Repository>;
     /** Формат отображения заголовка */
     format?: "owner-repo" | "repo";
     /** @handler star/unstar */
@@ -24,13 +23,7 @@ type Props = {
  */
 const Repo = (props: Props) => {
     const { format = "repo", onStarring, loading } = props;
-    const {
-        name,
-        primaryLanguage,
-        updatedAt,
-        viewerHasStarred: starred,
-        owner,
-    } = props.data as Partial<Repository>;
+    const { name, primaryLanguage, updatedAt, viewerHasStarred: starred, owner } = props.data || {};
     // prettier-ignore
     const title = (
         (format === "owner-repo" && `${owner?.login}/${name}`) || 

src/shared/components/user/index.tsx

@@ -1,21 +1,21 @@
 import React from "react";
 import { Button } from "antd";
+import { VeryMaybe, User } from "models";
 import Card from "../card";
 
-// !!! FIXME: specify types
 type Props = {
     /** Данные по пользователю */
-    data: any;
+    data: VeryMaybe<User>;
     /** @handler follow/unfollow */
     onFollowing?: Callback;
 };
 
 /**
  * @ItemEntity Карточка пользователя
  */
-const User = (props: Props) => {
+const UserCard = (props: Props) => {
     const { data, onFollowing } = props;
-    const { avatarUrl, login, viewerIsFollowing, bio } = data as Partial<import("models").User>;
+    const { avatarUrl, login, viewerIsFollowing, bio } = data || {};
     return (
         <Card
             className="user"
@@ -38,4 +38,4 @@ const User = (props: Props) => {
     );
 };
 
-export default User;
+export default UserCard;