Merge pull request #170 from ani-team/feature/strict-eslint

Restrict eslint

## CHANGELOG
- (#157) Ограничение макс. кол-ва строк в функции (48)
- (#157) Ограничение макс. длины в файлах (120)
- (#157) Ограничение импортов (согласно fdd и запрету приватных импортов)
- (#157) Добавлены некоторые базовые eslint и unicorn правила


![image](https://user-images.githubusercontent.com/42924400/100811042-cc047300-344a-11eb-8a4d-b391b6f9f5ba.png)

Author: azinit

.eslintignore

@@ -3,3 +3,5 @@ dist/**
 build/**
 *.gen.ts
 .github
+public/
+.workflows

.eslintrc.js

@@ -1,3 +1,14 @@
+/** Разрешенные импорты (с публичными API) */
+const ALLOWED_PATH_GROUPS = ["shared", "shared/**", "pages", "features", "models"].map(
+    (pattern) => ({
+        pattern,
+        group: "internal",
+        position: "after",
+    }),
+);
+/** Для запрета приватных путей */
+const DENIED_PATH_GROUPS = ["app/**", "pages/**", "features/**", "shared/*/**"];
+
 module.exports = {
     parser: "@typescript-eslint/parser",
     parserOptions: {
@@ -12,7 +23,7 @@ module.exports = {
         browser: true,
         es6: true,
     },
-    plugins: ["react", "@typescript-eslint", "@graphql-eslint"],
+    plugins: ["react", "@typescript-eslint", "@graphql-eslint", "unicorn"],
     extends: [
         "react-app",
         "eslint:recommended",
@@ -25,29 +36,49 @@ module.exports = {
         "prettier/react",
     ],
     rules: {
+        // imports
         "import/first": 2,
         "import/no-unresolved": 0,
         "import/order": [
             2,
             {
-                pathGroups: [
-                    "shared",
-                    "shared/**",
-                    "pages",
-                    "pages/**",
-                    "features",
-                    "features/**",
-                    "models",
-                ].map((pattern) => ({
-                    pattern,
-                    group: "internal",
-                    position: "after",
-                })),
+                pathGroups: ALLOWED_PATH_GROUPS,
                 // TODO: Добавить сортировку `import "./index.scss";` (располагать внизу)
                 pathGroupsExcludedImportTypes: ["builtin"],
                 groups: ["builtin", "external", "internal", "parent", "sibling", "index"],
             },
         ],
+        // TODO: specify message: ("Please use allowed public API (not private imports!)")
+        "no-restricted-imports": [1, { patterns: DENIED_PATH_GROUPS }],
+        // variables
+        "prefer-const": 2,
+        "no-var": 2,
+        // base
+        "camelcase": [1, { ignoreDestructuring: true, ignoreImports: true, properties: "never" }],
+        "no-else-return": 2,
+        "max-len": [1, { code: 120 }],
+        "dot-notation": 2,
+        "eol-last": 2,
+        // alert, console
+        "no-alert": 2,
+        "no-console": 0,
+        // equals
+        "eqeqeq": 1,
+        "no-eq-null": 2,
+        // function
+        "max-params": [1, 2],
+        "max-lines-per-function": [1, 48],
+        "arrow-parens": [2, "always"],
+        // plugin:unicorn
+        "unicorn/no-for-loop": 2,
+        "unicorn/no-abusive-eslint-disable": 2,
+        "unicorn/no-array-instanceof": 2,
+        "unicorn/no-zero-fractions": 2,
+        "unicorn/prefer-includes": 2,
+        "unicorn/prefer-text-content": 2,
+        "unicorn/import-index": 2,
+        "unicorn/throw-new-error": 2,
+        // plugin:graphql
         "@graphql-eslint/no-anonymous-operations": 2,
     },
     overrides: [
@@ -57,6 +88,7 @@ module.exports = {
             plugins: ["@graphql-eslint"],
             rules: {
                 "prettier/prettier": 0,
+                "max-len": 0,
             },
         },
     ],

package-lock.json

@@ -77,6 +77,7 @@
     "eslint": "^7.11.0",
     "eslint-config-prettier": "^6.13.0",
     "eslint-plugin-prettier": "^3.1.4",
+    "eslint-plugin-unicorn": "^23.0.0",
     "husky": "^4.3.0",
     "lint-staged": "^10.4.2",
     "prettier": "^2.1.2",

package.json

@@ -2,7 +2,8 @@ import React from "react";
 import { GithubFilled } from "@ant-design/icons";
 import { Alert, Card } from "antd";
 import { alert } from "shared/helpers";
-// !!! FIXME: loop imports
+// !!! FIXME: это плохо( + loop imports
+// eslint-disable-next-line import/order
 import { useTitle } from "pages/helpers";
 import { authorizeGithub } from "../firebase";
 import { useAuth } from "../hooks";

src/features/auth/page/index.tsx

@@ -29,11 +29,9 @@ const RepoDetails = ({ repo: identity }: Props) => {
     });
     const repository = data?.repository;
 
-    const languages = repository?.languages?.nodes?.filter(
-        (lang): lang is Language => lang != null,
-    );
+    const languages = repository?.languages?.nodes?.filter((lang): lang is Language => !!lang);
     const collaborators = repository?.collaborators?.nodes?.filter(
-        (collaborator): collaborator is Collaborator => collaborator != null,
+        (collaborator): collaborator is Collaborator => !!collaborator,
     );
     return (
         <div className="flex flex-col">