Skip to content

Commit b54398a

Browse files
authored
Merge pull request #154 from niyazm524/fix/feedback
fix(style)
2 parents 0c8c6ea + 6da9564 commit b54398a

File tree

12 files changed

+33
-30
lines changed

12 files changed

+33
-30
lines changed

src/app/normalize-antd.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,8 @@
1212
height: 100%;
1313
background: rgba(255, 255, 255, 0.5);
1414
}
15+
16+
.ant-select-selector,
17+
.ant-btn {
18+
border-radius: 5px !important;
19+
}

src/app/vars.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
/* misc */
2929
--transition: 0.25s;
30-
// TODO: add border-radius
30+
--radius: 10px;
3131

3232
/* fonts */
3333
--ff-primary: 'Roboto', sans-serif;

src/features/home-hero/index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
color: var(--clr-gray--100);
3434
background: var(--clr-primary);
3535
border: none;
36-
border-radius: 10px;
36+
border-radius: var(--radius);
3737
outline: none;
3838
transition: 0.4s;
3939

src/features/repo-details/details-card/index.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.details-card {
22
padding: 12px 16px;
33
background-color: var(--clr-gray--100);
4-
border-radius: 10px;
4+
border-radius: var(--radius);
55

66
&.primary {
77
background-color: var(--clr-primary);

src/features/repo-list/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ const RepoList = ({ username }: Props) => {
8484
data?.user?.repositories.nodes?.map((node) => <Repo key={node?.id} {...node} />)
8585
) : (
8686
<h2 className="repo-list__placeholder">
87-
{username} doesn’t have any public repositories yet.
87+
{username} doesn’t have any repositories yet.
8888
</h2>
8989
)}
9090
</div>

src/features/search/results/index.scss

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,5 @@
1313
&__item {
1414
user-select: none;
1515
border-radius: 10px;
16-
box-shadow: 0 5px 0 var(--clr-gray--900);
17-
transition: var(--transition);
18-
19-
&:hover {
20-
box-shadow: 0 5px 0 var(--clr-primary--hover);
21-
}
22-
23-
&:active {
24-
box-shadow: 0 5px 0 var(--clr-primary--active);
25-
}
26-
27-
&.Organization {
28-
pointer-events: none;
29-
box-shadow: 0 5px 0 var(--clr-danger);
30-
opacity: 0.5;
31-
32-
.card__actions {
33-
pointer-events: all;
34-
}
35-
}
3616
}
3717
}

src/features/user-info/index.scss

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@
66

77
&-ava {
88
width: 100%;
9-
border-radius: 10px;
9+
border-radius: var(--radius);
1010
}
1111

1212
&-placeholder {
1313
min-width: 100%;
1414
height: 0;
1515
padding-bottom: 100%;
16-
border-radius: 10px;
16+
border-radius: var(--radius);
1717
}
1818
}
1919

@@ -33,12 +33,10 @@
3333
line-height: 28px;
3434
}
3535

36-
// !!! FIXME: styles (enhance colors)
3736
&__btn.follow,
3837
&__btn.unfollow,
3938
&__btn.edit {
4039
margin-top: 10px;
41-
border-radius: 9px;
4240
transition: 0.4s;
4341

4442
&:hover {

src/shared/components/card/index.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@
55
font-size: 14px;
66
background-color: var(--clr-gray--100);
77
border-radius: 10px;
8+
box-shadow: 0 5px 0 var(--clr-gray--900);
9+
transition: var(--transition);
10+
11+
&:hover {
12+
box-shadow: 0 5px 0 var(--clr-primary--hover);
13+
}
814

915
&__preview img {
1016
min-width: 90px;

src/shared/components/card/skeleton-group/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const CardSkeletonGroup = ({ amount }: Props) => (
1414
{Array(amount)
1515
.fill(null)
1616
.map((_, index) => (
17-
<Skeleton key={index} className="mb-6" />
17+
<Skeleton key={index} className="mb-5" />
1818
))}
1919
</>
2020
);
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.card-skeleton {
22
width: 100% !important;
3-
height: 140px !important;
3+
height: 145px !important;
44
border-radius: 10px;
55
}

0 commit comments

Comments
 (0)