Merge pull request #158 from ani-team/fix/followup_pr120

Правки по #120

Author: niyazm524

src/app/error-handling/error-catcher.tsx

@@ -43,7 +43,8 @@ export default function ErrorCatcher({ handler, children }: Props) {
             setError(mapError(graphQLErrors?.[0] || networkError));
         });
         apolloClient.setLink(errorLink.concat(apolloClient.link));
-    }, [apolloClient]);
+        // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);
 
     useEffect(() => setError(null), [location]);
 

src/app/hocs/with-router.tsx

@@ -3,6 +3,9 @@ import React, { Suspense } from "react";
 import { BrowserRouter, Route } from "react-router-dom";
 import { QueryParamProvider } from "use-query-params";
 
+/**
+ * Инициализация роутера с провайдером для работы с get-параметрами
+ */
 const withRouter = (component: () => JSX.Element) => () => (
     <BrowserRouter>
         <Suspense fallback={<Spin delay={300} className="overlay" size="large" />}>

src/app/index.tsx

@@ -3,9 +3,10 @@ import { Layout } from "antd";
 import Routing from "pages";
 import { ErrorCatcher } from "./error-handling";
 import Header from "./header";
-import "./index.scss";
 import { withHocs } from "./hocs";
+import "./index.scss";
 
+// !!! FIXME: manage access
 const ErrorPage = lazy(() => import("pages/error"));
 /**
  * Entry-point приложения

src/features/home-hero/assets/bg.png src/features/hero-sheet/assets/bg.pngsrc/features/home-hero/assets/bg.png renamed to src/features/hero-sheet/assets/bg.png

@@ -4,7 +4,7 @@
     background: #e9ffff url("./assets/bg.png") no-repeat center/cover;
 }
 
-.home-hero {
+.hero-sheet {
     display: flex;
     align-items: center;
     height: inherit;

src/features/hero-sheet/assets/github-icon-sad.svg

@@ -12,33 +12,30 @@ type Props = {
     useSadHero?: boolean;
 };
 
-const HomeHero = ({ title, description, action, useSadHero = false }: Props) => {
+const HeroSheet = ({ title, description, action, useSadHero = false }: Props) => {
     const history = useHistory();
     const preferredAction = action ?? {
         text: "Back",
         to: () => (history.length > 1 ? history.goBack() : history.push("/")),
     };
+    const HeroIcon = useSadHero ? SadIcon : Icon;
 
     return (
         <div className="page page-background">
-            <Row className="home-hero">
+            <Row className="hero-sheet">
                 <Col span={16}>
-                    <h1 className="home-hero__title">{title}</h1>
-                    <p className="home-hero__description">{description}</p>
-                    <button className="home-hero__button" onClick={() => preferredAction.to()}>
+                    <h1 className="hero-sheet__title">{title}</h1>
+                    <p className="hero-sheet__description">{description}</p>
+                    <button className="hero-sheet__button" onClick={() => preferredAction.to()}>
                         {preferredAction.text}
                     </button>
                 </Col>
                 <Col span={8}>
-                    {useSadHero ? (
-                        <SadIcon className="home-hero__icon" />
-                    ) : (
-                        <Icon className="home-hero__icon" />
-                    )}
+                    <HeroIcon className="hero-sheet__icon" />
                 </Col>
             </Row>
         </div>
     );
 };
 
-export default HomeHero;
+export default HeroSheet;

…eatures/home-hero/assets/github-icon.svg …atures/hero-sheet/assets/github-icon.svgsrc/features/home-hero/assets/github-icon.svg renamed to src/features/hero-sheet/assets/github-icon.svg src/features/home-hero/assets/github-icon.svg renamed to src/features/hero-sheet/assets/github-icon.svg

@@ -10,4 +10,5 @@ export { default as RepoList } from "./repo-list";
 export { default as RepoStat } from "./repo-stat";
 export { default as Search } from "./search";
 export { default as Origin } from "./origin";
+export { default as HeroSheet } from "./hero-sheet";
 export { Auth };