Merge pull request #12 from casperisfine/single-parser

Use a single static parser for both performance and avoiding leaks

Author: anilmaurya

benchmark/leak.rb

@@ -0,0 +1,22 @@
+#!/usr/bin/env ruby
+
+$LOAD_PATH.unshift(File.expand_path('../../lib', __FILE__))
+require 'fast_jsonparser'
+
+Thread.abort_on_exception = true
+
+3.times do
+  Thread.new do
+    loop do
+      begin
+        FastJsonparser.parse('{"foo": "bar"')
+      rescue
+      end
+    end
+  end
+end
+
+loop do
+  sleep 1
+  p `ps -o rss -p #{$$}`.chomp.split("\n").last.to_i
+end

ext/fast_jsonparser/fast_jsonparser.cpp

@@ -5,6 +5,7 @@
 VALUE rb_eFastJsonparserUnknownError, rb_eFastJsonparserParseError;
 
 using namespace simdjson;
+static dom::parser parser;
 
 // Convert tape to Ruby's Object
 static VALUE make_ruby_object(dom::element element, bool symbolize_keys)
@@ -71,7 +72,6 @@ static VALUE rb_fast_jsonparser_parse(VALUE self, VALUE arg, VALUE symbolize_key
 {
     Check_Type(arg, T_STRING);
 
-    dom::parser parser;
     auto [doc, error] = parser.parse(RSTRING_PTR(arg), RSTRING_LEN(arg));
     if (error != SUCCESS)
     {
@@ -84,7 +84,6 @@ static VALUE rb_fast_jsonparser_load(VALUE self, VALUE arg, VALUE symbolize_keys
 {
     Check_Type(arg, T_STRING);
 
-    dom::parser parser;
     auto [doc, error] = parser.load(RSTRING_PTR(arg));
     if (error != SUCCESS)
     {
@@ -98,9 +97,7 @@ static VALUE rb_fast_jsonparser_load_many(VALUE self, VALUE arg, VALUE symbolize
     Check_Type(arg, T_STRING);
     Check_Type(batch_size, T_FIXNUM);
 
-    try
-    {
-        dom::parser parser;
+    try {
         auto [docs, error] = parser.load_many(RSTRING_PTR(arg), FIX2INT(batch_size));
         if (error != SUCCESS)
         {