improvement(field-editor): remove 'toggle sticky'

This is replaced by the pin icon in the Note Editor

string: "Remember last input when adding"

Fixes 18480

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/NoteTypeFieldEditor.kt

@@ -500,14 +500,6 @@ class NoteTypeFieldEditor : AnkiActivity() {
         initialize()
     }
 
-    /**
-     * Toggle the "Remember last input" setting AKA the "Sticky" setting
-     */
-    private fun toggleStickyField() {
-        val field = noteFields[currentPos]
-        field.sticky = !field.sticky
-    }
-
     override fun onOptionsItemSelected(item: MenuItem): Boolean =
         when (item.itemId) {
             R.id.action_add_new_model -> {
@@ -527,7 +519,6 @@ class NoteTypeFieldEditor : AnkiActivity() {
             NoteTypeFieldEditorContextMenuAction.Reposition -> repositionFieldDialog()
             NoteTypeFieldEditorContextMenuAction.Delete -> deleteFieldDialog()
             NoteTypeFieldEditorContextMenuAction.Rename -> renameFieldDialog()
-            NoteTypeFieldEditorContextMenuAction.ToggleSticky -> toggleStickyField()
             NoteTypeFieldEditorContextMenuAction.AddLanguageHint -> localeHintDialog()
         }
     }

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/NoteTypeFieldEditorContextMenu.kt

@@ -41,8 +41,7 @@ class NoteTypeFieldEditorContextMenu : AnalyticsDialogFragment() {
         Sort(1, R.string.model_field_editor_sort_field),
         Rename(2, R.string.model_field_editor_rename),
         Delete(3, R.string.model_field_editor_delete),
-        ToggleSticky(4, R.string.model_field_editor_toggle_sticky),
-        AddLanguageHint(5, R.string.model_field_editor_language_hint),
+        AddLanguageHint(4, R.string.model_field_editor_language_hint),
     }
 
     companion object {

AnkiDroid/src/main/res/values/17-model-manager.xml

@@ -46,7 +46,6 @@
     <string name="model_field_editor_rename">Rename field</string>
     <string name="model_field_editor_language_hint">Set keyboard language hint</string>
     <string name="model_field_editor_reposition_menu">Reposition field</string>
-    <string name="model_field_editor_toggle_sticky">Remember last input when adding</string>
     <string name="model_field_editor_changing">Updating fields</string>
     <string name="model_field_editor_sort_field">Sort by this field</string>