Skip to content

Commit 0722d0b

Browse files
committed
fix(api): correct permission enforcement for local API usage
(cherry picked from commit 35e36f5)
1 parent d4bd162 commit 0722d0b

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/provider/CardContentProvider.kt

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -196,14 +196,17 @@ class CardContentProvider : ContentProvider() {
196196
}
197197
}
198198

199-
/** Only enforce permissions for queries and inserts on Android M and above, or if its a 'rogue client' */
200-
private fun shouldEnforceQueryOrInsertSecurity(): Boolean = knownRogueClient()
199+
/**
200+
* Enforce permissions for queries and inserts on Android M and above.
201+
* @see knownRogueClient
202+
*/
203+
private fun shouldEnforceQueryOrInsertSecurity(): Boolean = true
201204

202-
/** Enforce permissions for all updates on Android M and above. Otherwise block depending on URI and client app */
203-
private fun shouldEnforceUpdateSecurity(uri: Uri): Boolean {
204-
val whitelist = listOf(NOTES_ID_CARDS_ORD, NOTE_TYPES_ID, NOTE_TYPES_ID_TEMPLATES_ID, SCHEDULE, DECK_SELECTED)
205-
return !whitelist.contains(sUriMatcher.match(uri)) || knownRogueClient()
206-
}
205+
/**
206+
* Enforce permissions for all updates on Android M and above.
207+
* @see knownRogueClient
208+
*/
209+
private fun shouldEnforceUpdateSecurity(uri: Uri): Boolean = true
207210

208211
override fun query(
209212
uri: Uri,

0 commit comments

Comments
 (0)