fix(automatic-answer): disable by default

Now requires a menu item/keyboard shortcut/gesture to enable

Issue 17701

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/reviewer/AutomaticAnswer.kt

@@ -77,7 +77,7 @@ class AutomaticAnswer(
      *
      * Ensures that auto answer does not occur if the reviewer is minimised
      */
-    var isDisabled: Boolean = false
+    var isDisabled: Boolean = true
         get() = field || activityIsPaused
         private set
 

AnkiDroid/src/test/java/com/ichi2/anki/AbstractFlashcardViewerTest.kt

@@ -273,6 +273,7 @@ class AbstractFlashcardViewerTest : RobolectricTest() {
     fun automaticAnswerDisabledProperty() {
         val controller = getViewerController(addCard = true, startedWithShortcut = false)
         val viewer = controller.get()
+        viewer.automaticAnswer.enable()
         assertThat("not disabled initially", viewer.automaticAnswer.isDisabled, equalTo(false))
         controller.pause()
         assertThat("disabled after pause", viewer.automaticAnswer.isDisabled, equalTo(true))
@@ -287,6 +288,7 @@ class AbstractFlashcardViewerTest : RobolectricTest() {
             val viewer = controller.get()
             viewer.automaticAnswer = AutomaticAnswer(viewer, AutomaticAnswerSettings(AutomaticAnswerAction.BURY_CARD, 5.0, 5.0))
             viewer.lifecycle.addObserver(viewer.automaticAnswer)
+            viewer.automaticAnswer.enable()
             viewer.executeCommand(ViewerCommand.SHOW_ANSWER)
             assertThat("messages after flipping card", viewer.hasAutomaticAnswerQueued(), equalTo(true))
             controller.pause()

AnkiDroid/src/test/java/com/ichi2/anki/reviewer/AutomaticAnswerTest.kt

@@ -34,6 +34,7 @@ class AutomaticAnswerTest : JvmTest() {
     @Test
     fun disableWorks() {
         val answer = validAnswer(automaticallyAnsweredMock())
+        answer.enable()
 
         answer.delayedShowQuestion(0)
         answer.delayedShowAnswer(0)
@@ -70,12 +71,12 @@ class AutomaticAnswerTest : JvmTest() {
 
     @Test
     fun testEnableDisable() {
-        val answer = validAnswer(automaticallyAnsweredMock())
-        assertThat("answer should be enabled", answer.isDisabled, equalTo(false))
-        answer.disable()
+        val answer = validAnswer(automaticallyAnsweredMock(), enable = false)
         assertThat("answer should be disabled", answer.isDisabled, equalTo(true))
         answer.enable()
         assertThat("answer should be enabled", answer.isDisabled, equalTo(false))
+        answer.disable()
+        assertThat("answer should be disabled", answer.isDisabled, equalTo(true))
     }
 
     /** Ensures [disableStopsImmediateCallAnswer] can fail */
@@ -119,7 +120,10 @@ class AutomaticAnswerTest : JvmTest() {
         runUiThreadTasksIncludingDelayedTasks()
     }
 
-    private fun validAnswer(automaticallyAnswered: AutomaticallyAnswered? = null): AutomaticAnswer {
+    private fun validAnswer(
+        automaticallyAnswered: AutomaticallyAnswered? = null,
+        enable: Boolean = true,
+    ): AutomaticAnswer {
         var automaticAnswerHandle: AutomaticAnswer? = null
 
         val automaticAnswerHandler =
@@ -143,6 +147,9 @@ class AutomaticAnswerTest : JvmTest() {
                 ),
         ).apply {
             automaticAnswerHandle = this
+            if (enable) {
+                this.enable()
+            }
         }
     }