Skip to content

Commit 147bced

Browse files
committed
style(new reviewer): make buttons 'Elevated'
the rest of the reviewer UI is elevated (WebView, type answer container) also, it makes more evident that it is a button and I think that it looks nicer, specially on big screens
1 parent 023761b commit 147bced

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

AnkiDroid/src/main/res/layout-sw600dp/reviewer2.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,13 @@
200200

201201
<com.google.android.material.button.MaterialButton
202202
android:id="@+id/show_answer"
203+
style="@style/AnswerButton"
203204
android:layout_width="match_parent"
204205
android:layout_height="match_parent"
205206
android:text="@string/show_answer"
206207
android:textSize="@dimen/reviewer_answer_button_textSize"
207208
app:cornerRadius="12dp"
209+
android:textColor="@color/white"
208210
android:backgroundTint="?showAnswerButtonBackground"
209211
tools:visibility="invisible"
210212
/>

AnkiDroid/src/main/res/layout/reviewer2.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,11 +202,13 @@
202202

203203
<com.google.android.material.button.MaterialButton
204204
android:id="@+id/show_answer"
205+
style="@style/AnswerButton"
205206
android:layout_width="match_parent"
206207
android:layout_height="match_parent"
207208
android:text="@string/show_answer"
208209
android:textSize="@dimen/reviewer_answer_button_textSize"
209210
app:cornerRadius="12dp"
211+
android:textColor="@color/white"
210212
android:backgroundTint="?showAnswerButtonBackground"
211213
tools:visibility="invisible"
212214
/>

AnkiDroid/src/main/res/values/dimens.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535

3636
<dimen name="reviewer_side_margin">8dp</dimen>
3737
<dimen name="answer_button_margin_horizontal">3dp</dimen>
38+
<dimen name="study_screen_elevation">0.8dp</dimen>
39+
<dimen name="answer_button_corner_radius">12dp</dimen>
3840
<dimen name="reviewer_answer_button_textSize">14sp</dimen>
3941
<dimen name="reviewer_mark_flag">18dp</dimen>
4042
</resources>

AnkiDroid/src/main/res/values/styles.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,11 @@
2929
<item name="android:popupBackground">@drawable/bg_popup</item>
3030
</style>
3131

32-
<style name="AnswerButton" parent="Widget.Material3.Button">
32+
<style name="AnswerButton" parent="Widget.Material3.Button.ElevatedButton">
3333
<item name="android:padding">0dp</item>
34-
<item name="cornerRadius">12dp</item>
34+
<item name="cornerRadius">@dimen/answer_button_corner_radius</item>
3535
<item name="android:textSize">@dimen/reviewer_answer_button_textSize</item>
36+
<item name="elevation">@dimen/study_screen_elevation</item>
3637
</style>
3738

3839
<!-- Material Design-style persistent footer button -->
@@ -239,7 +240,7 @@
239240
</style>
240241

241242
<style name="CardView.ViewerStyle" parent="Widget.Material3.CardView.Elevated">
242-
<item name="android:elevation">0.8dp</item>
243+
<item name="android:elevation">@dimen/study_screen_elevation</item>
243244
</style>
244245

245246
<style name="Theme.AppCompat.Transparent.NoActionBar" parent="Theme.AppCompat.Light.DarkActionBar">

0 commit comments

Comments
 (0)