Skip to content

Commit 14b7351

Browse files
BrayanDSOmikehardy
authored andcommitted
refactor: remove TagsArrayAdapter resources param
not necessary for a adapter
1 parent d5ab5a5 commit 14b7351

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsArrayAdapter.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package com.ichi2.anki.dialogs.tags
1717

18-
import android.content.res.Resources
1918
import android.view.LayoutInflater
2019
import android.view.View
2120
import android.view.ViewGroup
@@ -45,7 +44,6 @@ import java.util.TreeSet
4544
*/
4645
class TagsArrayAdapter(
4746
private val tags: TagsList,
48-
private val resources: Resources,
4947
) : RecyclerView.Adapter<TagsArrayAdapter.ViewHolder>(),
5048
Filterable {
5149
class ViewHolder(
@@ -302,7 +300,7 @@ class TagsArrayAdapter(
302300
// do not add padding if there is no visible nested tag
303301
holder.expandButton.visibility = View.GONE
304302
}
305-
holder.expandButton.contentDescription = resources.getString(R.string.expand_tag, holder.node.tag.replace("::", " "))
303+
holder.expandButton.contentDescription = holder.itemView.context.getString(R.string.expand_tag, holder.node.tag.replace("::", " "))
306304

307305
holder.textView.text = TagsUtil.getTagParts(holder.node.tag).last()
308306

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/tags/TagsDialog.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ class TagsDialog : AnalyticsDialogFragment {
173173
tagsListRecyclerView?.requestFocus()
174174
val tagsListLayout: RecyclerView.LayoutManager = LinearLayoutManager(activity)
175175
tagsListRecyclerView?.layoutManager = tagsListLayout
176-
tagsArrayAdapter = TagsArrayAdapter(tags!!, resources)
176+
tagsArrayAdapter = TagsArrayAdapter(tags!!)
177177
tagsListRecyclerView?.adapter = tagsArrayAdapter
178178
noTagsTextView = tagsDialogView.findViewById(R.id.tags_dialog_no_tags_textview)
179179
val noTagsTextView: TextView? = noTagsTextView

0 commit comments

Comments
 (0)