fix(reviewer): allow disabling 'voice playback'

david-allison · mikehardy · commit 15cadc2cc91c · 2025-06-11T19:48:10.000Z
If the menu item was removed, but a keyboard shortcut was pressed
there was no way to disable the control

Fixes 18477
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.kt b/AnkiDroid/src/main/java/com/ichi2/anki/Reviewer.kt
@@ -867,6 +867,8 @@ open class Reviewer :
         val voicePlaybackIcon = menu.findItem(R.id.action_toggle_mic_tool_bar)
         if (isMicToolBarVisible) {
             voicePlaybackIcon.setTitle(R.string.menu_disable_voice_playback)
+            // #18477: always show 'disable', even if 'enable' was invisible
+            voicePlaybackIcon.isVisible = true
         } else {
             voicePlaybackIcon.setTitle(R.string.menu_enable_voice_playback)
         }

Original file line number	Diff line number	Diff line change
`@@ -867,6 +867,8 @@ open class Reviewer :`
`867`	`867`	`val voicePlaybackIcon = menu.findItem(R.id.action_toggle_mic_tool_bar)`
`868`	`868`	`if (isMicToolBarVisible) {`
`869`	`869`	`voicePlaybackIcon.setTitle(R.string.menu_disable_voice_playback)`
	`870`	`+ // #18477: always show 'disable', even if 'enable' was invisible`
	`871`	`+ voicePlaybackIcon.isVisible = true`
`870`	`872`	`} else {`
`871`	`873`	`voicePlaybackIcon.setTitle(R.string.menu_enable_voice_playback)`
`872`	`874`	`}`