Skip to content

Commit 1dc17e5

Browse files
Haz3-joltdavid-allison
authored andcommitted
Added test for OnDeckSelected.
1 parent d4bea93 commit 1dc17e5

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ open class CardBrowser :
120120
ChangeManager.Subscriber,
121121
ExportDialogsFactoryProvider {
122122

123-
@NeedsTest("15448: double-selecting deck does nothing")
124123
override fun onDeckSelected(deck: SelectableDeck?) {
125124
deck?.let {
126125
launchCatchingTask { selectDeckAndSave(deck.deckId) }

AnkiDroid/src/test/java/com/ichi2/anki/CardBrowserTest.kt

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ import com.ichi2.anki.browser.CardBrowserColumn
3434
import com.ichi2.anki.browser.CardBrowserViewModel
3535
import com.ichi2.anki.browser.CardBrowserViewModel.Companion.DISPLAY_COLUMN_1_KEY
3636
import com.ichi2.anki.browser.CardBrowserViewModel.Companion.DISPLAY_COLUMN_2_KEY
37+
import com.ichi2.anki.dialogs.DeckSelectionDialog
3738
import com.ichi2.anki.model.CardsOrNotes.*
3839
import com.ichi2.anki.model.SortType
3940
import com.ichi2.anki.scheduling.ForgetCardsViewModel
@@ -136,6 +137,26 @@ class CardBrowserTest : RobolectricTest() {
136137
assertThat(browser.isShowingSelectAll, equalTo(true))
137138
}
138139

140+
@Test
141+
fun testOnDeckSelected() = runBlocking {
142+
// Arrange
143+
val deckId = 123L
144+
val selectableDeck = DeckSelectionDialog.SelectableDeck(deckId, "Test Deck")
145+
val cardBrowser = getBrowserWithNotes(1)
146+
147+
// Act
148+
cardBrowser.onDeckSelected(selectableDeck)
149+
150+
// Assert
151+
assertEquals(deckId, cardBrowser.lastDeckId)
152+
153+
// Act again: select the same deck
154+
cardBrowser.onDeckSelected(selectableDeck)
155+
156+
// Assert again: the deck selection should not change
157+
assertEquals(deckId, cardBrowser.lastDeckId)
158+
}
159+
139160
@Test
140161
@Flaky(os = OS.WINDOWS, "Index 0 out of bounds for length 0")
141162
fun browserIsInMultiSelectModeWhenSelectingOne() {

0 commit comments

Comments
 (0)