Skip to content

Commit 267f2a5

Browse files
david-allisonlukstbit
authored andcommitted
improvement(card-browser): Show full deck name in chip
Previously the name was truncated, and only the subdeck was shown It was previously unusable if the deck name was too long
1 parent 46bc823 commit 267f2a5

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ class CardBrowserFragment :
451451
}
452452

453453
fun onDeckChanged(deck: SelectableDeck?) {
454-
deckChip?.text = deck?.getDisplayName(requireContext())
454+
deckChip?.text = deck?.getFullDisplayName(requireContext())
455455
}
456456

457457
activityViewModel.flowOfIsTruncated.launchCollectionInLifecycleScope(::onIsTruncatedChanged)

AnkiDroid/src/main/java/com/ichi2/anki/model/SelectableDeck.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,15 @@ sealed class SelectableDeck : Parcelable {
5555
is AllDecks -> context.getString(R.string.card_browser_all_decks)
5656
}
5757

58+
/**
59+
* The full name of the deck
60+
*/
61+
fun getFullDisplayName(context: Context) =
62+
when (this) {
63+
is Deck -> name
64+
is AllDecks -> context.getString(R.string.card_browser_all_decks)
65+
}
66+
5867
override fun toString() =
5968
when (this) {
6069
is Deck -> name

AnkiDroid/src/main/res/layout/cardbrowser_searchview.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@
103103
android:layout_width="wrap_content"
104104
android:layout_height="wrap_content"
105105
app:chipIcon="@drawable/ic_cards_star"
106-
107-
android:maxWidth="120dp"
108106
android:maxLines="1"
109107
android:ellipsize="middle"
110108

0 commit comments

Comments
 (0)