Skip to content

Commit 28168e8

Browse files
Label of deck deletion icon becomes "Delete deck"
It used to be "Deleting deck…" which was not appropriate for a button.
1 parent a19cb96 commit 28168e8

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,6 +1205,7 @@ open class DeckPicker :
12051205
}
12061206
R.id.action_deck_delete -> {
12071207
launchCatchingTask {
1208+
// The progress message is actually "Deleting deck" and not "delete deck" as indicated by the resource name.
12081209
withProgress(resources.getString(R.string.delete_deck)) {
12091210
viewModel.deleteSelectedDeck().join()
12101211
}
@@ -2430,6 +2431,7 @@ open class DeckPicker :
24302431
*/
24312432
fun deleteDeck(did: DeckId) =
24322433
launchCatchingTask {
2434+
// The progress message is actually "Deleting deck" and not "delete deck" as indicated by the resource name.
24332435
withProgress(resources.getString(R.string.delete_deck)) {
24342436
viewModel.deleteDeck(did).join()
24352437
}

AnkiDroid/src/main/res/menu-xlarge/deck_picker.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<item
2323
android:id="@+id/action_deck_delete"
2424
android:icon="@drawable/ic_delete_white"
25-
android:title="@string/delete_deck"
25+
android:title="@string/contextmenu_deckpicker_delete_deck"
2626
app:showAsAction="always"/>
2727
<item
2828
android:id="@+id/action_undo"

AnkiDroid/src/main/res/values/02-strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
<string name="check_media" maxLength="28">Check media</string>
115115
<string name="empty_cards" maxLength="28">Empty cards</string>
116116
<string name="unknown_type_field_warning">Type answer: unknown field %s</string>
117-
<string name="delete_deck">Deleting deck…</string>
117+
<string name="delete_deck" comment="Message on a progress bar starting a deck is being deleted.">Deleting deck…</string>
118118

119119
<string name="info_rate">Rate AnkiDroid</string>
120120
<string name="import_title">Importing</string>

0 commit comments

Comments
 (0)