fix(card-browser): drop configChanges to fix rotation

Bug: The app bar menu items and fonts were not updated

As we now use a ViewModel, the Card Browser state can survive
 rotation changes, so let the recreation process handle it

Part of issue 8589
Fixes 19289

Author: david-allison

AnkiDroid/src/main/AndroidManifest.xml

@@ -325,7 +325,6 @@
             android:label="@string/card_browser"
             android:theme="@style/Theme_Dark.Launcher"
             android:exported="true"
-            android:configChanges="keyboardHidden|orientation|screenSize"
             android:parentActivityName=".DeckPicker"
             >
             <intent-filter android:label="@string/card_browser">

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserFragment.kt

@@ -656,6 +656,7 @@ class CardBrowserFragment :
             }
         }
 
+    // TODO: This dialog should survive activity recreation
     fun showChangeDeckDialog() =
         launchCatchingTask {
             if (!activityViewModel.hasSelectedAnyRows()) {

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/GradeNowDialog.kt

@@ -51,6 +51,7 @@ import timber.log.Timber
  *
  * @see net.ankiweb.rsdroid.Backend.gradeNow
  */
+// TODO: handle rotation, via a DialogFragment with IdsFile handling or Fragment Result API
 @NeedsTest("UI test for this dialog")
 @NeedsTest("Menu only displayed if cards selected")
 @NeedsTest("Suspended card handling")

AnkiDroid/src/main/java/com/ichi2/anki/scheduling/SetDueDateDialog.kt

@@ -126,7 +126,7 @@ class SetDueDateDialog : DialogFragment() {
         // (the window size & position was incorrectly calculated)
 
         // There was a minor bug in Reviewer (timer is reset), which meant that
-        // generally we could not remove the configChanges, we probably can with the CardBrowser
+        // generally we could not remove the configChanges
         // For now, only recreate the activity if this dialog is open
         if (getScreenRotation() != initialRotation) {
             Timber.d("recreating activity: orientation changed with 'Set due date' open")