Text share to AnkiDroid should launch note editor

Author: ShridharGoel

AnkiDroid/src/main/java/com/ichi2/anki/IntentHandler.kt

@@ -31,6 +31,7 @@ import com.ichi2.anki.common.utils.trimToLength
 import com.ichi2.anki.dialogs.DialogHandler.Companion.storeMessage
 import com.ichi2.anki.dialogs.DialogHandlerMessage
 import com.ichi2.anki.libanki.DeckId
+import com.ichi2.anki.noteeditor.NoteEditorLauncher
 import com.ichi2.anki.preferences.sharedPrefs
 import com.ichi2.anki.servicelayer.ScopedStorageService
 import com.ichi2.anki.services.ReminderService
@@ -94,6 +95,11 @@ class IntentHandler : AbstractIntentHandler() {
                     handleImageImport(intent)
                     finish()
                 }
+            LaunchType.SHARED_TEXT ->
+                runIfStoragePermissions {
+                    handleSharedText(intent)
+                    finish()
+                }
             LaunchType.SYNC -> runIfStoragePermissions { handleSyncIntent(reloadIntent, action) }
             LaunchType.REVIEW -> runIfStoragePermissions { handleReviewIntent(reloadIntent, intent) }
             LaunchType.DEFAULT_START_APP_IF_NEW -> {
@@ -261,6 +267,19 @@ class IntentHandler : AbstractIntentHandler() {
             .startActivities()
     }
 
+    private fun handleSharedText(data: Intent) {
+        Timber.i("Handling shared text content for note creation")
+        val noteEditorIntent =
+            if (data.extras != null) {
+                NoteEditorLauncher.PassArguments(data.extras!!).toIntent(this, data.action)
+            } else {
+                // Fallback if no extras, though this shouldn't happen for ACTION_SEND
+                NoteEditorLauncher.AddNote().toIntent(this)
+            }
+        noteEditorIntent.setDataAndType(data.data, data.type)
+        startActivity(noteEditorIntent)
+    }
+
     private fun deleteDownloadedDeck(sharedDeckUri: Uri?) {
         if (sharedDeckUri == null) {
             Timber.i("onCreate: downloaded a shared deck but uri was null when trying to delete its file")
@@ -304,6 +323,9 @@ class IntentHandler : AbstractIntentHandler() {
         /** image */
         IMAGE_IMPORT,
 
+        /** shared text content */
+        SHARED_TEXT,
+
         SYNC,
         REVIEW,
         COPY_DEBUG_INFO,
@@ -349,6 +371,9 @@ class IntentHandler : AbstractIntentHandler() {
                 val mimeType = intent.resolveMimeType()
                 when {
                     mimeType?.startsWith("image/") == true -> LaunchType.IMAGE_IMPORT
+                    action == Intent.ACTION_SEND &&
+                        intent.hasExtra(Intent.EXTRA_TEXT) &&
+                        !intent.hasExtra(Intent.EXTRA_STREAM) -> LaunchType.SHARED_TEXT
                     textMimeTypes.contains(mimeType) -> LaunchType.TEXT_IMPORT
                     else -> LaunchType.FILE_IMPORT
                 }
@@ -389,6 +414,7 @@ class IntentHandler : AbstractIntentHandler() {
                 LaunchType.FILE_IMPORT,
                 LaunchType.TEXT_IMPORT,
                 LaunchType.IMAGE_IMPORT,
+                LaunchType.SHARED_TEXT,
                 -> true
                 LaunchType.COPY_DEBUG_INFO -> false
             }

AnkiDroid/src/test/java/com/ichi2/anki/IntentHandlerTest.kt

@@ -99,11 +99,42 @@ class IntentHandlerTest {
         testIntentType("content://valid", "text/csv", LaunchType.TEXT_IMPORT)
         testIntentType("content://valid", "text/tsv", LaunchType.TEXT_IMPORT)
 
-        // Test for ACTION_SEND
-        testIntentType("content://valid", "text/tab-separated-values", LaunchType.TEXT_IMPORT, Intent.ACTION_SEND)
-        testIntentType("content://valid", "text/comma-separated-values", LaunchType.TEXT_IMPORT, Intent.ACTION_SEND)
-        testIntentType("content://valid", "text/csv", LaunchType.TEXT_IMPORT, Intent.ACTION_SEND)
-        testIntentType("content://valid", "text/tsv", LaunchType.TEXT_IMPORT, Intent.ACTION_SEND)
+        // Test for ACTION_SEND with file streams (should still be TEXT_IMPORT)
+        testIntentTypeWithStream("content://valid", "text/tab-separated-values", LaunchType.TEXT_IMPORT)
+        testIntentTypeWithStream("content://valid", "text/comma-separated-values", LaunchType.TEXT_IMPORT)
+        testIntentTypeWithStream("content://valid", "text/csv", LaunchType.TEXT_IMPORT)
+        testIntentTypeWithStream("content://valid", "text/tsv", LaunchType.TEXT_IMPORT)
+    }
+
+    @Test
+    fun sharedTextIntentStartsApp() {
+        // Test that sharing plain text content (not files) opens the note editor
+        // instead of attempting CSV import
+        val intent =
+            Intent(Intent.ACTION_SEND).apply {
+                type = "text/plain"
+                putExtra(Intent.EXTRA_TEXT, "Some shared text content")
+            }
+
+        val expected = getLaunchType(intent)
+
+        assertThat(expected, equalTo(LaunchType.SHARED_TEXT))
+    }
+
+    @Test
+    fun sharePlainTextDoesNotTriggerCsvImport() {
+        val intent =
+            Intent(Intent.ACTION_SEND).apply {
+                type = "text/plain"
+                putExtra(Intent.EXTRA_TEXT, "This is some shared text that should create a note")
+                // No EXTRA_STREAM means this is shared text content, not a file
+            }
+
+        val launchType = getLaunchType(intent)
+
+        // Should NOT be TEXT_IMPORT (which would trigger CSV import and fail)
+        // Should be SHARED_TEXT (which launches note editor directly)
+        assertThat(launchType, equalTo(LaunchType.SHARED_TEXT))
     }
 
     private fun testIntentType(
@@ -128,4 +159,18 @@ class IntentHandlerTest {
 
         assertThat(expected, equalTo(LaunchType.DEFAULT_START_APP_IF_NEW))
     }
+
+    private fun testIntentTypeWithStream(
+        data: String,
+        type: String,
+        expected: LaunchType,
+    ) {
+        val intent =
+            Intent(Intent.ACTION_SEND).apply {
+                putExtra(Intent.EXTRA_STREAM, data.toUri())
+                this.type = type
+            }
+        val actual = getLaunchType(intent)
+        assertThat(actual, equalTo(expected))
+    }
 }