Skip to content

Commit 54856f3

Browse files
snowtimeglassdavid-allison
authored andcommitted
fix: custom study card state menu overflow
`minHeight` is no longer enforced, so use `paddingVertical` if the height is over `minHeight` 14dp: by visual inspection, likely only correct for default text sizes Fixes: 18953 Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>
1 parent b031417 commit 54856f3

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/customstudy/CustomStudyDialog.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ class CustomStudyDialog : AnalyticsDialogFragment() {
308308
android.R.layout.simple_spinner_item,
309309
CustomStudyCardState.entries.map { it.labelProducer() },
310310
).apply {
311-
setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item)
311+
setDropDownViewResource(R.layout.multiline_spinner_item)
312312
}
313313
}
314314
val editText =

AnkiDroid/src/main/res/layout/multiline_spinner_item.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
style="?android:attr/spinnerDropDownItemStyle"
2020
android:singleLine="false"
2121
android:maxLines="5"
22+
android:paddingVertical="14dp"
2223
android:layout_width="match_parent"
2324
android:layout_height="wrap_content"
2425
android:minHeight="?attr/dropdownListPreferredItemHeight"

0 commit comments

Comments
 (0)