chore: convert BrowserOptionsDialog to ViewBinding

Issue 11116

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/BrowserOptionsDialog.kt

@@ -19,14 +19,6 @@ package com.ichi2.anki.dialogs
 import android.app.Dialog
 import android.content.DialogInterface
 import android.os.Bundle
-import android.view.View
-import android.widget.Button
-import android.widget.CheckBox
-import android.widget.LinearLayout
-import android.widget.RadioButton
-import android.widget.RadioGroup
-import android.widget.TextView
-import androidx.annotation.IdRes
 import androidx.appcompat.app.AppCompatDialogFragment
 import androidx.core.os.bundleOf
 import androidx.fragment.app.activityViewModels
@@ -35,20 +27,19 @@ import com.ichi2.anki.CollectionManager.TR
 import com.ichi2.anki.R
 import com.ichi2.anki.browser.BrowserColumnSelectionFragment
 import com.ichi2.anki.browser.CardBrowserViewModel
+import com.ichi2.anki.databinding.BrowserOptionsDialogBinding
 import com.ichi2.anki.model.CardsOrNotes
 import timber.log.Timber
 
-class BrowserOptionsDialog : AppCompatDialogFragment() {
-    private lateinit var dialogView: View
-
+class BrowserOptionsDialog : AppCompatDialogFragment(R.layout.browser_options_dialog) {
     private val viewModel: CardBrowserViewModel by activityViewModels()
 
+    private lateinit var binding: BrowserOptionsDialogBinding
+
     /** The unsaved value of [CardsOrNotes] */
     private val dialogCardsOrNotes: CardsOrNotes
         get() {
-            @IdRes val selectedButtonId =
-                dialogView.findViewById<RadioGroup>(R.id.select_browser_mode).checkedRadioButtonId
-            return when (selectedButtonId) {
+            return when (binding.selectBrowserMode.checkedRadioButtonId) {
                 R.id.select_cards_mode -> CardsOrNotes.CARDS
                 else -> CardsOrNotes.NOTES
             }
@@ -58,13 +49,13 @@ class BrowserOptionsDialog : AppCompatDialogFragment() {
         if (cardsOrNotes != dialogCardsOrNotes) {
             viewModel.setCardsOrNotes(dialogCardsOrNotes)
         }
-        val newTruncate = dialogView.findViewById<CheckBox>(R.id.truncate_checkbox).isChecked
+        val newTruncate = binding.truncateCheckBox.isChecked
 
         if (newTruncate != isTruncated) {
             viewModel.setTruncated(newTruncate)
         }
 
-        val newIgnoreAccent = dialogView.findViewById<CheckBox>(R.id.ignore_accents_checkbox).isChecked
+        val newIgnoreAccent = binding.ignoreAccentsCheckBox.isChecked
         if (newIgnoreAccent != viewModel.shouldIgnoreAccents) {
             viewModel.setIgnoreAccents(newIgnoreAccent)
         }
@@ -90,37 +81,36 @@ class BrowserOptionsDialog : AppCompatDialogFragment() {
     }
 
     override fun onCreateDialog(savedInstanceState: Bundle?): Dialog {
-        val layoutInflater = requireActivity().layoutInflater
-        dialogView = layoutInflater.inflate(R.layout.browser_options_dialog, null)
+        binding = BrowserOptionsDialogBinding.inflate(layoutInflater)
 
         if (cardsOrNotes == CardsOrNotes.CARDS) {
-            dialogView.findViewById<RadioButton>(R.id.select_cards_mode).isChecked = true
+            binding.selectCardsMode.isChecked = true
         } else {
-            dialogView.findViewById<RadioButton>(R.id.select_notes_mode).isChecked = true
+            binding.selectNotesMode.isChecked = true
         }
 
-        dialogView.findViewById<CheckBox>(R.id.truncate_checkbox).isChecked = isTruncated
+        binding.truncateCheckBox.isChecked = isTruncated
 
-        dialogView.findViewById<LinearLayout>(R.id.action_rename_flag).setOnClickListener {
+        binding.renameFlag.setOnClickListener {
             Timber.d("Rename flag clicked")
             val flagRenameDialog = FlagRenameDialog()
             flagRenameDialog.show(parentFragmentManager, "FlagRenameDialog")
             dismiss()
         }
 
-        dialogView.findViewById<Button>(R.id.manage_columns_button).setOnClickListener {
+        binding.manageColumnsButton.setOnClickListener {
             openColumnManager()
         }
 
-        dialogView.findViewById<CheckBox>(R.id.ignore_accents_checkbox).apply {
+        binding.ignoreAccentsCheckBox.apply {
             text = TR.preferencesIgnoreAccentsInSearch()
             isChecked = viewModel.shouldIgnoreAccents
         }
 
-        dialogView.findViewById<TextView>(R.id.browsing_text_view).text = TR.preferencesBrowsing()
+        binding.browsingTextView.text = TR.preferencesBrowsing()
 
         return MaterialAlertDialogBuilder(requireContext()).run {
-            this.setView(dialogView)
+            this.setView(binding.root)
             this.setTitle(getString(R.string.browser_options_dialog_heading))
             this.setNegativeButton(getString(R.string.dialog_cancel)) { _: DialogInterface, _: Int ->
                 dismiss()

AnkiDroid/src/main/res/layout/browser_options_dialog.xml

@@ -57,7 +57,7 @@
             android:layout_marginHorizontal="16dp" />
 
             <CheckBox
-            android:id="@+id/truncate_checkbox"
+            android:id="@+id/truncate_check_box"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
             android:text="@string/card_browser_truncate"
@@ -87,7 +87,7 @@
                 android:layout_marginHorizontal="16dp" />
 
             <CheckBox
-                android:id="@+id/ignore_accents_checkbox"
+                android:id="@+id/ignore_accents_check_box"
                 android:layout_width="match_parent"
                 android:layout_height="wrap_content"
                 android:layout_marginHorizontal="16dp"
@@ -137,7 +137,7 @@
             <LinearLayout
             android:gravity="center"
             android:minHeight="?attr/listPreferredItemHeightSmall"
-            android:id="@+id/action_rename_flag"
+            android:id="@+id/rename_flag"
             android:background="?attr/selectableItemBackground"
             android:layout_marginHorizontal="16dp"
             android:layout_width="match_parent"