Introduce ChangeNoteType Dialog

This dialog allows the bulk remapping of either
fields or card templates to a different note type

A full sync is required for this operation

inputs:
* output note type
* a map of fields (based on the output)
* a map of templates (based on the output)
* only if both input and output are non-cloze

Fixes 14134

Co-authored-by: David Allison <62114487+david-allison@users.noreply.github.com>

Author: Haz3-jolt

AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.kt

@@ -55,6 +55,7 @@ import com.ichi2.anki.browser.CardBrowserLaunchOptions
 import com.ichi2.anki.browser.CardBrowserViewModel
 import com.ichi2.anki.browser.CardBrowserViewModel.ChangeMultiSelectMode
 import com.ichi2.anki.browser.CardBrowserViewModel.ChangeMultiSelectMode.SingleSelectCause
+import com.ichi2.anki.browser.CardBrowserViewModel.ChangeNoteTypeResponse
 import com.ichi2.anki.browser.CardBrowserViewModel.SearchState
 import com.ichi2.anki.browser.CardBrowserViewModel.SearchState.Initializing
 import com.ichi2.anki.browser.CardBrowserViewModel.SearchState.Searching
@@ -67,6 +68,7 @@ import com.ichi2.anki.browser.toCardBrowserLaunchOptions
 import com.ichi2.anki.common.annotations.NeedsTest
 import com.ichi2.anki.common.utils.annotation.KotlinCleanup
 import com.ichi2.anki.databinding.ActivityCardBrowserBinding
+import com.ichi2.anki.dialogs.ChangeNoteTypeDialog
 import com.ichi2.anki.dialogs.DeckSelectionDialog.DeckSelectionListener
 import com.ichi2.anki.dialogs.DiscardChangesDialog
 import com.ichi2.anki.dialogs.GradeNowDialog
@@ -546,6 +548,19 @@ open class CardBrowser :
             showDialogFragment(dialog)
         }
 
+        fun onChangeNoteType(result: ChangeNoteTypeResponse) {
+            when (result) {
+                ChangeNoteTypeResponse.NoSelection -> {
+                    Timber.w("change note type: no selection")
+                }
+                ChangeNoteTypeResponse.MixedSelection -> showSnackbar(R.string.different_note_types_selected)
+                is ChangeNoteTypeResponse.ChangeNoteType -> {
+                    val dialog = ChangeNoteTypeDialog.newInstance(result.noteIds)
+                    showDialogFragment(dialog)
+                }
+            }
+        }
+
         viewModel.flowOfSearchQueryExpanded.launchCollectionInLifecycleScope(::onSearchQueryExpanded)
         viewModel.flowOfSelectedRows.launchCollectionInLifecycleScope(::onSelectedRowsChanged)
         viewModel.flowOfFilterQuery.launchCollectionInLifecycleScope(::onFilterQueryChanged)
@@ -555,6 +570,7 @@ open class CardBrowser :
         viewModel.flowOfSearchState.launchCollectionInLifecycleScope(::searchStateChanged)
         viewModel.cardSelectionEventFlow.launchCollectionInLifecycleScope(::onSelectedCardUpdated)
         viewModel.flowOfSaveSearchNamePrompt.launchCollectionInLifecycleScope(::onSaveSearchNamePrompt)
+        viewModel.flowOfChangeNoteType.launchCollectionInLifecycleScope(::onChangeNoteType)
     }
 
     fun isKeyboardVisible(view: View?): Boolean =
@@ -665,6 +681,13 @@ open class CardBrowser :
                     return true
                 }
             }
+            KeyEvent.KEYCODE_M -> {
+                if (event.isCtrlPressed && event.isShiftPressed) {
+                    Timber.i("Ctrl+Shift+M: Change Note Type")
+                    viewModel.requestChangeNoteType()
+                    return true
+                }
+            }
             KeyEvent.KEYCODE_Z -> {
                 if (event.isCtrlPressed) {
                     Timber.i("Ctrl+Z: Undo")
@@ -854,6 +877,7 @@ open class CardBrowser :
             isVisible = isFindReplaceEnabled
             title = TR.browsingFindAndReplace().toSentenceCase(this@CardBrowser, R.string.sentence_find_and_replace)
         }
+
         previewItem = menu.findItem(R.id.action_preview)
         onSelectionChanged()
         refreshMenuItems()
@@ -1016,6 +1040,11 @@ open class CardBrowser :
                 showSavedSearches()
                 return true
             }
+            R.id.action_change_note_type -> {
+                Timber.i("Menu: Change note type")
+                viewModel.requestChangeNoteType()
+                return true
+            }
             R.id.action_undo -> {
                 Timber.w("CardBrowser:: Undo pressed")
                 onUndo()

AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt

@@ -2495,7 +2495,7 @@ class OneWaySyncDialog(
 /**
  * [launchCatchingTask], showing a one-way sync dialog: [R.string.full_sync_confirmation]
  */
-private fun AnkiActivity.launchCatchingRequiringOneWaySync(block: suspend () -> Unit) =
+fun AnkiActivity.launchCatchingRequiringOneWaySync(block: suspend () -> Unit) =
     launchCatchingTask {
         try {
             block()

AnkiDroid/src/main/java/com/ichi2/anki/NoteEditorFragment.kt

@@ -1436,6 +1436,7 @@ class NoteEditorFragment :
      * Change the note type from oldNoteType to newNoteType, handling the case where a full sync will be required
      */
     @NeedsTest("test changing note type")
+    @Suppress("Deprecation") // Replace with ChangeNoteTypeDialog
     private fun changeNoteType(
         oldNotetype: NotetypeJson,
         newNotetype: NotetypeJson,

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserViewModel.kt

@@ -56,6 +56,7 @@ import com.ichi2.anki.libanki.Card
 import com.ichi2.anki.libanki.CardId
 import com.ichi2.anki.libanki.CardType
 import com.ichi2.anki.libanki.DeckId
+import com.ichi2.anki.libanki.NoteId
 import com.ichi2.anki.libanki.QueueType
 import com.ichi2.anki.libanki.QueueType.ManuallyBuried
 import com.ichi2.anki.libanki.QueueType.SiblingBuried
@@ -267,6 +268,8 @@ class CardBrowserViewModel(
      */
     val flowOfCardStateChanged = MutableSharedFlow<Unit>()
 
+    val flowOfChangeNoteType = MutableSharedFlow<ChangeNoteTypeResponse>()
+
     /**
      * Opens a prompt for the user to input a saved search name
      *
@@ -284,6 +287,19 @@ class CardBrowserViewModel(
 
     suspend fun queryAllSelectedNoteIds() = selectedRows.queryNoteIds(this.cardsOrNotes)
 
+    fun requestChangeNoteType() =
+        viewModelScope.launch {
+            val noteIds = queryAllSelectedNoteIds()
+            Timber.i("requestChangeNoteType: querying %d selected notes", noteIds.size)
+            flowOfChangeNoteType.emit(
+                when {
+                    noteIds.isEmpty() -> ChangeNoteTypeResponse.NoSelection
+                    !noteIds.allOfSameNoteType() -> ChangeNoteTypeResponse.MixedSelection
+                    else -> ChangeNoteTypeResponse.ChangeNoteType.from(noteIds)
+                },
+            )
+        }
+
     @VisibleForTesting
     internal suspend fun queryAllCardIds() = cards.queryCardIds()
 
@@ -1351,6 +1367,25 @@ class CardBrowserViewModel(
         SELECT_NONE,
     }
 
+    sealed interface ChangeNoteTypeResponse {
+        data object NoSelection : ChangeNoteTypeResponse
+
+        data object MixedSelection : ChangeNoteTypeResponse
+
+        @ConsistentCopyVisibility
+        data class ChangeNoteType private constructor(
+            val noteIds: List<NoteId>,
+        ) : ChangeNoteTypeResponse {
+            companion object {
+                @CheckResult
+                fun from(ids: List<NoteId>): ChangeNoteType {
+                    require(ids.isNotEmpty()) { "a non-empty list must be provided" }
+                    return ChangeNoteType(ids.distinct())
+                }
+            }
+        }
+    }
+
     /**
      * @param wasBuried `true` if all cards were buried, `false` if unburied
      * @param count the number of affected cards
@@ -1515,6 +1550,16 @@ sealed class RepositionCardsRequest {
 
 fun BrowserColumns.Column.getLabel(cardsOrNotes: CardsOrNotes): String = if (cardsOrNotes == CARDS) cardsModeLabel else notesModeLabel
 
+/**
+ * Whether the provided notes all have the same the same [note type][com.ichi2.anki.libanki.NoteTypeId]
+ */
+private suspend fun List<NoteId>.allOfSameNoteType(): Boolean {
+    val noteIds = this
+    return withCol { notetypes.nids(getNote(noteIds.first()).noteTypeId) }.toSet().let { set ->
+        noteIds.all { set.contains(it) }
+    }
+}
+
 @Parcelize
 data class ColumnHeading(
     val label: String,