chore: convert MultimediaImageFragment to ViewBinding

Issue 11116

Author: david-allison

AnkiDroid/src/main/java/com/ichi2/anki/multimedia/MultimediaImageFragment.kt

@@ -29,7 +29,6 @@ import android.os.Bundle
 import android.provider.MediaStore
 import android.view.View
 import android.webkit.WebView
-import android.widget.TextView
 import androidx.activity.result.contract.ActivityResultContracts
 import androidx.annotation.DrawableRes
 import androidx.appcompat.app.AlertDialog
@@ -40,11 +39,11 @@ import androidx.core.content.IntentCompat
 import androidx.core.os.BundleCompat
 import androidx.fragment.app.Fragment
 import androidx.lifecycle.lifecycleScope
-import com.google.android.material.button.MaterialButton
 import com.ichi2.anki.CollectionManager.TR
 import com.ichi2.anki.DrawingFragment
 import com.ichi2.anki.R
 import com.ichi2.anki.common.annotations.NeedsTest
+import com.ichi2.anki.databinding.FragmentMultimediaImageBinding
 import com.ichi2.anki.multimedia.MultimediaActivity.Companion.EXTRA_MEDIA_OPTIONS
 import com.ichi2.anki.multimedia.MultimediaActivity.Companion.MULTIMEDIA_RESULT
 import com.ichi2.anki.multimedia.MultimediaActivity.Companion.MULTIMEDIA_RESULT_FIELD_INDEX
@@ -67,6 +66,7 @@ import com.ichi2.utils.negativeButton
 import com.ichi2.utils.openInputStreamSafe
 import com.ichi2.utils.positiveButton
 import com.ichi2.utils.show
+import dev.androidbroadcast.vbpd.viewBinding
 import kotlinx.coroutines.flow.collectLatest
 import kotlinx.coroutines.launch
 import timber.log.Timber
@@ -80,11 +80,11 @@ private const val SVG_IMAGE = "image/svg+xml"
 
 @NeedsTest("Ensure correct option is executed i.e. gallery or camera")
 class MultimediaImageFragment : MultimediaFragment(R.layout.fragment_multimedia_image) {
+    private val binding by viewBinding(FragmentMultimediaImageBinding::bind)
+
     override val title: String
         get() = resources.getString(R.string.multimedia_editor_popup_image)
 
-    private lateinit var imageFileSize: TextView
-
     private lateinit var selectedImageOptions: ImageOptions
 
     /** Keeps track of the process in case `Don't keep activities` in turned on*/
@@ -282,7 +282,6 @@ class MultimediaImageFragment : MultimediaFragment(R.layout.fragment_multimedia_
     ) {
         super.onViewCreated(view, savedInstanceState)
         setupMenu(multimediaMenu)
-        imageFileSize = view.findViewById(R.id.image_size_textview)
 
         handleImageUri()
         setupDoneButton()
@@ -329,7 +328,7 @@ class MultimediaImageFragment : MultimediaFragment(R.layout.fragment_multimedia_
     }
 
     private fun setupDoneButton() {
-        view?.findViewById<MaterialButton>(R.id.action_done)?.setOnClickListener {
+        binding.actionDone.setOnClickListener {
             Timber.d("MultimediaImageFragment:: Done button pressed")
             if (viewModel.selectedMediaFileSize == 0L) {
                 Timber.d("Image length is not valid")
@@ -453,7 +452,7 @@ class MultimediaImageFragment : MultimediaFragment(R.layout.fragment_multimedia_
 
     private fun updateAndDisplayImageSize(file: File) {
         viewModel.selectedMediaFileSize = file.length()
-        imageFileSize.text = file.toHumanReadableSize()
+        binding.imageFileSize.text = file.toHumanReadableSize()
     }
 
     private fun showLargeFileCropDialog(length: Long) {
@@ -564,7 +563,7 @@ class MultimediaImageFragment : MultimediaFragment(R.layout.fragment_multimedia_
         val mimeType = context?.contentResolver?.getType(imageUri)
 
         // Get the WebView and set it visible
-        view?.findViewById<WebView>(R.id.multimedia_webview)?.apply {
+        binding.multimediaWebView.apply {
             visibility = View.VISIBLE
 
             // Load image based on its MIME type
@@ -655,7 +654,7 @@ class MultimediaImageFragment : MultimediaFragment(R.layout.fragment_multimedia_
             </html>
             """.trimIndent()
 
-        view?.findViewById<WebView>(R.id.multimedia_webview)?.loadDataWithBaseURL(null, errorHtml, "text/html", "UTF-8", null)
+        binding.multimediaWebView.loadDataWithBaseURL(null, errorHtml, "text/html", "UTF-8", null)
     }
 
     private fun requestCrop() {

AnkiDroid/src/main/res/layout/fragment_multimedia_image.xml

@@ -31,11 +31,11 @@
             android:layout_marginHorizontal="8dp"
             android:layout_height="0dp"
             app:layout_constraintTop_toTopOf="parent"
-            app:layout_constraintBottom_toTopOf="@id/image_size_textview"
+            app:layout_constraintBottom_toTopOf="@id/image_file_size"
             style="@style/CardView.ViewerStyle" >
 
             <WebView
-                android:id="@+id/multimedia_webview"
+                android:id="@+id/multimedia_web_view"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"/>
 
@@ -49,7 +49,7 @@
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintTop_toBottomOf="@id/imageview_container"
             android:gravity="center"
-            android:id="@+id/image_size_textview"
+            android:id="@+id/image_file_size"
             android:layout_width="match_parent"
             android:layout_height="wrap_content"/>
 
@@ -61,7 +61,7 @@
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintBottom_toBottomOf="parent"
-            app:layout_constraintTop_toBottomOf="@id/image_size_textview"
+            app:layout_constraintTop_toBottomOf="@id/image_file_size"
             android:text="@string/multimedia_editor_field_editing_done"/>
 
     </androidx.constraintlayout.widget.ConstraintLayout>