fix(deck-picker): clicking on an empty filtered deck

david-allison · mikehardy · commit a54fc26f1347 · 2025-06-23T07:23:58.000-05:00
Should not suggest that a user adds cards Fixes 18586 (cherry picked from commit 8f5ff9f)
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt b/AnkiDroid/src/main/java/com/ichi2/anki/DeckPicker.kt
@@ -2113,6 +2113,7 @@ open class DeckPicker :
     }
 
     @NeedsTest("14608: Ensure that the deck options refer to the selected deck")
+    @NeedsTest("18586: handle clicking on an empty filtered deck")
     private suspend fun handleDeckSelection(
         did: DeckId,
         selectionType: DeckSelectionType,
@@ -2152,7 +2153,7 @@ open class DeckPicker :
             return
         }
 
-        if (isDeckAndSubdeckEmpty(did)) {
+        if (!deck.filtered && isDeckAndSubdeckEmpty(did)) {
             showEmptyDeckSnackbar()
             updateUi()
         } else {

Original file line number	Diff line number	Diff line change
`@@ -2113,6 +2113,7 @@ open class DeckPicker :`
`2113`	`2113`	`}`
`2114`	`2114`
`2115`	`2115`	`@NeedsTest("14608: Ensure that the deck options refer to the selected deck")`
	`2116`	`+ @NeedsTest("18586: handle clicking on an empty filtered deck")`
`2116`	`2117`	`private suspend fun handleDeckSelection(`
`2117`	`2118`	`did: DeckId,`
`2118`	`2119`	`selectionType: DeckSelectionType,`
`@@ -2152,7 +2153,7 @@ open class DeckPicker :`
`2152`	`2153`	`return`
`2153`	`2154`	`}`
`2154`	`2155`
`2155`		`- if (isDeckAndSubdeckEmpty(did)) {`
	`2156`	`+ if (!deck.filtered && isDeckAndSubdeckEmpty(did)) {`
`2156`	`2157`	`showEmptyDeckSnackbar()`
`2157`	`2158`	`updateUi()`
`2158`	`2159`	`} else {`