Prefs for review reminder entry points

GSoC 2025: Review Reminders

- Used Prefs for review reminder entry points since it is more concise compared to requireContext().sharedPrefs()
- Renamed vague "enableReviewReminder" variables to be more clearer, ex. "newReviewRemindersAreEnabled"

Author: ericli3690

AnkiDroid/src/main/java/com/ichi2/anki/StudyOptionsFragment.kt

@@ -45,8 +45,8 @@ import com.ichi2.anki.dialogs.customstudy.CustomStudyDialog
 import com.ichi2.anki.libanki.Collection
 import com.ichi2.anki.libanki.Decks
 import com.ichi2.anki.observability.ChangeManager
-import com.ichi2.anki.preferences.sharedPrefs
 import com.ichi2.anki.reviewreminders.ScheduleReminders
+import com.ichi2.anki.settings.Prefs
 import com.ichi2.anki.snackbar.showSnackbar
 import com.ichi2.anki.ui.internationalization.toSentenceCase
 import com.ichi2.anki.utils.ext.description
@@ -365,8 +365,8 @@ class StudyOptionsFragment :
                 menu.findItem(R.id.action_custom_study).isVisible = false
             }
             // Use new review reminders system if enabled
-            val enableNewReviewReminders = requireContext().sharedPrefs().getBoolean(getString(R.string.pref_new_notifications), false)
-            menu.findItem(R.id.action_schedule_reminders).isVisible = enableNewReviewReminders
+            val newReviewRemindersAreEnabled = Prefs.getBoolean(R.string.pref_new_notifications, false)
+            menu.findItem(R.id.action_schedule_reminders).isVisible = newReviewRemindersAreEnabled
             // Switch on or off unbury depending on if there are cards to unbury
             menu.findItem(R.id.action_unbury).isVisible = col != null && col!!.sched.haveBuried()
         } catch (e: IllegalStateException) {

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DeckPickerContextMenu.kt

@@ -24,7 +24,7 @@ import androidx.core.os.bundleOf
 import com.ichi2.anki.R
 import com.ichi2.anki.analytics.AnalyticsDialogFragment
 import com.ichi2.anki.libanki.DeckId
-import com.ichi2.anki.preferences.sharedPrefs
+import com.ichi2.anki.settings.Prefs
 import com.ichi2.utils.title
 
 class DeckPickerContextMenu : AnalyticsDialogFragment() {
@@ -76,7 +76,7 @@ class DeckPickerContextMenu : AnalyticsDialogFragment() {
             if (!dyn) {
                 add(DeckPickerContextMenuOption.EDIT_DESCRIPTION)
             }
-            if (requireContext().sharedPrefs().getBoolean(getString(R.string.pref_new_notifications), false)) {
+            if (Prefs.getBoolean(R.string.pref_new_notifications, false)) {
                 add(DeckPickerContextMenuOption.SCHEDULE_REMINDERS)
             }
             add(DeckPickerContextMenuOption.DELETE_DECK)

AnkiDroid/src/main/java/com/ichi2/anki/preferences/HeaderFragment.kt

@@ -69,11 +69,11 @@ class HeaderFragment : SettingsFragment() {
                 true
             }
 
-        val reviewRemindersEnabled = requireContext().sharedPrefs().getBoolean(getString(R.string.pref_new_notifications), false)
+        val newReviewRemindersAreEnabled = Prefs.getBoolean(R.string.pref_new_notifications, false)
         requirePreference<HeaderPreference>(R.string.pref_review_reminders_screen_key)
-            .isVisible = reviewRemindersEnabled
+            .isVisible = newReviewRemindersAreEnabled
         requirePreference<HeaderPreference>(R.string.pref_notifications_screen_key)
-            .isVisible = !reviewRemindersEnabled
+            .isVisible = !newReviewRemindersAreEnabled
 
         configureSearchBar(
             requireActivity() as AppCompatActivity,
@@ -119,7 +119,8 @@ class HeaderFragment : SettingsFragment() {
                 index(R.xml.preferences_custom_sync_server)
                     .addBreadcrumb(R.string.pref_cat_sync)
 
-                if (activity.sharedPrefs().getBoolean(activity.getString(R.string.pref_new_notifications), false)) {
+                val newReviewRemindersAreEnabled = Prefs.getBoolean(R.string.pref_new_notifications, false)
+                if (newReviewRemindersAreEnabled) {
                     searchConfiguration
                         .indexItem()
                         .withKey(activity.getString(R.string.pref_review_reminders_screen_key))