Introduce ChangeNoteType Dialog

Author: Haz3-jolt

AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.kt

@@ -78,6 +78,7 @@ import com.ichi2.anki.dialogs.CardBrowserMySearchesDialog
 import com.ichi2.anki.dialogs.CardBrowserMySearchesDialog.Companion.newInstance
 import com.ichi2.anki.dialogs.CardBrowserMySearchesDialog.MySearchesDialogListener
 import com.ichi2.anki.dialogs.CardBrowserOrderDialog
+import com.ichi2.anki.dialogs.ChangeNoteTypeDialog
 import com.ichi2.anki.dialogs.CreateDeckDialog
 import com.ichi2.anki.dialogs.DeckSelectionDialog
 import com.ichi2.anki.dialogs.DeckSelectionDialog.Companion.newInstance
@@ -789,6 +790,11 @@ open class CardBrowser :
                     searchForMarkedNotes()
                     return true
                 }
+                if (event.isCtrlPressed && event.isShiftPressed) {
+                    Timber.i("Ctrl+Shift+M: Change Note Type")
+                    showChangeNoteType()
+                    return true
+                }
             }
             KeyEvent.KEYCODE_Z -> {
                 if (event.isCtrlPressed) {
@@ -1217,6 +1223,10 @@ open class CardBrowser :
                 toggleBury()
                 return true
             }
+            R.id.action_change_note_type -> {
+                showChangeNoteType()
+                return true
+            }
             R.id.action_change_deck -> {
                 showChangeDeckDialog()
                 return true
@@ -1468,6 +1478,21 @@ open class CardBrowser :
         }
     }
 
+    private fun getChangeNoteTypeDialog(noteIds: List<Long>): ChangeNoteTypeDialog = ChangeNoteTypeDialog.newInstance(noteIds)
+
+    private fun showChangeNoteType() =
+        launchCatchingTask {
+            if (!viewModel.canChangeNoteType() && viewModel.allSelectedNotesOfSameType()) {
+                Timber.i("All notes are not of the same type")
+                showSnackbar(R.string.different_note_types_selected)
+                return@launchCatchingTask
+            }
+            if (viewModel.canChangeNoteType()) {
+                val dialog = getChangeNoteTypeDialog(viewModel.queryAllSelectedNoteIds())
+                showDialogFragment(dialog)
+            }
+        }
+
     @KotlinCleanup("DeckSelectionListener is almost certainly a bug - deck!!")
     fun getChangeDeckDialog(selectableDecks: List<SelectableDeck>?): DeckSelectionDialog {
         val dialog =

AnkiDroid/src/main/java/com/ichi2/anki/browser/CardBrowserViewModel.kt

@@ -233,6 +233,28 @@ class CardBrowserViewModel(
 
     suspend fun queryAllSelectedNoteIds() = selectedRows.queryNoteIds(this.cardsOrNotes)
 
+    suspend fun allSelectedNotesOfSameType(): Boolean {
+        val selectedNoteIds = queryAllSelectedNoteIds()
+        if (selectedNoteIds.isEmpty()) {
+            return false
+        }
+        return withCol { notetypes.nids(getNote(selectedNoteIds.first()).noteTypeId) }.toSet().let { set ->
+            selectedNoteIds.all { set.contains(it) }
+        }
+    }
+
+    suspend fun canChangeNoteType(): Boolean {
+        if (!hasSelectedAnyRows()) {
+            Timber.i("Not showing Change Note Type - No Cards")
+            return false
+        }
+        if (!allSelectedNotesOfSameType()) {
+            Timber.i("All notes are not of the same type")
+            return false
+        }
+        return true
+    }
+
     @VisibleForTesting
     internal suspend fun queryAllCardIds() = cards.queryCardIds()