Change messages for discardChangesDialog

This changes the default dialog message in discardChangesDialog and the
dialog messages on specific pages to be more intuitive and closer to the
desktop experience.

Author: Alex7D3

AnkiDroid/src/main/java/com/ichi2/anki/NoteEditorFragment.kt

@@ -1630,7 +1630,10 @@ class NoteEditorFragment :
     }
 
     private fun showDiscardChangesDialog() {
-        DiscardChangesDialog.showDialog(requireContext()) {
+        DiscardChangesDialog.showDialog(
+            requireContext(),
+            message = if (addNote) TR.addingDiscardCurrentInput() else TR.cardTemplatesDiscardChanges(),
+        ) {
             Timber.i("NoteEditor:: OK button pressed to confirm discard changes")
             closeNoteEditor()
         }

AnkiDroid/src/main/java/com/ichi2/anki/dialogs/DiscardChangesDialog.kt

@@ -33,7 +33,7 @@ object DiscardChangesDialog {
         positiveButtonText: String = context.getString(R.string.discard),
         negativeButtonText: String = CollectionManager.TR.addingKeepEditing(),
         neutralButtonText: String? = null,
-        message: String = CollectionManager.TR.addingDiscardCurrentInput(),
+        message: String = CollectionManager.TR.cardTemplatesDiscardChanges(),
         negativeMethod: () -> Unit = {},
         neutralMethod: (() -> Unit)? = null,
         positiveMethod: () -> Unit,

AnkiDroid/src/main/java/com/ichi2/anki/instantnoteeditor/InstantNoteEditorActivity.kt

@@ -614,7 +614,7 @@ class InstantNoteEditorActivity :
     }
 
     private fun showDiscardChangesDialog() {
-        DiscardChangesDialog.showDialog(this) {
+        DiscardChangesDialog.showDialog(this, message = TR.addingDiscardCurrentInput()) {
             Timber.i("InstantNoteEditorActivity:: OK button pressed to confirm discard changes")
             finish()
         }

AnkiDroid/src/main/java/com/ichi2/anki/multimedia/MultimediaFragment.kt

@@ -34,6 +34,7 @@ import androidx.core.view.MenuProvider
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.viewModels
 import androidx.lifecycle.lifecycleScope
+import com.ichi2.anki.CollectionManager.TR
 import com.ichi2.anki.CrashReportService
 import com.ichi2.anki.R
 import com.ichi2.anki.common.annotations.NeedsTest
@@ -104,7 +105,7 @@ abstract class MultimediaFragment(
                 enabled = viewModel.currentMultimediaPath.value != null,
             ) {
                 override fun handleOnBackPressed() {
-                    DiscardChangesDialog.showDialog(requireContext()) {
+                    DiscardChangesDialog.showDialog(requireContext(), message = TR.addingDiscardCurrentInput()) {
                         Timber.i("MultimediaFragment:: OK button pressed to confirm discard changes")
                         isEnabled = false
                         requireActivity().onBackPressedDispatcher.onBackPressed()

AnkiDroid/src/test/java/com/ichi2/anki/CardTemplateEditorTest.kt

@@ -103,14 +103,14 @@ class CardTemplateEditorTest : RobolectricTest() {
         // Make sure we get a confirmation dialog if we hit the back button
         assertTrue("Unable to click?", shadowTestEditor.clickMenuItem(android.R.id.home))
         advanceRobolectricLooper()
-        assertEquals("Wrong dialog shown?", getAlertDialogText(true), "Discard current input?")
+        assertEquals("Wrong dialog shown?", getAlertDialogText(true), "Discard changes?")
         clickAlertDialogButton(DialogInterface.BUTTON_NEGATIVE, false)
         advanceRobolectricLooper()
         assertTrue("note type change not preserved despite canceling back button?", testEditor.noteTypeHasChanged())
 
         // Make sure we things are cleared out after a cancel
         assertTrue("Unable to click?", shadowTestEditor.clickMenuItem(android.R.id.home))
-        assertEquals("Wrong dialog shown?", getAlertDialogText(true), "Discard current input?")
+        assertEquals("Wrong dialog shown?", getAlertDialogText(true), "Discard changes?")
         clickAlertDialogButton(DialogInterface.BUTTON_POSITIVE, false)
         advanceRobolectricLooper()
         assertFalse("note type change not cleared despite discarding changes?", testEditor.noteTypeHasChanged())