Removed redundant oldCardID attribute, and corresponding simplifications.

Author: Scapesfear

AnkiDroid/src/main/java/com/ichi2/anki/CardBrowser.kt

@@ -155,7 +155,6 @@ open class CardBrowser :
     private lateinit var deckSpinnerSelection: DeckSpinnerSelection
     private var lastSelectedPosition = 0
     private var oldCardTopOffset: Int = 0
-    private var oldCardId: Long? = null
 
     @VisibleForTesting
     lateinit var cardsListView: RecyclerView
@@ -356,14 +355,12 @@ open class CardBrowser :
         if (viewModel.isInMultiSelectMode && viewModel.lastSelectedId != null) {
             viewModel.selectRowsBetween(viewModel.lastSelectedId!!, id)
         } else {
-            launchCatchingTask {
-                val position = cardsAdapter.getPositionForId(id)
+            val position = cardsAdapter.getPositionForId(id)
 
-                lastSelectedPosition = position
-                saveScrollingState(position)
+            lastSelectedPosition = position
+            saveScrollingState(position)
 
-                viewModel.toggleRowSelection(id)
-            }
+            viewModel.toggleRowSelection(id)
         }
     }
 
@@ -1921,9 +1918,8 @@ open class CardBrowser :
         ): Intent = NoteEditorLauncher.AddNoteFromCardBrowser(viewModel).getIntent(context)
     }
 
-    private suspend fun saveScrollingState(position: Int) {
-        // Save the current card id and the top offset of the card
-        oldCardId = viewModel.queryCardIdAtPosition(position)
+    private fun saveScrollingState(position: Int) {
+        // Save the top offset of the card
         oldCardTopOffset = viewModel.calculateTopOffset(cardsListView, position)
     }