refactor(test): remove 'TestClass' AnkiDroid references

Once moved to `libanki`, references will be broken

'ioDispatcher' is an AnkiDroid-level concern

Author: david-allison

AnkiDroid/src/test/java/com/ichi2/anki/RobolectricTest.kt

@@ -60,6 +60,7 @@ import com.ichi2.testutils.filter
 import com.ichi2.utils.InMemorySQLiteOpenHelperFactory
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.runBlocking
+import kotlinx.coroutines.test.TestDispatcher
 import kotlinx.coroutines.test.TestScope
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.resetMain
@@ -528,6 +529,11 @@ open class RobolectricTest :
         }
     }
 
+    override fun setupTestDispatcher(dispatcher: TestDispatcher) {
+        super.setupTestDispatcher(dispatcher)
+        ioDispatcher = dispatcher
+    }
+
     override suspend fun TestScope.runTestInner(testBody: suspend TestScope.() -> Unit) {
         collectionManager.setTestDispatcher(UnconfinedTestDispatcher(testScheduler))
         testBody()

AnkiDroid/src/test/java/com/ichi2/testutils/JvmTest.kt

@@ -21,11 +21,13 @@ import androidx.annotation.CallSuper
 import com.ichi2.anki.CollectionManager
 import com.ichi2.anki.common.time.MockTime
 import com.ichi2.anki.common.time.TimeManager
+import com.ichi2.anki.ioDispatcher
 import com.ichi2.anki.libanki.Collection
 import com.ichi2.anki.libanki.Storage
 import com.ichi2.anki.observability.ChangeManager
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.runBlocking
+import kotlinx.coroutines.test.TestDispatcher
 import kotlinx.coroutines.test.TestScope
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.resetMain
@@ -120,6 +122,11 @@ open class JvmTest : TestClass {
         println("""-- completed test "${testName.methodName}"""")
     }
 
+    override fun setupTestDispatcher(dispatcher: TestDispatcher) {
+        super.setupTestDispatcher(dispatcher)
+        ioDispatcher = dispatcher
+    }
+
     fun <T> assumeThat(
         actual: T,
         matcher: Matcher<T>?,

AnkiDroid/src/test/java/com/ichi2/testutils/TestClass.kt

@@ -17,8 +17,6 @@
 package com.ichi2.testutils
 
 import android.annotation.SuppressLint
-import com.ichi2.anki.ioDispatcher
-import com.ichi2.anki.isCollectionEmpty
 import com.ichi2.anki.libanki.Card
 import com.ichi2.anki.libanki.CardType
 import com.ichi2.anki.libanki.Collection
@@ -34,6 +32,7 @@ import com.ichi2.anki.libanki.testutils.TestCollectionManager
 import com.ichi2.anki.libanki.testutils.ext.addNote
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.test.StandardTestDispatcher
+import kotlinx.coroutines.test.TestDispatcher
 import kotlinx.coroutines.test.TestScope
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.setMain
@@ -45,7 +44,8 @@ import kotlin.time.Duration.Companion.milliseconds
 
 /**
  * marker interface for classes which contain tests and access the Anki collection
- * @see AndroidTest
+ *
+ * Android (AnkiDroid/Robolectric) is not required for these tests to run
  */
 interface TestClass {
     val col: Collection
@@ -189,7 +189,7 @@ interface TestClass {
         }
     }
 
-    /** Ensures [isCollectionEmpty] returns `false` */
+    /** Ensures `DeckUtils.isCollectionEmpty` returns `false` */
     fun ensureNonEmptyCollection() {
         addNotes(1)
     }
@@ -296,6 +296,9 @@ interface TestClass {
         col.updateNote(this)
     }
 
+    fun setupTestDispatcher(dispatcher: TestDispatcher) {
+    }
+
     /** * A wrapper around the standard [kotlinx.coroutines.test.runTest] that
      * takes care of updating the dispatcher used by CollectionManager as well.
      * * An argument could be made for using [StandardTestDispatcher] and
@@ -320,7 +323,7 @@ interface TestClass {
     ) {
         val dispatcher = UnconfinedTestDispatcher()
         Dispatchers.setMain(dispatcher)
-        ioDispatcher = dispatcher
+        setupTestDispatcher(dispatcher)
         repeat(times) {
             if (times != 1) Timber.d("------ Executing test $it/$times ------")
             kotlinx.coroutines.test.runTest(context, dispatchTimeoutMs.milliseconds) {